From mboxrd@z Thu Jan 1 00:00:00 1970 From: Erik Gabriel Carrillo Subject: [PATCH v3 0/3] timer library enhancement Date: Wed, 13 Sep 2017 17:05:05 -0500 Message-ID: <1505340308-86141-1-git-send-email-erik.g.carrillo@intel.com> References: <1503692783-16148-1-git-send-email-erik.g.carrillo@intel.com> Cc: dev@dpdk.org, konstantin.ananyev@intel.com, stephen@networkplumber.org, keith.wiles@intel.com, narender.vangati@intel.com To: rsanford@akamai.com Return-path: Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) by dpdk.org (Postfix) with ESMTP id E9AB41B19B for ; Thu, 14 Sep 2017 00:03:48 +0200 (CEST) In-Reply-To: <1503692783-16148-1-git-send-email-erik.g.carrillo@intel.com> List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" In the current implementation of the DPDK timer library, timers can be created and set to be handled by a target lcore by adding it to a skiplist that corresponds to that lcore. However, if an application enables multiple lcores, and each of these lcores repeatedly attempts to install timers on the same target lcore, overall application throughput will be reduced as all lcores contend to acquire the lock guarding the single skiplist of pending timers. This patchset addresses this scenario by adding an option to enable an array of skiplists in each lcore's priv_timer struct. Then, when lcore i installs a timer on lcore k, the timer will be added to the ith skiplist for lcore k. If lcore j installs a timer on lcore k simultaneously, lcores i and j can both proceed since they will be acquiring different locks for different lists. This functionality is off by default, and can be enabled via a new function. When lcore k processes its pending timers, if the multiple pending list option is enabled, it will traverse skiplists in its array and acquire the current skiplist's lock while a run list is broken out; meanwhile, all other lists can continue to be modified. Then, all run lists for lcore k are collected and traversed together so timers are executed in their relative order. If the multiple pending list option is not enabled (the default), only a single list will be traversed, as before. Erik Gabriel Carrillo (3): timer: add multiple pending lists option for each lcore timer: handle timers installed from non-EAL threads doc: update timer lib docs doc/guides/prog_guide/timer_lib.rst | 27 ++- doc/guides/rel_notes/release_17_11.rst | 7 + lib/librte_timer/rte_timer.c | 384 ++++++++++++++++++++++----------- lib/librte_timer/rte_timer.h | 29 ++- lib/librte_timer/rte_timer_version.map | 6 + 5 files changed, 319 insertions(+), 134 deletions(-) -- 2.6.4