All of lore.kernel.org
 help / color / mirror / Atom feed
From: Monk Liu <Monk.Liu-5C7GfCeVMHo@public.gmane.org>
To: amd-gfx-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org
Cc: Monk Liu <Monk.Liu-5C7GfCeVMHo@public.gmane.org>
Subject: [PATCH 03/18] drm/amdgpu/sriov:move in_reset to adev and rename
Date: Mon, 18 Sep 2017 14:11:47 +0800	[thread overview]
Message-ID: <1505715122-23904-4-git-send-email-Monk.Liu@amd.com> (raw)
In-Reply-To: <1505715122-23904-1-git-send-email-Monk.Liu-5C7GfCeVMHo@public.gmane.org>

currently in_reset is only used in sriov gpu reset, and it
will be used for other non-gfx hw component later, like
PSP, so move it from gfx to adev and rename to in_sriov_reset
make more sense.

Change-Id: Ibb8546f6e4635a1cca740e57f6244f158c70a1e6
Signed-off-by: Monk Liu <Monk.Liu@amd.com>
---
 drivers/gpu/drm/amd/amdgpu/amdgpu.h        | 2 +-
 drivers/gpu/drm/amd/amdgpu/amdgpu_device.c | 4 ++--
 drivers/gpu/drm/amd/amdgpu/gfx_v8_0.c      | 6 +++---
 drivers/gpu/drm/amd/amdgpu/gfx_v9_0.c      | 6 +++---
 4 files changed, 9 insertions(+), 9 deletions(-)

diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu.h b/drivers/gpu/drm/amd/amdgpu/amdgpu.h
index a34c4cb..cc9a232 100644
--- a/drivers/gpu/drm/amd/amdgpu/amdgpu.h
+++ b/drivers/gpu/drm/amd/amdgpu/amdgpu.h
@@ -1019,7 +1019,6 @@ struct amdgpu_gfx {
 	/* reset mask */
 	uint32_t                        grbm_soft_reset;
 	uint32_t                        srbm_soft_reset;
-	bool                            in_reset;
 	/* s3/s4 mask */
 	bool                            in_suspend;
 	/* NGG */
@@ -1588,6 +1587,7 @@ struct amdgpu_device {
 
 	/* record last mm index being written through WREG32*/
 	unsigned long last_mm_index;
+	bool                            in_sriov_reset;
 };
 
 static inline struct amdgpu_device *amdgpu_ttm_adev(struct ttm_bo_device *bdev)
diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c
index 3467179..298a241 100644
--- a/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c
+++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c
@@ -2757,7 +2757,7 @@ int amdgpu_sriov_gpu_reset(struct amdgpu_device *adev, struct amdgpu_job *job)
 
 	mutex_lock(&adev->virt.lock_reset);
 	atomic_inc(&adev->gpu_reset_counter);
-	adev->gfx.in_reset = true;
+	adev->in_sriov_reset = true;
 
 	/* block TTM */
 	resched = ttm_bo_lock_delayed_workqueue(&adev->mman.bdev);
@@ -2868,7 +2868,7 @@ int amdgpu_sriov_gpu_reset(struct amdgpu_device *adev, struct amdgpu_job *job)
 		dev_info(adev->dev, "GPU reset successed!\n");
 	}
 
-	adev->gfx.in_reset = false;
+	adev->in_sriov_reset = false;
 	mutex_unlock(&adev->virt.lock_reset);
 	return r;
 }
diff --git a/drivers/gpu/drm/amd/amdgpu/gfx_v8_0.c b/drivers/gpu/drm/amd/amdgpu/gfx_v8_0.c
index 6ee348e..3f511a9 100644
--- a/drivers/gpu/drm/amd/amdgpu/gfx_v8_0.c
+++ b/drivers/gpu/drm/amd/amdgpu/gfx_v8_0.c
@@ -4810,7 +4810,7 @@ static int gfx_v8_0_kiq_init_queue(struct amdgpu_ring *ring)
 
 	gfx_v8_0_kiq_setting(ring);
 
-	if (adev->gfx.in_reset) { /* for GPU_RESET case */
+	if (adev->in_sriov_reset) { /* for GPU_RESET case */
 		/* reset MQD to a clean status */
 		if (adev->gfx.mec.mqd_backup[mqd_idx])
 			memcpy(mqd, adev->gfx.mec.mqd_backup[mqd_idx], sizeof(struct vi_mqd_allocation));
@@ -4847,7 +4847,7 @@ static int gfx_v8_0_kcq_init_queue(struct amdgpu_ring *ring)
 	struct vi_mqd *mqd = ring->mqd_ptr;
 	int mqd_idx = ring - &adev->gfx.compute_ring[0];
 
-	if (!adev->gfx.in_reset && !adev->gfx.in_suspend) {
+	if (!adev->in_sriov_reset && !adev->gfx.in_suspend) {
 		memset((void *)mqd, 0, sizeof(struct vi_mqd_allocation));
 		((struct vi_mqd_allocation *)mqd)->dynamic_cu_mask = 0xFFFFFFFF;
 		((struct vi_mqd_allocation *)mqd)->dynamic_rb_mask = 0xFFFFFFFF;
@@ -4859,7 +4859,7 @@ static int gfx_v8_0_kcq_init_queue(struct amdgpu_ring *ring)
 
 		if (adev->gfx.mec.mqd_backup[mqd_idx])
 			memcpy(adev->gfx.mec.mqd_backup[mqd_idx], mqd, sizeof(struct vi_mqd_allocation));
-	} else if (adev->gfx.in_reset) { /* for GPU_RESET case */
+	} else if (adev->in_sriov_reset) { /* for GPU_RESET case */
 		/* reset MQD to a clean status */
 		if (adev->gfx.mec.mqd_backup[mqd_idx])
 			memcpy(mqd, adev->gfx.mec.mqd_backup[mqd_idx], sizeof(struct vi_mqd_allocation));
diff --git a/drivers/gpu/drm/amd/amdgpu/gfx_v9_0.c b/drivers/gpu/drm/amd/amdgpu/gfx_v9_0.c
index c133c85..21838f4 100644
--- a/drivers/gpu/drm/amd/amdgpu/gfx_v9_0.c
+++ b/drivers/gpu/drm/amd/amdgpu/gfx_v9_0.c
@@ -2698,7 +2698,7 @@ static int gfx_v9_0_kiq_init_queue(struct amdgpu_ring *ring)
 
 	gfx_v9_0_kiq_setting(ring);
 
-	if (adev->gfx.in_reset) { /* for GPU_RESET case */
+	if (adev->in_sriov_reset) { /* for GPU_RESET case */
 		/* reset MQD to a clean status */
 		if (adev->gfx.mec.mqd_backup[mqd_idx])
 			memcpy(mqd, adev->gfx.mec.mqd_backup[mqd_idx], sizeof(struct v9_mqd_allocation));
@@ -2736,7 +2736,7 @@ static int gfx_v9_0_kcq_init_queue(struct amdgpu_ring *ring)
 	struct v9_mqd *mqd = ring->mqd_ptr;
 	int mqd_idx = ring - &adev->gfx.compute_ring[0];
 
-	if (!adev->gfx.in_reset && !adev->gfx.in_suspend) {
+	if (!adev->in_sriov_reset && !adev->gfx.in_suspend) {
 		memset((void *)mqd, 0, sizeof(struct v9_mqd_allocation));
 		((struct v9_mqd_allocation *)mqd)->dynamic_cu_mask = 0xFFFFFFFF;
 		((struct v9_mqd_allocation *)mqd)->dynamic_rb_mask = 0xFFFFFFFF;
@@ -2748,7 +2748,7 @@ static int gfx_v9_0_kcq_init_queue(struct amdgpu_ring *ring)
 
 		if (adev->gfx.mec.mqd_backup[mqd_idx])
 			memcpy(adev->gfx.mec.mqd_backup[mqd_idx], mqd, sizeof(struct v9_mqd_allocation));
-	} else if (adev->gfx.in_reset) { /* for GPU_RESET case */
+	} else if (adev->in_sriov_reset) { /* for GPU_RESET case */
 		/* reset MQD to a clean status */
 		if (adev->gfx.mec.mqd_backup[mqd_idx])
 			memcpy(mqd, adev->gfx.mec.mqd_backup[mqd_idx], sizeof(struct v9_mqd_allocation));
-- 
2.7.4

_______________________________________________
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx

  parent reply	other threads:[~2017-09-18  6:11 UTC|newest]

Thread overview: 61+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-09-18  6:11 [PATCH 00/18] *** misc patches for SRIOV *** Monk Liu
     [not found] ` <1505715122-23904-1-git-send-email-Monk.Liu-5C7GfCeVMHo@public.gmane.org>
2017-09-18  6:11   ` [PATCH 01/18] drm/amdgpu/sriov:fix missing error handling Monk Liu
     [not found]     ` <1505715122-23904-2-git-send-email-Monk.Liu-5C7GfCeVMHo@public.gmane.org>
2017-09-18  9:04       ` Christian König
2017-09-18  6:11   ` [PATCH 02/18] drm/amdgpu:no kiq in IH Monk Liu
     [not found]     ` <1505715122-23904-3-git-send-email-Monk.Liu-5C7GfCeVMHo@public.gmane.org>
2017-09-18  9:05       ` Christian König
2017-09-18  6:11   ` Monk Liu [this message]
     [not found]     ` <1505715122-23904-4-git-send-email-Monk.Liu-5C7GfCeVMHo@public.gmane.org>
2017-09-18  9:05       ` [PATCH 03/18] drm/amdgpu/sriov:move in_reset to adev and rename Christian König
2017-09-18  6:11   ` [PATCH 04/18] drm/amdgpu/sriov:don't load psp fw during gpu reset Monk Liu
     [not found]     ` <1505715122-23904-5-git-send-email-Monk.Liu-5C7GfCeVMHo@public.gmane.org>
2017-09-18  9:06       ` Christian König
     [not found]         ` <2cd93ffd-91a6-77c6-b07c-c68188a340a5-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2017-09-20  1:32           ` Quan, Evan
     [not found]             ` <DM5PR1201MB2489EF41F0B4703FE248AEBDE4610-grEf7a3NxMAAZHT/xKzwlGrFom/aUZj6nBOFsp37pqbUKgpGm//BTAC/G2K4zDHf@public.gmane.org>
2017-09-20  1:54               ` Liu, Monk
2017-09-18  6:11   ` [PATCH 05/18] drm/amdgpu:make ctx_add_fence interruptible Monk Liu
     [not found]     ` <1505715122-23904-6-git-send-email-Monk.Liu-5C7GfCeVMHo@public.gmane.org>
2017-09-18  9:10       ` Christian König
2017-09-18  6:11   ` [PATCH 06/18] drm/amdgpu/sriov:fix memory leak after gpu reset Monk Liu
     [not found]     ` <1505715122-23904-7-git-send-email-Monk.Liu-5C7GfCeVMHo@public.gmane.org>
2017-09-18  9:12       ` Christian König
     [not found]         ` <f96a1189-2fe3-6466-df1b-557f87319cb9-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2017-09-18 10:47           ` Liu, Monk
     [not found]             ` <BLUPR12MB0449D8D7812A4C80EDA2253D84630-7LeqcoF/hwpTIQvHjXdJlwdYzm3356FpvxpqHgZTriW3zl9H0oFU5g@public.gmane.org>
2017-09-18 11:34               ` Christian König
     [not found]                 ` <45fa4145-41a4-6186-4f35-4f3347bad601-5C7GfCeVMHo@public.gmane.org>
2017-09-20  2:27                   ` Liu, Monk
2017-09-18  6:11   ` [PATCH 07/18] drm/amdgpu:add hdp golden setting register name hint Monk Liu
     [not found]     ` <1505715122-23904-8-git-send-email-Monk.Liu-5C7GfCeVMHo@public.gmane.org>
2017-09-18  9:13       ` Christian König
2017-09-18  6:11   ` [PATCH 08/18] drm/amdgpu:halt when vm fault Monk Liu
     [not found]     ` <1505715122-23904-9-git-send-email-Monk.Liu-5C7GfCeVMHo@public.gmane.org>
2017-09-18  9:14       ` Christian König
2017-09-18  6:11   ` [PATCH 09/18] drm/amdgpu:insert TMZ_BEGIN Monk Liu
     [not found]     ` <1505715122-23904-10-git-send-email-Monk.Liu-5C7GfCeVMHo@public.gmane.org>
2017-09-18  9:15       ` Christian König
2017-09-18  6:11   ` [PATCH 10/18] drm/amdgpu:hdp flush should be put it initialized Monk Liu
     [not found]     ` <1505715122-23904-11-git-send-email-Monk.Liu-5C7GfCeVMHo@public.gmane.org>
2017-09-18  9:16       ` Christian König
2017-09-18  6:11   ` [PATCH 11/18] drm/amdgpu:add vgt_flush for gfx9 Monk Liu
     [not found]     ` <1505715122-23904-12-git-send-email-Monk.Liu-5C7GfCeVMHo@public.gmane.org>
2017-09-18  9:18       ` Christian König
     [not found]         ` <34ac878c-5bf7-7735-1787-b5d3c1691fd2-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2017-09-18 15:48           ` Marek Olšák
2017-09-18  6:11   ` [PATCH 12/18] drm/amdgpu:use formal register to trigger hdp invalidate Monk Liu
     [not found]     ` <1505715122-23904-13-git-send-email-Monk.Liu-5C7GfCeVMHo@public.gmane.org>
2017-09-18  9:19       ` Christian König
     [not found]         ` <2f11f862-6022-7a97-17ab-ae2c634f0061-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2017-09-18 11:03           ` Liu, Monk
     [not found]             ` <BLUPR12MB04497CDE395DCE35F830DD4F84630-7LeqcoF/hwpTIQvHjXdJlwdYzm3356FpvxpqHgZTriW3zl9H0oFU5g@public.gmane.org>
2017-09-18 11:39               ` Christian König
     [not found]                 ` <4de1beaf-95c0-ba6e-da79-1070074f82e8-5C7GfCeVMHo@public.gmane.org>
2017-09-19  4:04                   ` Liu, Monk
     [not found]                     ` <BLUPR12MB0449D86C880B4B15A4FD916884600-7LeqcoF/hwpTIQvHjXdJlwdYzm3356FpvxpqHgZTriW3zl9H0oFU5g@public.gmane.org>
2017-09-19  4:25                       ` Zhou, David(ChunMing)
     [not found]                         ` <MWHPR1201MB020621C233AA2C12F6127C61B4600-3iK1xFAIwjrUF/YbdlDdgWrFom/aUZj6nBOFsp37pqbUKgpGm//BTAC/G2K4zDHf@public.gmane.org>
2017-09-19  6:46                           ` Liu, Monk
     [not found]                             ` <BLUPR12MB0449F560B6A658DC4C120EC084600-7LeqcoF/hwpTIQvHjXdJlwdYzm3356FpvxpqHgZTriW3zl9H0oFU5g@public.gmane.org>
2017-09-19  6:50                               ` zhoucm1
     [not found]                                 ` <baa9518f-d2b1-cfb8-8f98-c3557e3ef8fe-5C7GfCeVMHo@public.gmane.org>
2017-09-19  7:00                                   ` Liu, Monk
     [not found]                                     ` <BLUPR12MB0449775C4245A708B15E9D0B84600-7LeqcoF/hwpTIQvHjXdJlwdYzm3356FpvxpqHgZTriW3zl9H0oFU5g@public.gmane.org>
2017-09-19  7:02                                       ` zhoucm1
     [not found]                                         ` <5367a2b2-3044-7388-08ff-6f0a620d5aa8-5C7GfCeVMHo@public.gmane.org>
2017-09-19  8:30                                           ` Christian König
     [not found]                                             ` <28fa17b6-ebb0-99c7-042a-19289d858f64-5C7GfCeVMHo@public.gmane.org>
2017-09-19  9:34                                               ` Zhang, Jerry (Junwei)
2017-09-19 13:42                                               ` Alex Deucher
2017-09-18  6:11   ` [PATCH 13/18] drm/amdgpu:fix driver unloading bug Monk Liu
     [not found]     ` <1505715122-23904-14-git-send-email-Monk.Liu-5C7GfCeVMHo@public.gmane.org>
2017-09-18  9:27       ` Christian König
     [not found]         ` <1821bf91-83d8-c933-704d-fcd8db07def1-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2017-09-18 10:12           ` Liu, Monk
     [not found]             ` <BLUPR12MB0449D3944109EA4A7D151A2684630-7LeqcoF/hwpTIQvHjXdJlwdYzm3356FpvxpqHgZTriW3zl9H0oFU5g@public.gmane.org>
2017-09-18 11:53               ` Christian König
     [not found]                 ` <fade2e70-6594-9a6e-9d5a-d488d360363e-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2017-09-19  4:14                   ` Liu, Monk
     [not found]                     ` <BLUPR12MB04498EEB2BF374C72EF7CF5384600-7LeqcoF/hwpTIQvHjXdJlwdYzm3356FpvxpqHgZTriW3zl9H0oFU5g@public.gmane.org>
2017-09-19  8:26                       ` Christian König
     [not found]                         ` <69a1e774-6a9e-31c6-8b30-dfbd430062c8-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2017-09-19 11:37                           ` Liu, Monk
2017-09-18  6:11   ` [PATCH 14/18] drm/amdgpu: Fix amdgpu reload failure under SRIOV Monk Liu
     [not found]     ` <1505715122-23904-15-git-send-email-Monk.Liu-5C7GfCeVMHo@public.gmane.org>
2017-09-18  9:10       ` Yu, Xiangliang
2017-09-18  9:31       ` Christian König
     [not found]         ` <0951ed06-954a-0f31-6b6e-ba923be008a2-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2017-09-18 21:07           ` Alex Deucher
     [not found]             ` <CADnq5_Nj5Kqp4CXtFLLz-cPynvchBV-RLFFpB6e5D-OCyPXQiQ-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2017-09-19  1:52               ` Yu, Xiangliang
2017-09-18  6:11   ` [PATCH 15/18] drm/amdgpu/sriov: fix page fault issue of driver unload Monk Liu
     [not found]     ` <1505715122-23904-16-git-send-email-Monk.Liu-5C7GfCeVMHo@public.gmane.org>
2017-09-18  9:22       ` Christian König
2017-09-18  6:12   ` [PATCH 16/18] drm/amdgpu: increate mailbox polling timeout to 12s Monk Liu
     [not found]     ` <1505715122-23904-17-git-send-email-Monk.Liu-5C7GfCeVMHo@public.gmane.org>
2017-09-18  9:23       ` Christian König
2017-09-18  6:12   ` [PATCH 17/18] drm/amdgpu:fix uvd ring fini routine Monk Liu
     [not found]     ` <1505715122-23904-18-git-send-email-Monk.Liu-5C7GfCeVMHo@public.gmane.org>
2017-09-18  9:25       ` Christian König
2017-09-18  6:12   ` [PATCH 18/18] drm/amdgpu/sriov:init csb for gfxv9 Monk Liu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1505715122-23904-4-git-send-email-Monk.Liu@amd.com \
    --to=monk.liu-5c7gfcevmho@public.gmane.org \
    --cc=amd-gfx-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.