From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from s3.sipsolutions.net ([5.9.151.49]:52774 "EHLO sipsolutions.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752392AbdIXPFk (ORCPT ); Sun, 24 Sep 2017 11:05:40 -0400 Message-ID: <1506265531.2909.5.camel@sipsolutions.net> (sfid-20170924_170601_619391_6DDA437D) Subject: Re: [PATCH] mac80211: aead api to reduce redundancy From: Johannes Berg To: Xiang Gao , herbert@gondor.apana.org.au, davem@davemloft.net, linux-crypto@vger.kernel.org, linux-kernel@vger.kernel.org, linux-wireless@vger.kernel.org, netdev@vger.kernel.org Date: Sun, 24 Sep 2017 17:05:31 +0200 In-Reply-To: <20170924054015.8958-1-qasdfgtyuiop@gmail.com> (sfid-20170924_074130_810821_889115CC) References: <20170924054015.8958-1-qasdfgtyuiop@gmail.com> (sfid-20170924_074130_810821_889115CC) Content-Type: text/plain; charset="UTF-8" Mime-Version: 1.0 Sender: linux-wireless-owner@vger.kernel.org List-ID: On Sun, 2017-09-24 at 01:40 -0400, Xiang Gao wrote: > Currently, the aes_ccm.c and aes_gcm.c are almost line by line > copy of each other. This patch reduce code redundancy by moving > the code in these two files to crypto/aead_api.c to make it a > higher level aead api. The aes_ccm.c and aes_gcm.c are removed > and all the functions are now implemented in their headers using > the newly added aead api. > No objection from me, though I'd ask you to respin with the indentation fixed up a bit. johannes