From mboxrd@z Thu Jan 1 00:00:00 1970 From: Chris Wilson Subject: Re: [PATCH 8/8] drm/i915: Gate engine stats collection with a static key Date: Mon, 25 Sep 2017 18:56:07 +0100 Message-ID: <150636216775.18819.832708659692439352@mail.alporthouse.com> References: <20170925151543.7395-1-tvrtko.ursulin@linux.intel.com> <20170925151543.7395-9-tvrtko.ursulin@linux.intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from fireflyinternet.com (mail.fireflyinternet.com [109.228.58.192]) by gabe.freedesktop.org (Postfix) with ESMTPS id 9ECC66E388 for ; Mon, 25 Sep 2017 17:56:12 +0000 (UTC) In-Reply-To: <20170925151543.7395-9-tvrtko.ursulin@linux.intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Tvrtko Ursulin , Intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org UXVvdGluZyBUdnJ0a28gVXJzdWxpbiAoMjAxNy0wOS0yNSAxNjoxNTo0MykKPiBGcm9tOiBUdnJ0 a28gVXJzdWxpbiA8dHZydGtvLnVyc3VsaW5AaW50ZWwuY29tPgo+IAo+IFRoaXMgcmVkdWNlcyB0 aGUgY29zdCBvZiB0aGUgc29mdHdhcmUgZW5naW5lIGJ1c3luZXNzIHRyYWNraW5nCj4gdG8gYSBz aW5nbGUgbm8tb3AgaW5zdHJ1Y3Rpb24gd2hlbiB0aGVyZSBhcmUgbm8gbGlzdGVuZXJzLgo+IAo+ IHYyOiBSZWJhc2UgYW5kIHNvbWUgY29tbWVudHMuCj4gdjM6IFJlYmFzZS4KPiB2NDogQ2hlY2tw YXRjaCBmaXhlcy4KPiB2NTogUmViYXNlLgo+IHY2OiBVc2Ugc3lzdGVtX2xvbmdfd3EgdG8gYXZv aWQgYmVpbmcgYmxvY2tlZCBieSBzdHJ1Y3RfbXV0ZXgKPiAgICAgdXNlcnMuCj4gdjc6IEZpeCBi YWQgY29uZmxpY3QgcmVzb2x1dGlvbiBmcm9tIGxhc3QgcmViYXNlLiAoRG1pdHJ5IFJvZ296aGtp bikKPiB2ODogUmViYXNlLgo+IAo+IFNpZ25lZC1vZmYtYnk6IFR2cnRrbyBVcnN1bGluIDx0dnJ0 a28udXJzdWxpbkBpbnRlbC5jb20+CgpCYWgsIHN0aWxsIHVuaGFwcHkgYWJvdXQgdGhlIGdsb2Jh bC4gSSBrbm93IGluIGFsbCBsaWtlbGlob29kIGl0IGRvZXNuJ3QKbWF0dGVyLCBidXQgaXQgc3Rp bGwgYnVncyBtZS4KCj4gLS0tCj4gIGRyaXZlcnMvZ3B1L2RybS9pOTE1L2k5MTVfcG11LmMgICAg ICAgICB8ICA1NCArKysrKysrKysrKysrKystLQo+ICBkcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRl bF9lbmdpbmVfY3MuYyAgfCAgMTcgKysrKysrCj4gIGRyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVs X3JpbmdidWZmZXIuaCB8IDEwMSArKysrKysrKysrKysrKysrKysrKy0tLS0tLS0tLS0tLQo+ICAz IGZpbGVzIGNoYW5nZWQsIDEzMCBpbnNlcnRpb25zKCspLCA0MiBkZWxldGlvbnMoLSkKPiAKPiBk aWZmIC0tZ2l0IGEvZHJpdmVycy9ncHUvZHJtL2k5MTUvaTkxNV9wbXUuYyBiL2RyaXZlcnMvZ3B1 L2RybS9pOTE1L2k5MTVfcG11LmMKPiBpbmRleCAyMjhhYTUwY2U3MDkuLmU3NjhmMzNlYmIzZCAx MDA2NDQKPiAtLS0gYS9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pOTE1X3BtdS5jCj4gKysrIGIvZHJp dmVycy9ncHUvZHJtL2k5MTUvaTkxNV9wbXUuYwo+IEBAIC01MDEsMTEgKzUwMSwxNyBAQCBzdGF0 aWMgdm9pZCBpOTE1X3BtdV9lbmFibGUoc3RydWN0IHBlcmZfZXZlbnQgKmV2ZW50KQo+ICAgICAg ICAgICAgICAgICBHRU1fQlVHX09OKHNhbXBsZSA+PSBJOTE1X1BNVV9TQU1QTEVfQklUUyk7Cj4g ICAgICAgICAgICAgICAgIEdFTV9CVUdfT04oZW5naW5lLT5wbXUuZW5hYmxlX2NvdW50W3NhbXBs ZV0gPT0gfjApOwo+ICAgICAgICAgICAgICAgICBpZiAoZW5naW5lLT5wbXUuZW5hYmxlX2NvdW50 W3NhbXBsZV0rKyA9PSAwKSB7Cj4gKyAgICAgICAgICAgICAgICAgICAgICAgLyoKPiArICAgICAg ICAgICAgICAgICAgICAgICAgKiBFbmFibGUgZW5naW5lIGJ1c3kgc3RhdHMgdHJhY2tpbmcgaWYg bmVlZGVkIG9yCj4gKyAgICAgICAgICAgICAgICAgICAgICAgICogYWx0ZXJuYXRpdmVseSBjYW5j ZWwgdGhlIHNjaGVkdWxlZCBkaXNhYmxpbmcgb2YgdGhlCj4gKyAgICAgICAgICAgICAgICAgICAg ICAgICogc2FtZS4KPiArICAgICAgICAgICAgICAgICAgICAgICAgKi8KPiAgICAgICAgICAgICAg ICAgICAgICAgICBpZiAoZW5naW5lX25lZWRzX2J1c3lfc3RhdHMoZW5naW5lKSAmJgo+ICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAhZW5naW5lLT5wbXUuYnVzeV9zdGF0cykgewo+IC0gICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgZW5naW5lLT5wbXUuYnVzeV9zdGF0cyA9Cj4gLSAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIGludGVsX2VuYWJsZV9lbmdpbmVf c3RhdHMoZW5naW5lKSA9PSAwOwo+IC0gICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgV0FS Tl9PTl9PTkNFKCFlbmdpbmUtPnBtdS5idXN5X3N0YXRzKTsKPiArICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgIGVuZ2luZS0+cG11LmJ1c3lfc3RhdHMgPSB0cnVlOwo+ICsgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgaWYgKCFjYW5jZWxfZGVsYXllZF93b3JrKCZlbmdpbmUtPnBt dS5kaXNhYmxlX2J1c3lfc3RhdHMpKQo+ICsgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICBxdWV1ZV93b3JrKHN5c3RlbV9sb25nX3dxLAo+ICsgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICZlbmdpbmUtPnBtdS5lbmFibGVfYnVzeV9z dGF0cyk7Cj4gICAgICAgICAgICAgICAgICAgICAgICAgfQo+ICAgICAgICAgICAgICAgICB9Cj4g ICAgICAgICB9Cj4gQEAgLTU0OCw3ICs1NTQsMTUgQEAgc3RhdGljIHZvaWQgaTkxNV9wbXVfZGlz YWJsZShzdHJ1Y3QgcGVyZl9ldmVudCAqZXZlbnQpCj4gICAgICAgICAgICAgICAgICAgICAgICAg aWYgKCFlbmdpbmVfbmVlZHNfYnVzeV9zdGF0cyhlbmdpbmUpICYmCj4gICAgICAgICAgICAgICAg ICAgICAgICAgICAgIGVuZ2luZS0+cG11LmJ1c3lfc3RhdHMpIHsKPiAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgIGVuZ2luZS0+cG11LmJ1c3lfc3RhdHMgPSBmYWxzZTsKPiAtICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgIGludGVsX2Rpc2FibGVfZW5naW5lX3N0YXRzKGVuZ2lu ZSk7Cj4gKyAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAvKgo+ICsgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICogV2UgcmVxdWVzdCBhIGRlbGF5ZWQgZGlzYWJsZSB0byBoYW5k bGUgdGhlCj4gKyAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgKiByYXBpZCBvbi9vZmYg Y3ljbGVzIG9uIGV2ZW50cyB3aGljaCBjYW4KPiArICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAqIGhhcHBlbiB3aGVuIHRvb2xzIGxpa2UgcGVyZiBzdGF0IHN0YXJ0IGluIGEKPiArICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAqIG5pY2VyIHdheS4KPiArICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAqLwo+ICsgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg cXVldWVfZGVsYXllZF93b3JrKHN5c3RlbV9sb25nX3dxLAo+ICsgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICZlbmdpbmUtPnBtdS5kaXNhYmxlX2J1c3lf c3RhdHMsCj4gKyAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgcm91bmRfamlmZmllc191cF9yZWxhdGl2ZShIWikpOwoKV2hhdCdzIHByZXZlbnRpbmcgdGhl IHBlcnZlcnNlIHN5c3RlbSBmcm9tIGV4ZWN1dGluZyB0aGUgZW5hYmxlIGFmdGVyCnRoZSBkaXNh YmxlPyBTYXkgdGhlIGVuYWJsZSB3YXMgc2NoZWR1bGVkIG9uIGFub3RoZXIgY3B1IHRoYXQgd2Fz CnN0YWxsZWQ/CgpTb21ldGhpbmcgbGlrZSBhIGlmIChjYW5jZWxfd29yayhlbmFibGUpKSByZXR1 cm4gPwoKPiAgICAgICAgICAgICAgICAgICAgICAgICB9Cj4gICAgICAgICAgICAgICAgIH0KPiAg ICAgICAgIH0KPiBAQCAtNzM5LDkgKzc1MywyNyBAQCBzdGF0aWMgaW50IGk5MTVfcG11X2NwdV9v ZmZsaW5lKHVuc2lnbmVkIGludCBjcHUsIHN0cnVjdCBobGlzdF9ub2RlICpub2RlKQo+ICAgICAg ICAgcmV0dXJuIDA7Cj4gIH0KPiAgCj4gK3N0YXRpYyB2b2lkIF9fZW5hYmxlX2J1c3lfc3RhdHMo c3RydWN0IHdvcmtfc3RydWN0ICp3b3JrKQo+ICt7Cj4gKyAgICAgICBzdHJ1Y3QgaW50ZWxfZW5n aW5lX2NzICplbmdpbmUgPQo+ICsgICAgICAgICAgICAgICBjb250YWluZXJfb2Yod29yaywgdHlw ZW9mKCplbmdpbmUpLCBwbXUuZW5hYmxlX2J1c3lfc3RhdHMpOwo+ICsKPiArICAgICAgIFdBUk5f T05fT05DRShpbnRlbF9lbmFibGVfZW5naW5lX3N0YXRzKGVuZ2luZSkpOwo+ICt9Cj4gKwo+ICtz dGF0aWMgdm9pZCBfX2Rpc2FibGVfYnVzeV9zdGF0cyhzdHJ1Y3Qgd29ya19zdHJ1Y3QgKndvcmsp Cj4gK3sKPiArICAgICAgIHN0cnVjdCBpbnRlbF9lbmdpbmVfY3MgKmVuZ2luZSA9Cj4gKyAgICAg ICAgICAgICAgY29udGFpbmVyX29mKHdvcmssIHR5cGVvZigqZW5naW5lKSwgcG11LmRpc2FibGVf YnVzeV9zdGF0cy53b3JrKTsKPiArCj4gKyAgICAgICBpbnRlbF9kaXNhYmxlX2VuZ2luZV9zdGF0 cyhlbmdpbmUpOwo+ICt9Cj4gKwo+ICB2b2lkIGk5MTVfcG11X3JlZ2lzdGVyKHN0cnVjdCBkcm1f aTkxNV9wcml2YXRlICppOTE1KQo+ICB7Cj4gICAgICAgICBpbnQgcmV0Owo+ICsgICAgICAgc3Ry dWN0IGludGVsX2VuZ2luZV9jcyAqZW5naW5lOwo+ICsgICAgICAgZW51bSBpbnRlbF9lbmdpbmVf aWQgaWQ7CgpXaGF0IGEgbmljZSBDaHJpc3RtYXMgdHJlZSB5b3UgYXJlIGdyb3dpbmcgOi1wCi1D aHJpcwpfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwpJbnRl bC1nZnggbWFpbGluZyBsaXN0CkludGVsLWdmeEBsaXN0cy5mcmVlZGVza3RvcC5vcmcKaHR0cHM6 Ly9saXN0cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0aW5mby9pbnRlbC1nZngK