All of lore.kernel.org
 help / color / mirror / Atom feed
From: Joe Perches <joe@perches.com>
To: Srinivasan Shanmugam <srinivasan.rns@gmail.com>,
	gregkh@linuxfoundation.org, devel@driverdev.osuosl.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH] Staging: rtl8723bs: Externs should be avoided in .C file
Date: Wed, 04 Oct 2017 04:12:49 -0700	[thread overview]
Message-ID: <1507115569.4434.1.camel@perches.com> (raw)
In-Reply-To: <1507107600-2730-1-git-send-email-srinivasan.rns@gmail.com>

On Wed, 2017-10-04 at 11:00 +0200, Srinivasan Shanmugam wrote:
> This patch fixes the following checkpatch.pl warning.
> WARNING: externs should be avoided in .c files

Nope.

> diff --git a/drivers/staging/rtl8723bs/core/rtw_ap.c b/drivers/staging/rtl8723bs/core/rtw_ap.c
[]
> @@ -17,12 +17,6 @@
>  #include <drv_types.h>
>  #include <rtw_debug.h>
>  
> -extern unsigned char RTW_WPA_OUI[];
> -extern unsigned char WMM_OUI[];
> -extern unsigned char WPS_OUI[];
> -extern unsigned char P2P_OUI[];
> -extern unsigned char WFD_OUT[];
> -
>  void init_mlme_ap_info(struct adapter *padapter)
>  {
>  	struct mlme_priv *pmlmepriv = &(padapter->mlmepriv);

Please compile any files modified by your proposed
changes _before_ you
submit them.

For instance:

$ git grep -w RTW_WPA_OUI drivers/staging/rtl8723bs/core/rtw_ap.c
drivers/staging/rtl8723bs/core/rtw_ap.c:extern unsigned char RTW_WPA_OUI[];
drivers/staging/rtl8723bs/core/rtw_ap.c:        if (!memcmp(RTW_WPA_OUI, oui, 4))

  reply	other threads:[~2017-10-04 11:12 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-10-04  9:00 [PATCH] Staging: rtl8723bs: Externs should be avoided in .C file Srinivasan Shanmugam
2017-10-04 11:12 ` Joe Perches [this message]
     [not found]   ` <CAFsTbWc3z5qbZXt5wfWO-0R31aPFO7mgYr6jhP_Tu==GMky2Dw@mail.gmail.com>
2017-10-04 12:18     ` Joe Perches
2017-10-04 14:37 Srinivasan Shanmugam
2017-10-04 17:21 Srinivasan Shanmugam
2017-10-18 13:59 ` Greg KH
2017-10-04 17:24 Srinivasan Shanmugam
2017-10-05  4:26 ` Joe Perches
2017-10-05 11:28 Srinivasan Shanmugam
2017-10-05 13:03 ` Joe Perches

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1507115569.4434.1.camel@perches.com \
    --to=joe@perches.com \
    --cc=devel@driverdev.osuosl.org \
    --cc=gregkh@linuxfoundation.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=srinivasan.rns@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.