From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752102AbdJDMSx (ORCPT ); Wed, 4 Oct 2017 08:18:53 -0400 Received: from smtprelay0181.hostedemail.com ([216.40.44.181]:52610 "EHLO smtprelay.hostedemail.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751699AbdJDMSw (ORCPT ); Wed, 4 Oct 2017 08:18:52 -0400 X-Session-Marker: 6A6F6540706572636865732E636F6D X-Spam-Summary: 2,0,0,,d41d8cd98f00b204,joe@perches.com,:::::::,RULES_HIT:41:355:379:541:599:968:973:988:989:1260:1277:1311:1313:1314:1345:1359:1373:1437:1515:1516:1518:1534:1540:1593:1594:1711:1730:1747:1777:1792:2110:2393:2559:2562:2828:3138:3139:3140:3141:3142:3352:3622:3865:3866:3868:3870:3871:3872:3873:3874:4321:5007:10004:10400:10848:11026:11232:11473:11658:11914:12043:12295:12740:12760:12895:13069:13095:13163:13229:13311:13357:13439:14180:14659:21060:21080:21433:21434:21451:21611:21627:30054:30091,0,RBL:none,CacheIP:none,Bayesian:0.5,0.5,0.5,Netcheck:none,DomainCache:0,MSF:not bulk,SPF:,MSBL:0,DNSBL:none,Custom_rules:0:0:0,LFtime:1,LUA_SUMMARY:none X-HE-Tag: tax22_4d3f208213934 X-Filterd-Recvd-Size: 1829 Message-ID: <1507119529.4434.3.camel@perches.com> Subject: Re: [PATCH] Staging: rtl8723bs: Externs should be avoided in .C file From: Joe Perches To: srinivasan Cc: gregkh@linuxfoundation.org, devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org Date: Wed, 04 Oct 2017 05:18:49 -0700 In-Reply-To: References: <1507107600-2730-1-git-send-email-srinivasan.rns@gmail.com> <1507115569.4434.1.camel@perches.com> Content-Type: text/plain; charset="ISO-8859-1" X-Mailer: Evolution 3.22.6-1ubuntu1 Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, 2017-10-04 at 13:53 +0200, srinivasan wrote: > Hi Joe, > > Thanks for your responses. I have already compiled and the below is the > logs for the same > > Please let me know if am I missing/doing wrong Your commit message is incomplete. checkpatch is a guide, but it's not what you should be describing here. What whould be in the commit message is that these externs are unnecessary as they are done via #include of drivers/staging/rtl8723bs/include/rtw_mlme_ext.h Also, your patch is not comprehensive. Please remove the unnecessary externs from all uses: drivers/staging/rtl8723bs/core/rtw_wlan_util.c:extern unsigned char RTW_WPA_OUI[]; And that file has the odd and conflicting static unsigned char WPA_TKIP_CIPHER[4] = {0x00, 0x50, 0xf2, 0x02}; [] extern unsigned char WPA_TKIP_CIPHER[4]; Where the extern is also unnecessary. cheers, Joe