From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751297AbdJEE0F (ORCPT ); Thu, 5 Oct 2017 00:26:05 -0400 Received: from smtprelay0240.hostedemail.com ([216.40.44.240]:35143 "EHLO smtprelay.hostedemail.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1750803AbdJEE0E (ORCPT ); Thu, 5 Oct 2017 00:26:04 -0400 X-Session-Marker: 6A6F6540706572636865732E636F6D X-Spam-Summary: 2,0,0,,d41d8cd98f00b204,joe@perches.com,:::::::,RULES_HIT:41:355:379:541:599:800:960:968:973:988:989:1260:1277:1311:1313:1314:1345:1359:1373:1381:1437:1515:1516:1518:1534:1541:1593:1594:1711:1730:1747:1777:1792:2393:2559:2562:2828:3138:3139:3140:3141:3142:3352:3622:3834:3865:3867:3868:3870:4321:5007:7514:10004:10400:10848:11026:11232:11657:11658:11914:12043:12048:12296:12438:12555:12740:12760:12895:13069:13095:13311:13357:13439:14096:14097:14181:14659:14721:21080:21433:21451:21627:30054:30091,0,RBL:none,CacheIP:none,Bayesian:0.5,0.5,0.5,Netcheck:none,DomainCache:0,MSF:not bulk,SPF:,MSBL:0,DNSBL:none,Custom_rules:0:0:0,LFtime:2,LUA_SUMMARY:none X-HE-Tag: pin48_51d7256ed410c X-Filterd-Recvd-Size: 2064 Message-ID: <1507177560.4434.17.camel@perches.com> Subject: Re: [PATCH] Staging: rtl8723bs: Externs should be avoided in .C file From: Joe Perches To: Srinivasan Shanmugam , gregkh@linuxfoundation.org, devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org Date: Wed, 04 Oct 2017 21:26:00 -0700 In-Reply-To: <1507137894-21614-1-git-send-email-srinivasan.rns@gmail.com> References: <1507137894-21614-1-git-send-email-srinivasan.rns@gmail.com> Content-Type: text/plain; charset="ISO-8859-1" X-Mailer: Evolution 3.22.6-1ubuntu1 Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, 2017-10-04 at 19:24 +0200, Srinivasan Shanmugam wrote: > Removed warning from 0001-Staging-rtl8723bs-Externs-should-be-avoided-in-.C-fi.patch file after running checkpatch.pl > > Signed-off-by: Srinivasan Shanmugam > --- > drivers/staging/rtl8723bs/core/rtw_recv.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/drivers/staging/rtl8723bs/core/rtw_recv.c b/drivers/staging/rtl8723bs/core/rtw_recv.c > index c0b501e..6b5e48c 100644 > --- a/drivers/staging/rtl8723bs/core/rtw_recv.c > +++ b/drivers/staging/rtl8723bs/core/rtw_recv.c > @@ -1226,7 +1226,8 @@ sint validate_recv_ctrl_frame(struct adapter *padapter, union recv_frame *precv_ > > union recv_frame *recvframe_chk_defrag(struct adapter *padapter, union recv_frame *precv_frame); > > -static sint validate_recv_mgnt_frame(struct adapter *padapter, union recv_frame *precv_frame) > +static int validate_recv_mgnt_frame(struct adapter *padapter, > + union recv_frame *precv_frame) > { > /* struct mlme_priv *pmlmepriv = &adapter->mlmepriv; */ > This patch does not match the commit message. This patch changes the return from sint to int and does some 80 column wrapping.