From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752539AbdJFRn1 (ORCPT ); Fri, 6 Oct 2017 13:43:27 -0400 Received: from esa6.hgst.iphmx.com ([216.71.154.45]:61257 "EHLO esa6.hgst.iphmx.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751862AbdJFRnZ (ORCPT ); Fri, 6 Oct 2017 13:43:25 -0400 X-IronPort-AV: E=Sophos;i="5.42,484,1500912000"; d="scan'208";a="57093804" From: Bart Van Assche To: "hch@lst.de" CC: "torvalds@linux-foundation.org" , "linux-kernel@vger.kernel.org" , "mst@redhat.com" Subject: Re: [PATCH] linux/types.h: Restore the ability to disable sparse endianness checks Thread-Topic: [PATCH] linux/types.h: Restore the ability to disable sparse endianness checks Thread-Index: AQHTPsqaIyWvaokWn0itcVMSwWfZtg== Date: Fri, 6 Oct 2017 17:43:22 +0000 Message-ID: <1507311801.2602.12.camel@wdc.com> References: <20171006172353.16758-1-bart.vanassche@wdc.com> <20171006173538.GA4106@lst.de> In-Reply-To: <20171006173538.GA4106@lst.de> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: spf=none (sender IP is ) smtp.mailfrom=Bart.VanAssche@wdc.com; x-originating-ip: [63.163.107.100] x-ms-publictraffictype: Email x-microsoft-exchange-diagnostics: 1;CY1PR0401MB1536;20:SLyqnaIIDee+7ui62sJH36TM1Rf6GhDpyXPXRC0U+ubJ4IU+wAccf2CiGidytSDNhm57LeVXJjwjhBkm0vQhhTcSclZ0M9Q97BuhOoFpJh51fcSm/JJsNUov9zpmjjilQDLewIYskcQr7Eig4XSwgEIhCDDwoDMF8EWRq2p5lZA= x-ms-exchange-antispam-srfa-diagnostics: SSOS; x-ms-office365-filtering-correlation-id: e50c1e2b-1efd-44d1-ff6e-08d50ce1bd4f x-ms-office365-filtering-ht: Tenant x-microsoft-antispam: UriScan:;BCL:0;PCL:0;RULEID:(22001)(2017030254152)(48565401081)(2017052603199)(201703131423075)(201703031133081)(201702281549075);SRVR:CY1PR0401MB1536; x-ms-traffictypediagnostic: CY1PR0401MB1536: wdcipoutbound: EOP-TRUE x-exchange-antispam-report-test: UriScan:; x-microsoft-antispam-prvs: x-exchange-antispam-report-cfa-test: BCL:0;PCL:0;RULEID:(100000700101)(100105000095)(100000701101)(100105300095)(100000702101)(100105100095)(6040450)(2401047)(5005006)(8121501046)(93006095)(93001095)(3002001)(100000703101)(100105400095)(10201501046)(6055026)(6041248)(20161123560025)(20161123558100)(20161123562025)(20161123564025)(201703131423075)(201702281528075)(201703061421075)(201703061406153)(20161123555025)(6072148)(201708071742011)(100000704101)(100105200095)(100000705101)(100105500095);SRVR:CY1PR0401MB1536;BCL:0;PCL:0;RULEID:(100000800101)(100110000095)(100000801101)(100110300095)(100000802101)(100110100095)(100000803101)(100110400095)(100000804101)(100110200095)(100000805101)(100110500095);SRVR:CY1PR0401MB1536; x-forefront-prvs: 0452022BE1 x-forefront-antispam-report: SFV:NSPM;SFS:(10019020)(6009001)(376002)(346002)(24454002)(51444003)(189002)(377424004)(199003)(2900100001)(50986999)(6486002)(102836003)(6116002)(229853002)(3846002)(77096006)(105586002)(106356001)(4326008)(5660300001)(36756003)(33646002)(2351001)(5640700003)(54356999)(6512007)(76176999)(6506006)(6436002)(99286003)(6246003)(101416001)(53936002)(305945005)(14454004)(7736002)(478600001)(72206003)(103116003)(316002)(54906003)(189998001)(25786009)(3660700001)(86362001)(8936002)(2906002)(66066001)(3280700002)(68736007)(97736004)(6916009)(1730700003)(2950100002)(8676002)(81166006)(81156014)(2501003);DIR:OUT;SFP:1102;SCL:1;SRVR:CY1PR0401MB1536;H:CY1PR0401MB1536.namprd04.prod.outlook.com;FPR:;SPF:None;PTR:InfoNoRecords;MX:1;A:1;LANG:en; spamdiagnosticoutput: 1:99 spamdiagnosticmetadata: NSPM Content-Type: text/plain; charset="utf-8" Content-ID: <532ACAC24CE7A741982690A187C6DAEF@namprd04.prod.outlook.com> MIME-Version: 1.0 X-OriginatorOrg: wdc.com X-MS-Exchange-CrossTenant-originalarrivaltime: 06 Oct 2017 17:43:22.5479 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: b61c8803-16f3-4c35-9b17-6f65f441df86 X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY1PR0401MB1536 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Transfer-Encoding: 8bit X-MIME-Autoconverted: from base64 to 8bit by nfs id v96HhVqd011444 On Fri, 2017-10-06 at 19:35 +0200, Christoph Hellwig wrote: > On Fri, Oct 06, 2017 at 10:23:53AM -0700, Bart Van Assche wrote: > > The purpose of patch "linux/types.h: enable endian checks for all > > sparse builds" was to encourage driver authors to annotate > > endianness correctly in their drivers. However, since that patch > > went upstream no endianness annotations in drivers have been fixed. > > I think that this shows that the followed approach does not work, > > probably because several driver authors do not use sparse. Restore > > the ability to disable sparse endianness checks such that it > > becomes again easy to review other sparse diagnostics for people > > who want to analyze drivers they are not the author of. > > So how do we get people to do it? Out of the sparse checks endianess > warnings are the most useful, together with __user and __iomem. Hello Christoph, That's an excellent question. Do you think it would help if the zero-day kernel testing infrastructure would check whether kernel patches introduce new sparse complaints and if this is the case post these as a reply to the e-mail with the patch that introduced the new sparse warnings? Bart.