From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753302AbdJGOYS (ORCPT ); Sat, 7 Oct 2017 10:24:18 -0400 Received: from www17.your-server.de ([213.133.104.17]:44240 "EHLO www17.your-server.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752204AbdJGOYO (ORCPT ); Sat, 7 Oct 2017 10:24:14 -0400 Subject: [PATCH] afs: Fix bool initialization/comparison From: Thomas Meyer To: dhowells@redhat.com, linux-afs@lists.infradead.org, linux-kernel@vger.kernel.org Content-Type: text/plain; charset="UTF-8" Mime-Version: 1.0 X-Patch: Cocci Message-ID: <1507383097082-123648613-2-diffsplit-thomas@m3y3r.de> References: <1507383097081-778026979-0-diffsplit-thomas@m3y3r.de> In-Reply-To: <1507383097081-778026979-0-diffsplit-thomas@m3y3r.de> X-Serial-No: 2 Date: Sat, 07 Oct 2017 16:02:21 +0200 X-Mailer: Evolution 3.22.6-1 Content-Transfer-Encoding: 7bit X-Authenticated-Sender: thomas@m3y3r.de Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Bool initializations should use true and false. Bool tests don't need comparisons. Signed-off-by: Thomas Meyer --- diff -u -p a/fs/afs/cache.c b/fs/afs/cache.c --- a/fs/afs/cache.c +++ b/fs/afs/cache.c @@ -195,7 +195,7 @@ enum fscache_checkaux afs_vlocation_cach * VL record from the cache */ if (!vlocation->valid || vlocation->vldb.rtime == cvldb->rtime) { memcpy((uint8_t *)&vlocation->vldb.nservers, buffer, dlen); - vlocation->valid = 1; + vlocation->valid = true; _leave(" = SUCCESS [c->m]"); return FSCACHE_CHECKAUX_OKAY; } diff -u -p a/fs/afs/super.c b/fs/afs/super.c --- a/fs/afs/super.c +++ b/fs/afs/super.c @@ -211,7 +211,7 @@ static int afs_parse_options(struct afs_ break; case afs_opt_rwpath: - params->rwpath = 1; + params->rwpath = true; break; case afs_opt_vol: @@ -219,7 +219,7 @@ static int afs_parse_options(struct afs_ break; case afs_opt_autocell: - params->autocell = 1; + params->autocell = true; break; default: diff -u -p a/fs/afs/vlocation.c b/fs/afs/vlocation.c --- a/fs/afs/vlocation.c +++ b/fs/afs/vlocation.c @@ -154,7 +154,7 @@ out: printk(KERN_NOTICE "kAFS:" " Active volume no longer valid '%s'\n", vl->vldb.name); - vl->valid = 0; + vl->valid = false; ret = -ENOMEDIUM; }