From: Eric Dumazet <eric.dumazet@gmail.com>
To: Alexei Starovoitov <alexei.starovoitov@gmail.com>
Cc: Hannes Frederic Sowa <hannes@stressinduktion.org>,
Cong Wang <xiyou.wangcong@gmail.com>,
netdev@vger.kernel.org, Eric Dumazet <edumazet@google.com>,
Yuchung Cheng <ycheng@google.com>,
Neal Cardwell <ncardwell@google.com>,
Martin KaFai Lau <kafai@fb.com>,
Brendan Gregg <brendan.d.gregg@gmail.com>,
Song Liu <songliubraving@fb.com>
Subject: Re: [Patch net-next] tcp: add a tracepoint for tcp_retransmit_skb()
Date: Wed, 11 Oct 2017 06:31:45 -0700 [thread overview]
Message-ID: <1507728705.31614.24.camel@edumazet-glaptop3.roam.corp.google.com> (raw)
In-Reply-To: <20171011025606.tzts5wgys5hn52p2@ast-mbp>
On Tue, 2017-10-10 at 19:56 -0700, Alexei Starovoitov wrote:
> actually we hit that too for completely different tracing use case.
> Indeed would be good to generate socket cookie unconditionally
> for all sockets. I don't think there is any harm.
>
Simply call sock_gen_cookie() when needed.
If a tracepoint needs the cookie and the cookie was not yet generated,
it will be generated at this point.
next prev parent reply other threads:[~2017-10-11 13:31 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-10-10 5:35 [Patch net-next] tcp: add a tracepoint for tcp_retransmit_skb() Cong Wang
2017-10-10 11:21 ` Eric Dumazet
2017-10-10 17:16 ` Cong Wang
2017-10-10 17:38 ` Alexei Starovoitov
2017-10-10 21:37 ` Cong Wang
2017-10-11 2:53 ` Alexei Starovoitov
2017-10-10 21:58 ` Hannes Frederic Sowa
2017-10-11 2:56 ` Alexei Starovoitov
2017-10-11 13:31 ` Eric Dumazet [this message]
2017-10-11 18:21 ` Alexei Starovoitov
2017-10-11 18:38 ` Eric Dumazet
2017-10-12 9:39 ` Hannes Frederic Sowa
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1507728705.31614.24.camel@edumazet-glaptop3.roam.corp.google.com \
--to=eric.dumazet@gmail.com \
--cc=alexei.starovoitov@gmail.com \
--cc=brendan.d.gregg@gmail.com \
--cc=edumazet@google.com \
--cc=hannes@stressinduktion.org \
--cc=kafai@fb.com \
--cc=ncardwell@google.com \
--cc=netdev@vger.kernel.org \
--cc=songliubraving@fb.com \
--cc=xiyou.wangcong@gmail.com \
--cc=ycheng@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.