From mboxrd@z Thu Jan 1 00:00:00 1970 From: Chris Lew Subject: [PATCH v3 1/5] soc: qcom: smem: Use le32_to_cpu for comparison Date: Wed, 11 Oct 2017 14:29:06 -0700 Message-ID: <1507757350-10508-2-git-send-email-clew@quicinc.com> References: <1507757350-10508-1-git-send-email-clew@quicinc.com> Return-path: Received: from smtp.codeaurora.org ([198.145.29.96]:37416 "EHLO smtp.codeaurora.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750912AbdJKV3l (ORCPT ); Wed, 11 Oct 2017 17:29:41 -0400 In-Reply-To: <1507757350-10508-1-git-send-email-clew@quicinc.com> Sender: linux-arm-msm-owner@vger.kernel.org List-Id: linux-arm-msm@vger.kernel.org To: bjorn.andersson@linaro.org, andy.gross@linaro.org, david.brown@linaro.org Cc: aneela@codeaurora.org, linux-arm-msm@vger.kernel.org, linux-soc@vger.kernel.org, linux-kernel@vger.kernel.org, clew@codeaurora.org From: Chris Lew Endianness can vary in the system, add le32_to_cpu when comparing partition sizes from smem. Signed-off-by: Chris Lew --- Changes since v1: - New change Changes since v2: - Reduce subject to 50 chars and wrap summary to 72 chars drivers/soc/qcom/smem.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/soc/qcom/smem.c b/drivers/soc/qcom/smem.c index c28275be0038..db04c45d4132 100644 --- a/drivers/soc/qcom/smem.c +++ b/drivers/soc/qcom/smem.c @@ -698,7 +698,7 @@ static int qcom_smem_enumerate_partitions(struct qcom_smem *smem, return -EINVAL; } - if (header->size != entry->size) { + if (le32_to_cpu(header->size) != le32_to_cpu(entry->size)) { dev_err(smem->dev, "Partition %d has invalid size\n", i); return -EINVAL; -- The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum, a Linux Foundation Collaborative Project