From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jianfeng Tan Subject: [PATCH v7 1/4] cryptodev: remove crypto vdev init API Date: Fri, 13 Oct 2017 11:51:58 +0000 Message-ID: <1507895521-48299-2-git-send-email-jianfeng.tan@intel.com> References: <1507519229-80692-1-git-send-email-jianfeng.tan@intel.com> <1507895521-48299-1-git-send-email-jianfeng.tan@intel.com> Cc: jblunck@infradead.org, bruce.richardson@intel.com, konstantin.ananyev@intel.com, pablo.de.lara.guarch@intel.com, thomas@monjalon.net, yliu@fridaylinux.org, maxime.coquelin@redhat.com, mtetsuyah@gmail.com, ferruh.yigit@intel.com, Jianfeng Tan To: dev@dpdk.org Return-path: Received: from mga07.intel.com (mga07.intel.com [134.134.136.100]) by dpdk.org (Postfix) with ESMTP id EB9D51B653 for ; Fri, 13 Oct 2017 13:50:35 +0200 (CEST) In-Reply-To: <1507895521-48299-1-git-send-email-jianfeng.tan@intel.com> List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Remove rte_cryptodev_create_vdev() for duplication. Signed-off-by: Jianfeng Tan Acked-by: Pablo de Lara --- doc/guides/rel_notes/deprecation.rst | 5 ----- doc/guides/rel_notes/release_17_11.rst | 2 ++ lib/librte_cryptodev/Makefile | 2 +- lib/librte_cryptodev/rte_cryptodev.c | 6 ------ lib/librte_cryptodev/rte_cryptodev.h | 17 ----------------- lib/librte_cryptodev/rte_cryptodev_version.map | 1 - 6 files changed, 3 insertions(+), 30 deletions(-) diff --git a/doc/guides/rel_notes/deprecation.rst b/doc/guides/rel_notes/deprecation.rst index f4269f0..85a9287 100644 --- a/doc/guides/rel_notes/deprecation.rst +++ b/doc/guides/rel_notes/deprecation.rst @@ -78,11 +78,6 @@ Deprecation Notices ``rte_cryptodev`` respectively to support security protocol offloaded operations. -* cryptodev: the following function is deprecated starting from 17.08 and will - be removed in 17.11: - - - ``rte_cryptodev_create_vdev`` - * cryptodev: the following function will be static in 17.11 and included by all crypto drivers, therefore, will not be public: diff --git a/doc/guides/rel_notes/release_17_11.rst b/doc/guides/rel_notes/release_17_11.rst index 6a75ae0..6b405af 100644 --- a/doc/guides/rel_notes/release_17_11.rst +++ b/doc/guides/rel_notes/release_17_11.rst @@ -183,6 +183,8 @@ API Changes * ``rte_mem_phy2mch`` was used in Xen dom0 to obtain the physical address; remove this API as Xen dom0 support was removed. +* ``rte_cryptodev_create_vdev`` was removed to avoid the dependency on vdev + in librte_cryptodev; instead, users can call rte_vdev_init() directly. ABI Changes ----------- diff --git a/lib/librte_cryptodev/Makefile b/lib/librte_cryptodev/Makefile index 59d9a4e..47f466d 100644 --- a/lib/librte_cryptodev/Makefile +++ b/lib/librte_cryptodev/Makefile @@ -34,7 +34,7 @@ include $(RTE_SDK)/mk/rte.vars.mk LIB = librte_cryptodev.a # library version -LIBABIVER := 3 +LIBABIVER := 4 # build flags CFLAGS += -O3 diff --git a/lib/librte_cryptodev/rte_cryptodev.c b/lib/librte_cryptodev/rte_cryptodev.c index 5e8f7f4..f2c55cc 100644 --- a/lib/librte_cryptodev/rte_cryptodev.c +++ b/lib/librte_cryptodev/rte_cryptodev.c @@ -377,12 +377,6 @@ rte_cryptodev_get_feature_name(uint64_t flag) } } -int -rte_cryptodev_create_vdev(const char *name, const char *args) -{ - return rte_vdev_init(name, args); -} - struct rte_cryptodev * rte_cryptodev_pmd_get_dev(uint8_t dev_id) { diff --git a/lib/librte_cryptodev/rte_cryptodev.h b/lib/librte_cryptodev/rte_cryptodev.h index ad97ff9..c5d6939 100644 --- a/lib/librte_cryptodev/rte_cryptodev.h +++ b/lib/librte_cryptodev/rte_cryptodev.h @@ -433,23 +433,6 @@ struct rte_cryptodev_stats { /**< Max length of name of crypto PMD */ /** - * @deprecated - * - * Create a virtual crypto device - * - * @param name Cryptodev PMD name of device to be created. - * @param args Options arguments for device. - * - * @return - * - On successful creation of the cryptodev the device index is returned, - * which will be between 0 and rte_cryptodev_count(). - * - In the case of a failure, returns -1. - */ -__rte_deprecated -extern int -rte_cryptodev_create_vdev(const char *name, const char *args); - -/** * Get the device identifier for the named crypto device. * * @param name device name to select the device structure. diff --git a/lib/librte_cryptodev/rte_cryptodev_version.map b/lib/librte_cryptodev/rte_cryptodev_version.map index abdbbda..b07f4ca 100644 --- a/lib/librte_cryptodev/rte_cryptodev_version.map +++ b/lib/librte_cryptodev/rte_cryptodev_version.map @@ -7,7 +7,6 @@ DPDK_16.04 { rte_cryptodev_close; rte_cryptodev_count; rte_cryptodev_configure; - rte_cryptodev_create_vdev; rte_cryptodev_get_dev_id; rte_cryptodev_get_feature_name; rte_cryptodev_info_get; -- 2.7.4