From: David Howells <dhowells@redhat.com>
To: YueHaibing <yuehaibing@huawei.com>
Cc: dhowells@redhat.com, davem@davemloft.net,
linux-kernel@vger.kernel.org, netdev@vger.kernel.org,
linux-afs@lists.infradead.org
Subject: Re: [PATCH net-next] rxrpc: remove redundant variables 'xcall','sp' and 'did_discard'
Date: Wed, 01 Aug 2018 09:28:14 +0100 [thread overview]
Message-ID: <15081.1533112094@warthog.procyon.org.uk> (raw)
In-Reply-To: <20180801073251.9808-1-yuehaibing@huawei.com>
YueHaibing <yuehaibing@huawei.com> wrote:
> while (*pp) {
> parent = *pp;
> - xcall = rb_entry(parent, struct rxrpc_call, sock_node);
> if (user_call_ID < call->user_call_ID)
> pp = &(*pp)->rb_left;
> else if (user_call_ID > call->user_call_ID)
No, this is an actual bug. The if-conditions should be using xcall-> not
call->.
> - sp = rxrpc_skb(skb);
Yeah, that's fine.
> - did_discard = true;
Hmmm... It looks like I intended something with this, but I don't remember
what now. I think it can be removed.
David
next prev parent reply other threads:[~2018-08-01 8:28 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-08-01 7:32 [PATCH net-next] rxrpc: remove redundant variables 'xcall','sp' and 'did_discard' YueHaibing
2018-08-01 8:28 ` David Howells [this message]
2018-08-01 9:19 ` YueHaibing
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=15081.1533112094@warthog.procyon.org.uk \
--to=dhowells@redhat.com \
--cc=davem@davemloft.net \
--cc=linux-afs@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=yuehaibing@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.