All of lore.kernel.org
 help / color / mirror / Atom feed
From: Patrick Delaunay <patrick.delaunay@st.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH v2 4/5] test/py: gpt: test start LBA for sub-command rename and swap
Date: Mon, 16 Oct 2017 18:17:34 +0200	[thread overview]
Message-ID: <1508170655-17707-5-git-send-email-patrick.delaunay@st.com> (raw)
In-Reply-To: <1508170655-17707-1-git-send-email-patrick.delaunay@st.com>

Add test of first and last LBA in gpt for rename and swap.
Only the name is expected to change, so test 3 columns
for part command
1: first LBA (start)
2: last LBA (end)
3: partition name

Signed-off-by: Patrick Delaunay <patrick.delaunay@st.com>
---
WARNING: the last LBA are invalid after rename

before rename
0x00000800  0x00000a00      ""
0x00001000  0x00001200      ""

after rename, the last LBA change
=> 7ff for first = invalid (<start)
=> 17ff for second (size increase)

0x00000800	0x000007ff "first"
0x00001000	0x000017ff	"second"

the issue is corrected in next commit of the patchset


Changes in v2: None

 test/py/tests/test_gpt.py | 12 ++++++++----
 1 file changed, 8 insertions(+), 4 deletions(-)

diff --git a/test/py/tests/test_gpt.py b/test/py/tests/test_gpt.py
index 8d5980c..2554f1f 100644
--- a/test/py/tests/test_gpt.py
+++ b/test/py/tests/test_gpt.py
@@ -117,6 +117,7 @@ def test_gpt_save_guid(state_disk_image, u_boot_console):
 @pytest.mark.boardspec('sandbox')
 @pytest.mark.buildconfigspec('cmd_gpt')
 @pytest.mark.buildconfigspec('cmd_gpt_rename')
+ at pytest.mark.buildconfigspec('cmd_part')
 @pytest.mark.requiredtool('sgdisk')
 def test_gpt_rename_partition(state_disk_image, u_boot_console):
     """Test the gpt rename command to write partition names."""
@@ -128,6 +129,9 @@ def test_gpt_rename_partition(state_disk_image, u_boot_console):
     u_boot_console.run_command('gpt rename host 0 2 second')
     output = u_boot_console.run_command('gpt read host 0')
     assert 'name second' in output
+    output = u_boot_console.run_command('part list host 0')
+    assert '0x00000800	0x000007ff	"first"' in output
+    assert '0x00001000	0x000017ff	"second"' in output
 
 @pytest.mark.boardspec('sandbox')
 @pytest.mark.buildconfigspec('cmd_gpt')
@@ -139,12 +143,12 @@ def test_gpt_swap_partitions(state_disk_image, u_boot_console):
 
     u_boot_console.run_command('host bind 0 ' + state_disk_image.path)
     output = u_boot_console.run_command('part list host 0')
-    assert '0x000007ff	"first"' in output
-    assert '0x000017ff	"second"' in output
+    assert '0x00000800	0x000007ff	"first"' in output
+    assert '0x00001000	0x000017ff	"second"' in output
     u_boot_console.run_command('gpt swap host 0 first second')
     output = u_boot_console.run_command('part list host 0')
-    assert '0x000007ff	"second"' in output
-    assert '0x000017ff	"first"' in output
+    assert '0x00000800	0x000007ff	"second"' in output
+    assert '0x00001000	0x000017ff	"first"' in output
 
 @pytest.mark.boardspec('sandbox')
 @pytest.mark.buildconfigspec('cmd_gpt')
-- 
2.7.4

  parent reply	other threads:[~2017-10-16 16:17 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-10-16 16:17 [U-Boot] [PATCH v2 0/5] solve issues in gpt management Patrick Delaunay
2017-10-16 16:17 ` [U-Boot] [PATCH v2 1/5] test/py: gpt: copy persistent file Patrick Delaunay
2017-10-16 16:47   ` Stephen Warren
2017-10-16 16:17 ` [U-Boot] [PATCH v2 2/5] test/py: gpt: add test for sub-command read/verify/write Patrick Delaunay
2017-10-16 16:56   ` Stephen Warren
2017-10-16 16:17 ` [U-Boot] [PATCH v2 3/5] disk: efi: correct the overlap check on GPT header and PTE Patrick Delaunay
2017-10-22 14:34   ` Simon Glass
2017-10-16 16:17 ` Patrick Delaunay [this message]
2017-10-16 17:00   ` [U-Boot] [PATCH v2 4/5] test/py: gpt: test start LBA for sub-command rename and swap Stephen Warren
2017-10-16 16:17 ` [U-Boot] [PATCH v2 5/5] cmd: gpt: solve issue for swap Patrick Delaunay
2017-10-22 14:34   ` Simon Glass

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1508170655-17707-5-git-send-email-patrick.delaunay@st.com \
    --to=patrick.delaunay@st.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.