From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756052AbdJPRgi (ORCPT ); Mon, 16 Oct 2017 13:36:38 -0400 Received: from esa2.hgst.iphmx.com ([68.232.143.124]:36146 "EHLO esa2.hgst.iphmx.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753865AbdJPRgg (ORCPT ); Mon, 16 Oct 2017 13:36:36 -0400 X-IronPort-AV: E=Sophos;i="5.43,387,1503331200"; d="scan'208";a="154337505" From: Bart Van Assche To: "mst@redhat.com" CC: "hch@lst.de" , "linux-kernel@vger.kernel.org" , "jejb@linux.vnet.ibm.com" , "linux-scsi@vger.kernel.org" , "qla2xxx-upstream@qlogic.com" , "martin.petersen@oracle.com" , "torvalds@linux-foundation.org" Subject: Re: [PATCH] linux/types.h: Restore the ability to disable sparse endianness checks Thread-Topic: [PATCH] linux/types.h: Restore the ability to disable sparse endianness checks Thread-Index: AQHTPsfpNidr/j8ehUyvQHGzmN9zsKLbhcaAgAAdXoCAACtPAIABgFIAgAk6vQCAAAZbgIAAGTwAgAACgICAABSogIAADMkA Date: Mon, 16 Oct 2017 17:36:31 +0000 Message-ID: <1508175390.2493.24.camel@wdc.com> References: <20171006172353.16758-1-bart.vanassche@wdc.com> <20171009162008-mutt-send-email-mst@kernel.org> <1507561661.2674.3.camel@wdc.com> <20171009204139-mutt-send-email-mst@kernel.org> <1507653494.2815.27.camel@wdc.com> <20171016160316-mutt-send-email-mst@kernel.org> <1508162253.2728.1.camel@wdc.com> <20171016181159-mutt-send-email-mst@kernel.org> <1508168209.2493.13.camel@wdc.com> <20171016193921-mutt-send-email-mst@kernel.org> In-Reply-To: <20171016193921-mutt-send-email-mst@kernel.org> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: spf=none (sender IP is ) smtp.mailfrom=Bart.VanAssche@wdc.com; x-originating-ip: [63.163.107.100] x-ms-publictraffictype: Email x-microsoft-exchange-diagnostics: 1;CY1PR0401MB1535;20:M0ROK6CUY38vj0iuRmtpIooNw6P1qIUJlRhOz/uvMH8KzVzZ1lGSQqaFEjZ4OYP5tUZp5a7aCVh1rFUoSYdk6AK/c3yaQbVhptSzfT9KaJzqlJMTZ+owBMsihNCpNOFoLjE72XeZOU9wbmM/UzO1Z6COl+2DXkcsDxudHBReeGM= x-ms-exchange-antispam-srfa-diagnostics: SSOS; x-ms-office365-filtering-correlation-id: c91945bd-a1c8-493e-18a7-08d514bc70b8 x-ms-office365-filtering-ht: Tenant x-microsoft-antispam: UriScan:;BCL:0;PCL:0;RULEID:(22001)(2017030254152)(48565401081)(2017052603199)(201703131423075)(201703031133081)(201702281549075);SRVR:CY1PR0401MB1535; x-ms-traffictypediagnostic: CY1PR0401MB1535: wdcipoutbound: EOP-TRUE x-exchange-antispam-report-test: UriScan:; x-microsoft-antispam-prvs: x-exchange-antispam-report-cfa-test: BCL:0;PCL:0;RULEID:(100000700101)(100105000095)(100000701101)(100105300095)(100000702101)(100105100095)(6040450)(2401047)(5005006)(8121501046)(93006095)(93001095)(3002001)(100000703101)(100105400095)(10201501046)(6055026)(6041248)(201703131423075)(201702281528075)(201703061421075)(201703061406153)(20161123560025)(20161123562025)(20161123555025)(20161123558100)(20161123564025)(6072148)(201708071742011)(100000704101)(100105200095)(100000705101)(100105500095);SRVR:CY1PR0401MB1535;BCL:0;PCL:0;RULEID:(100000800101)(100110000095)(100000801101)(100110300095)(100000802101)(100110100095)(100000803101)(100110400095)(100000804101)(100110200095)(100000805101)(100110500095);SRVR:CY1PR0401MB1535; x-forefront-prvs: 0462918D61 x-forefront-antispam-report: SFV:NSPM;SFS:(10019020)(979002)(6009001)(39860400002)(376002)(346002)(377424004)(189002)(24454002)(199003)(1730700003)(2351001)(53936002)(2501003)(8676002)(72206003)(99286003)(81166006)(6512007)(2906002)(305945005)(5640700003)(101416001)(2900100001)(4001150100001)(6916009)(14454004)(93886005)(6246003)(33646002)(54906003)(86362001)(316002)(81156014)(189998001)(36756003)(25786009)(3846002)(6486002)(229853002)(5660300001)(6116002)(102836003)(66066001)(77096006)(478600001)(3280700002)(105586002)(8936002)(106356001)(68736007)(2950100002)(50986999)(3660700001)(4326008)(97736004)(6436002)(7736002)(54356999)(6506006)(103116003)(76176999)(969003)(989001)(999001)(1009001)(1019001);DIR:OUT;SFP:1102;SCL:1;SRVR:CY1PR0401MB1535;H:CY1PR0401MB1536.namprd04.prod.outlook.com;FPR:;SPF:None;PTR:InfoNoRecords;MX:1;A:1;LANG:en; spamdiagnosticoutput: 1:99 spamdiagnosticmetadata: NSPM Content-Type: text/plain; charset="utf-8" Content-ID: <8F138DC060118344BF7A7A28DFDF5018@namprd04.prod.outlook.com> MIME-Version: 1.0 X-OriginatorOrg: wdc.com X-MS-Exchange-CrossTenant-originalarrivaltime: 16 Oct 2017 17:36:31.8282 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: b61c8803-16f3-4c35-9b17-6f65f441df86 X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY1PR0401MB1535 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Transfer-Encoding: 8bit X-MIME-Autoconverted: from base64 to 8bit by nfs id v9GHaofI002270 On Mon, 2017-10-16 at 19:50 +0300, Michael S. Tsirkin wrote: > Right but qla_nvme also triggers these warnings. That's the problem with > disabling them tree-wide. To me it looks like the time we are spending > arguing about work-arounds would be better spent just fixing the > majority of the code. If a couple of places aren't clean and > need more thought, that's not a big deal. Making the drivers that are not endianness clean mostly clean is risky. Such changes would most likely be done by someone who is not the driver author. Anyone who tries to fix endianness annotations without having a firmware manual available risks to introduce incorrect endianness annotations. Such annotations can make code more confusing instead of less. Bart.