From: Luca Boccassi <bluca@debian.org>
To: Bruce Richardson <bruce.richardson@intel.com>, dev@dpdk.org
Subject: Re: [PATCH 1/8] build: add maths library to libs in pkg-config file
Date: Tue, 17 Oct 2017 19:11:38 +0100 [thread overview]
Message-ID: <1508263898.32437.1.camel@debian.org> (raw)
In-Reply-To: <20171017161220.59941-2-bruce.richardson@intel.com>
On Tue, 2017-10-17 at 17:12 +0100, Bruce Richardson wrote:
> Since a number of libraries depend on the maths lib, as well as
> adding it
> to the project args, we also need to add it to the pkgconfig file
> args.
>
> Signed-off-by: Bruce Richardson <bruce.richardson@intel.com>
> ---
> config/meson.build | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/config/meson.build b/config/meson.build
> index db68a08d4..542fea4de 100644
> --- a/config/meson.build
> +++ b/config/meson.build
> @@ -35,6 +35,7 @@ dpdk_conf.set('RTE_MACHINE', machine)
> add_project_arguments('-march=@0@'.format(machine), language: 'c')
> # some libs depend on maths lib
> add_project_link_arguments('-lm', language: 'c')
> +dpdk_extra_ldflags += '-lm'
>
> # add -include rte_config to cflags
> add_project_arguments('-include', 'rte_config.h', language: 'c')
This is for static builds, right? If so it should go into the
Libs.private section of the .pc file, so that it's only used when
calling pkg-config --static --libs
--
Kind regards,
Luca Boccassi
next prev parent reply other threads:[~2017-10-17 18:11 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-10-17 16:12 [PATCH 0/8] Support sample applications with new build system Bruce Richardson
2017-10-17 16:12 ` [PATCH 1/8] build: add maths library to libs in pkg-config file Bruce Richardson
2017-10-17 18:11 ` Luca Boccassi [this message]
2017-10-17 18:17 ` Luca Boccassi
2017-10-18 9:35 ` Bruce Richardson
2017-10-18 9:51 ` Bruce Richardson
2017-10-18 10:14 ` Luca Boccassi
2017-10-18 12:24 ` Bruce Richardson
2017-10-18 14:20 ` Bruce Richardson
2017-10-18 15:28 ` Luca Boccassi
2017-10-18 19:13 ` Aaron Conole
2017-10-18 19:21 ` Thomas Monjalon
2017-10-19 8:38 ` Bruce Richardson
2017-10-18 11:20 ` Thomas Monjalon
2017-10-18 12:28 ` Bruce Richardson
2017-10-17 16:12 ` [PATCH 2/8] build: add detection and use of libnuma Bruce Richardson
2017-10-17 16:12 ` [PATCH 3/8] lpm: install vector header files Bruce Richardson
2017-10-17 16:12 ` [PATCH 4/8] event: add skeleton and sw eventdevs to meson build Bruce Richardson
2017-10-17 16:12 ` [PATCH 5/8] net/bonding: add " Bruce Richardson
2017-10-17 16:12 ` [PATCH 6/8] examples: allow building examples as part of a " Bruce Richardson
2017-10-17 16:12 ` [PATCH 7/8] examples: put app name and sources at top of makefiles Bruce Richardson
2017-10-17 16:12 ` [PATCH 8/8] examples: use pkg-config info when building examples Bruce Richardson
2017-10-18 17:11 ` [PATCH 0/8] Support sample applications with new build system Luca Boccassi
2017-10-19 8:39 ` Bruce Richardson
2017-10-23 10:43 ` Bruce Richardson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1508263898.32437.1.camel@debian.org \
--to=bluca@debian.org \
--cc=bruce.richardson@intel.com \
--cc=dev@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.