From mboxrd@z Thu Jan 1 00:00:00 1970 From: Mika Kahola Subject: Re: [PATCH i-g-t v2 04/14] lib/igt_kms: Allow setting any plane property through the universal path Date: Thu, 19 Oct 2017 14:04:39 +0300 Message-ID: <1508411079.3274.126.camel@intel.com> References: <20171012115435.18880-1-maarten.lankhorst@linux.intel.com> <20171012115435.18880-5-maarten.lankhorst@linux.intel.com> Reply-To: mika.kahola@intel.com Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) by gabe.freedesktop.org (Postfix) with ESMTPS id 299AF6EA67 for ; Thu, 19 Oct 2017 11:03:02 +0000 (UTC) In-Reply-To: <20171012115435.18880-5-maarten.lankhorst@linux.intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Maarten Lankhorst , intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org UmV2aWV3ZWQtYnk6IE1pa2EgS2Fob2xhIDxtaWthLmthaG9sYUBpbnRlbC5jb20+CgpPbiBUaHUs IDIwMTctMTAtMTIgYXQgMTM6NTQgKzAyMDAsIE1hYXJ0ZW4gTGFua2hvcnN0IHdyb3RlOgo+IEJs YWNrbGlzdCBzb21lIGV4cGxpY2l0IGF0b21pYyBwcm9wZXJ0aWVzLiBXZSBjb3VsZCB0aGVvcmV0 aWNhbGx5IHNldAo+IHRoZW0gYnV0IHRoYXQncyBub3Qgd2hhdCB0aGUgbGVnYWN5IHBhdGggaXMg Zm9yLiA6KQo+IAo+IFdoZW4gYWRkaW5nIG5ldyBwcm9wZXJ0aWVzLCB0aGlzIG1lYW5zIHdlIGNv dWxkIHRlc3QgdGhvc2UgdGhyb3VnaAo+IHRoZSBsZWdhY3kgY29tbWl0Lgo+IAo+IFNpZ25lZC1v ZmYtYnk6IE1hYXJ0ZW4gTGFua2hvcnN0IDxtYWFydGVuLmxhbmtob3JzdEBsaW51eC5pbnRlbC5j b20+Cj4gLS0tCj4gwqBsaWIvaWd0X2ttcy5jIHwgMzkgKysrKysrKysrKysrKysrKysrKysrKysr KysrKysrKysrLS0tLS0tCj4gwqAxIGZpbGUgY2hhbmdlZCwgMzMgaW5zZXJ0aW9ucygrKSwgNiBk ZWxldGlvbnMoLSkKPiAKPiBkaWZmIC0tZ2l0IGEvbGliL2lndF9rbXMuYyBiL2xpYi9pZ3Rfa21z LmMKPiBpbmRleCAwMmRlMzliOGZjN2YuLmJlODk2MzI1NDdlNSAxMDA2NDQKPiAtLS0gYS9saWIv aWd0X2ttcy5jCj4gKysrIGIvbGliL2lndF9rbXMuYwo+IEBAIC0yMDk3LDcgKzIwOTcsMjIgQEAg aWd0X2F0b21pY19wcmVwYXJlX3BsYW5lX2NvbW1pdChpZ3RfcGxhbmVfdAo+ICpwbGFuZSwgaWd0 X3BpcGVfdCAqcGlwZSwKPiDCoAl9Cj4gwqB9Cj4gwqAKPiAtCj4gKy8qCj4gKyAqIFByb3BlcnRp ZXMgdGhhdCBjYW4gYmUgY2hhbmdlZCB0aHJvdWdoIGxlZ2FjeSBTZXRQcm9wZXJ0eToKPiArICog LSBPYnZpb3VzbHkgbm90IHRoZSBYWVdIIFNSQy9DUlRDIGNvb3JkaW5hdGVzLgo+ICsgKiAtIE5v dCBDUlRDX0lEIG9yIEZFTkNFX0lELCBkb25lIHRocm91Z2ggU2V0UGxhbmUuCj4gKyAqIC0gQ2Fu J3Qgc2V0IElOX0ZFTkNFX0ZELCB0aGF0IHdvdWxkIGJlIHNpbGx5Lgo+ICsgKgo+ICsgKiBUaGVv cmV0aWNhbGx5IHRoZSBhYm92ZSBjYW4gYWxsIGJlIHNldCB0aHJvdWdoIHRoZSBsZWdhY3kgcGF0 aAo+ICsgKiB3aXRoIHRoZSBhdG9taWMgY2FwIHNldCwgYnV0IHRoYXQncyBub3QgaG93IG91ciBs ZWdhY3kgcGxhbmUKPiArICogY29tbWl0IGJlaGF2ZXMsIHNvIGJsYWNrbGlzdCBpdCBieSBkZWZh dWx0Lgo+ICsgKi8KPiArI2RlZmluZSBMRUdBQ1lfUExBTkVfQ09NTUlUX01BU0sgXAo+ICsJKCgo MVVMTCA8PCBJR1RfTlVNX1BMQU5FX1BST1BTKSAtIDEpICYgXAo+ICsJwqB+KElHVF9QTEFORV9D T09SRF9DSEFOR0VEX01BU0sgfCBcCj4gKwnCoMKgwqAoMVVMTCA8PCBJR1RfUExBTkVfRkJfSUQp IHwgXAo+ICsJwqDCoMKgKDFVTEwgPDwgSUdUX1BMQU5FX0NSVENfSUQpIHwgXAo+ICsJwqDCoMKg KDFVTEwgPDwgSUdUX1BMQU5FX0lOX0ZFTkNFX0ZEKSkpCj4gwqAKPiDCoC8qCj4gwqAgKiBDb21t aXQgcG9zaXRpb24gYW5kIGZiIGNoYW5nZXMgdG8gYSBEUk0gcGxhbmUgdmlhIHRoZSBTZXRQbGFu ZQo+IGlvY3RsOyBpZiB0aGUKPiBAQCAtMjExMSw3ICsyMTI2LDcgQEAgc3RhdGljIGludCBpZ3Rf ZHJtX3BsYW5lX2NvbW1pdChpZ3RfcGxhbmVfdAo+ICpwbGFuZSwKPiDCoHsKPiDCoAlpZ3RfZGlz cGxheV90ICpkaXNwbGF5ID0gcGlwZS0+ZGlzcGxheTsKPiDCoAl1aW50MzJfdCBmYl9pZCwgY3J0 Y19pZDsKPiAtCWludCByZXQ7Cj4gKwlpbnQgcmV0LCBpOwo+IMKgCXVpbnQzMl90IHNyY194Owo+ IMKgCXVpbnQzMl90IHNyY195Owo+IMKgCXVpbnQzMl90IHNyY193Owo+IEBAIC0yMTIwLDYgKzIx MzUsNyBAQCBzdGF0aWMgaW50IGlndF9kcm1fcGxhbmVfY29tbWl0KGlndF9wbGFuZV90Cj4gKnBs YW5lLAo+IMKgCWludDMyX3QgY3J0Y195Owo+IMKgCXVpbnQzMl90IGNydGNfdzsKPiDCoAl1aW50 MzJfdCBjcnRjX2g7Cj4gKwl1aW50NjRfdCBjaGFuZ2VkX21hc2s7Cj4gwqAJYm9vbCBzZXRwbGFu ZSA9Cj4gwqAJCWlndF9wbGFuZV9pc19wcm9wX2NoYW5nZWQocGxhbmUsIElHVF9QTEFORV9GQl9J RCkgfHwKPiDCoAkJcGxhbmUtPmNoYW5nZWQgJiBJR1RfUExBTkVfQ09PUkRfQ0hBTkdFRF9NQVNL Owo+IEBAIC0yMTg0LDEwICsyMjAwLDIxIEBAIHN0YXRpYyBpbnQgaWd0X2RybV9wbGFuZV9jb21t aXQoaWd0X3BsYW5lX3QKPiAqcGxhbmUsCj4gwqAJCUNIRUNLX1JFVFVSTihyZXQsIGZhaWxfb25f ZXJyb3IpOwo+IMKgCX0KPiDCoAo+IC0JaWYgKGlndF9wbGFuZV9pc19wcm9wX2NoYW5nZWQocGxh bmUsIElHVF9QTEFORV9ST1RBVElPTikpIHsKPiArCWNoYW5nZWRfbWFzayA9IHBsYW5lLT5jaGFu Z2VkICYgTEVHQUNZX1BMQU5FX0NPTU1JVF9NQVNLOwo+ICsKPiArCWZvciAoaSA9IDA7IGkgPCBJ R1RfTlVNX1BMQU5FX1BST1BTOyBpKyspIHsKPiArCQlpZiAoIShjaGFuZ2VkX21hc2sgJiAoMSA8 PCBpKSkpCj4gKwkJCWNvbnRpbnVlOwo+ICsKPiArCQlMT0coZGlzcGxheSwgIlNldFByb3AgcGxh bmUgJXMuJWQgXCIlc1wiIHRvCj4gMHglIlBSSXg2NCIvJSJQUklpNjQiXG4iLAo+ICsJCQlrbXN0 ZXN0X3BpcGVfbmFtZShwaXBlLT5waXBlKSwgcGxhbmUtPmluZGV4LCAKPiBpZ3RfcGxhbmVfcHJv cF9uYW1lc1tpXSwKPiArCQkJcGxhbmUtPnZhbHVlc1tpXSwgcGxhbmUtPnZhbHVlc1tpXSk7Cj4g Kwo+ICsJCWlndF9hc3NlcnQocGxhbmUtPnByb3BzW2ldKTsKPiArCj4gwqAJCXJldCA9IGlndF9w bGFuZV9zZXRfcHJvcGVydHkocGxhbmUsCj4gLQkJCQkJwqDCoMKgwqDCoHBsYW5lLQo+ID5wcm9w c1tJR1RfUExBTkVfUk9UQVRJT05dLAo+IC0JCQkJCcKgwqDCoMKgwqBwbGFuZS0KPiA+dmFsdWVz W0lHVF9QTEFORV9ST1RBVElPTl0pOwo+ICsJCQkJCcKgwqDCoMKgwqBwbGFuZS0+cHJvcHNbaV0s Cj4gKwkJCQkJwqDCoMKgwqDCoHBsYW5lLT52YWx1ZXNbaV0pOwo+IMKgCj4gwqAJCUNIRUNLX1JF VFVSTihyZXQsIGZhaWxfb25fZXJyb3IpOwo+IMKgCX0KPiBAQCAtMjU1NSw3ICsyNTgyLDcgQEAg ZGlzcGxheV9jb21taXRfY2hhbmdlZChpZ3RfZGlzcGxheV90ICpkaXNwbGF5LAo+IGVudW0gaWd0 X2NvbW1pdF9zdHlsZSBzKQo+IMKgCQkJCWlmIChzICE9IENPTU1JVF9MRUdBQ1kgfHwKPiDCoAkJ CQnCoMKgwqDCoCEocGxhbmUtPnR5cGUgPT0KPiBEUk1fUExBTkVfVFlQRV9QUklNQVJZIHx8Cj4g wqAJCQkJwqDCoMKgwqDCoMKgcGxhbmUtPnR5cGUgPT0KPiBEUk1fUExBTkVfVFlQRV9DVVJTT1Ip KQo+IC0JCQkJCWlndF9wbGFuZV9jbGVhcl9wcm9wX2NoYW5nZWQKPiAocGxhbmUsIElHVF9QTEFO RV9ST1RBVElPTik7Cj4gKwkJCQkJcGxhbmUtPmNoYW5nZWQgJj0KPiB+TEVHQUNZX1BMQU5FX0NP TU1JVF9NQVNLOwo+IMKgCQkJfQo+IMKgCQl9Cj4gwqAJfQotLSAKTWlrYSBLYWhvbGEgLSBJbnRl bCBPVEMKCl9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fCklu dGVsLWdmeCBtYWlsaW5nIGxpc3QKSW50ZWwtZ2Z4QGxpc3RzLmZyZWVkZXNrdG9wLm9yZwpodHRw czovL2xpc3RzLmZyZWVkZXNrdG9wLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2ludGVsLWdmeAo=