From mboxrd@z Thu Jan 1 00:00:00 1970 From: Mika Kahola Subject: Re: [PATCH i-g-t v2 09/14] lib/igt_kms: Add igt_$obj_get_prop functions Date: Thu, 19 Oct 2017 15:58:39 +0300 Message-ID: <1508417919.3274.132.camel@intel.com> References: <20171012115435.18880-1-maarten.lankhorst@linux.intel.com> <20171012115435.18880-10-maarten.lankhorst@linux.intel.com> Reply-To: mika.kahola@intel.com Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) by gabe.freedesktop.org (Postfix) with ESMTPS id C5F846EA7A for ; Thu, 19 Oct 2017 12:56:31 +0000 (UTC) In-Reply-To: <20171012115435.18880-10-maarten.lankhorst@linux.intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Maarten Lankhorst , intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org UmV2aWV3ZWQtYnk6IE1pa2EgS2Fob2xhIDxtaWthLmthaG9sYUBpbnRlbC5jb20+CgpPbiBUaHUs IDIwMTctMTAtMTIgYXQgMTM6NTQgKzAyMDAsIE1hYXJ0ZW4gTGFua2hvcnN0IHdyb3RlOgo+IFNv bWUgdGVzdHMgbmVlZCB0byBnZXQgdGhlIGN1cnJlbnQga2VybmVsIHZhbHVlIGZvciBwcm9wZXJ0 aWVzCj4gYXMgcGFydCBvZiB0aGUgdGVzdC4gQWRkIGdldF9wcm9wIGZ1bmN0aW9ucyB0aGF0IHdp bGwgcmV0cmlldmUKPiB0aGUgY3VycmVudCBrZXJuZWwgdmFsdWUuCj4gCj4gU2lnbmVkLW9mZi1i eTogTWFhcnRlbiBMYW5raG9yc3QgPG1hYXJ0ZW4ubGFua2hvcnN0QGxpbnV4LmludGVsLmNvbT4K PiAtLS0KPiDCoGxpYi9pZ3Rfa21zLmMgfCA4MQo+ICsrKysrKysrKysrKysrKysrKysrKysrKysr KysrKysrKysrKysrKysrKysrKysrKysrKysrKysrKysrCj4gwqBsaWIvaWd0X2ttcy5oIHwgMjQg KysrKysrKysrKysrKysrKysrCj4gwqAyIGZpbGVzIGNoYW5nZWQsIDEwNSBpbnNlcnRpb25zKCsp Cj4gCj4gZGlmZiAtLWdpdCBhL2xpYi9pZ3Rfa21zLmMgYi9saWIvaWd0X2ttcy5jCj4gaW5kZXgg MzM5YzExODQzMTU0Li4xNzZlNjgyNWE0OTIgMTAwNjQ0Cj4gLS0tIGEvbGliL2lndF9rbXMuYwo+ ICsrKyBiL2xpYi9pZ3Rfa21zLmMKPiBAQCAtMjQwNyw2ICsyNDA3LDUxIEBAIHN0YXRpYyBpbnQg aWd0X291dHB1dF9jb21taXQoaWd0X291dHB1dF90Cj4gKm91dHB1dCwKPiDCoAlyZXR1cm4gMDsK PiDCoH0KPiDCoAo+ICtzdGF0aWMgdWludDY0X3QgaWd0X21vZGVfb2JqZWN0X2dldF9wcm9wKGln dF9kaXNwbGF5X3QgKmRpc3BsYXksCj4gKwkJCQkJwqB1aW50MzJfdCBvYmplY3RfdHlwZSwKPiAr CQkJCQnCoHVpbnQzMl90IG9iamVjdF9pZCwKPiArCQkJCQnCoHVpbnQzMl90IHByb3ApCj4gK3sK PiArCWRybU1vZGVPYmplY3RQcm9wZXJ0aWVzUHRyIHByb3BsaXN0Owo+ICsJYm9vbCBmb3VuZCA9 IGZhbHNlOwo+ICsJaW50IGk7Cj4gKwl1aW50NjRfdCByZXQ7Cj4gKwo+ICsJcHJvcGxpc3QgPSBk cm1Nb2RlT2JqZWN0R2V0UHJvcGVydGllcyhkaXNwbGF5LT5kcm1fZmQsCj4gb2JqZWN0X2lkLCBv YmplY3RfdHlwZSk7Cj4gKwlmb3IgKGkgPSAwOyBpIDwgcHJvcGxpc3QtPmNvdW50X3Byb3BzOyBp KyspIHsKPiArCQlpZiAocHJvcGxpc3QtPnByb3BzW2ldICE9IHByb3ApCj4gKwkJCWNvbnRpbnVl Owo+ICsKPiArCQlmb3VuZCA9IHRydWU7Cj4gKwkJYnJlYWs7Cj4gKwl9Cj4gKwo+ICsJaWd0X2Fz c2VydChmb3VuZCk7Cj4gKwo+ICsJcmV0ID0gcHJvcGxpc3QtPnByb3BfdmFsdWVzW2ldOwo+ICsK PiArCWRybU1vZGVGcmVlT2JqZWN0UHJvcGVydGllcyhwcm9wbGlzdCk7Cj4gKwlyZXR1cm4gcmV0 Owo+ICt9Cj4gKwo+ICsvKioKPiArICogaWd0X3BsYW5lX2dldF9wcm9wIC0gUmV0dXJuIGN1cnJl bnQgdmFsdWUgb24gYSBwbGFuZSBmb3IgYSBnaXZlbgo+IHByb3BlcnR5Lgo+ICsgKgo+ICsgKiBA cGxhbmU6IFRhcmdldCBwbGFuZS4KPiArICogQHByb3A6IFByb3BlcnR5IHRvIGNoZWNrLgo+ICsg Kgo+ICsgKiBSZXR1cm5zOiBUaGUgdmFsdWUgdGhlIHByb3BlcnR5IGlzIHNldCB0bywgaWYgdGhp cwo+ICsgKiBpcyBhIGJsb2IsIHRoZSBibG9iIGlkIGlzIHJldHVybmVkLiBUaGlzIGNhbiBiZSBw YXNzZWQKPiArICogdG8gZHJtTW9kZUdldFByb3BlcnR5QmxvYigpIHRvIGdldCB0aGUgY29udGVu dHMgb2YgdGhlIGJsb2IuCj4gKyAqLwo+ICt1aW50NjRfdCBpZ3RfcGxhbmVfZ2V0X3Byb3AoaWd0 X3BsYW5lX3QgKnBsYW5lLCBlbnVtCj4gaWd0X2F0b21pY19wbGFuZV9wcm9wZXJ0aWVzIHByb3Ap Cj4gK3sKPiArCWlndF9hc3NlcnQoaWd0X3BsYW5lX2hhc19wcm9wKHBsYW5lLCBwcm9wKSk7Cj4g Kwo+ICsJcmV0dXJuIGlndF9tb2RlX29iamVjdF9nZXRfcHJvcChwbGFuZS0+cGlwZS0+ZGlzcGxh eSwKPiBEUk1fTU9ERV9PQkpFQ1RfUExBTkUsCj4gKwkJCQkJcGxhbmUtPmRybV9wbGFuZS0+cGxh bmVfaWQsCj4gcGxhbmUtPnByb3BzW3Byb3BdKTsKPiArfQo+ICsKPiDCoC8qKgo+IMKgICogaWd0 X3BsYW5lX3JlcGxhY2VfcHJvcF9ibG9iOgo+IMKgICogQHBsYW5lOiBwbGFuZSB0byBzZXQgcHJv cGVydHkgb24uCj4gQEAgLTI0MzksNiArMjQ4NCwyNCBAQCBpZ3RfcGxhbmVfcmVwbGFjZV9wcm9w X2Jsb2IoaWd0X3BsYW5lX3QKPiAqcGxhbmUsIGVudW0gaWd0X2F0b21pY19wbGFuZV9wcm9wZXJ0 aWVzCj4gwqAJaWd0X3BsYW5lX3NldF9wcm9wX2NoYW5nZWQocGxhbmUsIHByb3ApOwo+IMKgfQo+ IMKgCj4gKy8qKgo+ICsgKiBpZ3Rfb3V0cHV0X2dldF9wcm9wIC0gUmV0dXJuIGN1cnJlbnQgdmFs dWUgb24gYW4gb3V0cHV0IGZvciBhCj4gZ2l2ZW4gcHJvcGVydHkuCj4gKyAqCj4gKyAqIEBvdXRw dXQ6IFRhcmdldCBvdXRwdXQuCj4gKyAqIEBwcm9wOiBQcm9wZXJ0eSB0byByZXR1cm4uCj4gKyAq Cj4gKyAqIFJldHVybnM6IFRoZSB2YWx1ZSB0aGUgcHJvcGVydHkgaXMgc2V0IHRvLCBpZiB0aGlz Cj4gKyAqIGlzIGEgYmxvYiwgdGhlIGJsb2IgaWQgaXMgcmV0dXJuZWQuIFRoaXMgY2FuIGJlIHBh c3NlZAo+ICsgKiB0byBkcm1Nb2RlR2V0UHJvcGVydHlCbG9iKCkgdG8gZ2V0IHRoZSBjb250ZW50 cyBvZiB0aGUgYmxvYi4KPiArICovCj4gK3VpbnQ2NF90IGlndF9vdXRwdXRfZ2V0X3Byb3AoaWd0 X291dHB1dF90ICpvdXRwdXQsIGVudW0KPiBpZ3RfYXRvbWljX2Nvbm5lY3Rvcl9wcm9wZXJ0aWVz IHByb3ApCj4gK3sKPiArCWlndF9hc3NlcnQoaWd0X291dHB1dF9oYXNfcHJvcChvdXRwdXQsIHBy b3ApKTsKPiArCj4gKwlyZXR1cm4gaWd0X21vZGVfb2JqZWN0X2dldF9wcm9wKG91dHB1dC0+ZGlz cGxheSwKPiBEUk1fTU9ERV9PQkpFQ1RfQ09OTkVDVE9SLAo+ICsJCQkJCW91dHB1dC0+aWQsIG91 dHB1dC0KPiA+cHJvcHNbcHJvcF0pOwo+ICt9Cj4gKwo+IMKgLyoqCj4gwqAgKiBpZ3Rfb3V0cHV0 X3JlcGxhY2VfcHJvcF9ibG9iOgo+IMKgICogQG91dHB1dDogb3V0cHV0IHRvIHNldCBwcm9wZXJ0 eSBvbi4KPiBAQCAtMjQ3MSw2ICsyNTM0LDI0IEBAIGlndF9vdXRwdXRfcmVwbGFjZV9wcm9wX2Js b2IoaWd0X291dHB1dF90Cj4gKm91dHB1dCwgZW51bSBpZ3RfYXRvbWljX2Nvbm5lY3Rvcl9wcm8K PiDCoAlpZ3Rfb3V0cHV0X3NldF9wcm9wX2NoYW5nZWQob3V0cHV0LCBwcm9wKTsKPiDCoH0KPiDC oAo+ICsvKioKPiArICogaWd0X3BpcGVfb2JqX2dldF9wcm9wIC0gUmV0dXJuIGN1cnJlbnQgdmFs dWUgb24gYSBwaXBlIGZvciBhCj4gZ2l2ZW4gcHJvcGVydHkuCj4gKyAqCj4gKyAqIEBwaXBlOiBU YXJnZXQgcGlwZS4KPiArICogQHByb3A6IFByb3BlcnR5IHRvIHJldHVybi4KPiArICoKPiArICog UmV0dXJuczogVGhlIHZhbHVlIHRoZSBwcm9wZXJ0eSBpcyBzZXQgdG8sIGlmIHRoaXMKPiArICog aXMgYSBibG9iLCB0aGUgYmxvYiBpZCBpcyByZXR1cm5lZC4gVGhpcyBjYW4gYmUgcGFzc2VkCj4g KyAqIHRvIGRybU1vZGVHZXRQcm9wZXJ0eUJsb2IoKSB0byBnZXQgdGhlIGNvbnRlbnRzIG9mIHRo ZSBibG9iLgo+ICsgKi8KPiArdWludDY0X3QgaWd0X3BpcGVfb2JqX2dldF9wcm9wKGlndF9waXBl X3QgKnBpcGUsIGVudW0KPiBpZ3RfYXRvbWljX2NydGNfcHJvcGVydGllcyBwcm9wKQo+ICt7Cj4g KwlpZ3RfYXNzZXJ0KGlndF9waXBlX29ial9oYXNfcHJvcChwaXBlLCBwcm9wKSk7Cj4gKwo+ICsJ cmV0dXJuIGlndF9tb2RlX29iamVjdF9nZXRfcHJvcChwaXBlLT5kaXNwbGF5LAo+IERSTV9NT0RF X09CSkVDVF9DUlRDLAo+ICsJCQkJCXBpcGUtPmNydGNfaWQsIHBpcGUtCj4gPnByb3BzW3Byb3Bd KTsKPiArfQo+ICsKPiDCoC8qKgo+IMKgICogaWd0X3BpcGVfb2JqX3JlcGxhY2VfcHJvcF9ibG9i Ogo+IMKgICogQHBpcGU6IHBpcGUgdG8gc2V0IHByb3BlcnR5IG9uLgo+IGRpZmYgLS1naXQgYS9s aWIvaWd0X2ttcy5oIGIvbGliL2lndF9rbXMuaAo+IGluZGV4IDkxNmNkMzU5NTE5YS4uZmRhOTRj YjY0MGRlIDEwMDY0NAo+IC0tLSBhL2xpYi9pZ3Rfa21zLmgKPiArKysgYi9saWIvaWd0X2ttcy5o Cj4gQEAgLTUwMyw2ICs1MDMsOCBAQCBpZ3RfcGxhbmVfaGFzX3Byb3AoaWd0X3BsYW5lX3QgKnBs YW5lLCBlbnVtCj4gaWd0X2F0b21pY19wbGFuZV9wcm9wZXJ0aWVzIHByb3ApCj4gwqAJcmV0dXJu IHBsYW5lLT5wcm9wc1twcm9wXTsKPiDCoH0KPiDCoAo+ICt1aW50NjRfdCBpZ3RfcGxhbmVfZ2V0 X3Byb3AoaWd0X3BsYW5lX3QgKnBsYW5lLCBlbnVtCj4gaWd0X2F0b21pY19wbGFuZV9wcm9wZXJ0 aWVzIHByb3ApOwo+ICsKPiDCoCNkZWZpbmUgaWd0X3BsYW5lX2lzX3Byb3BfY2hhbmdlZChwbGFu ZSwgcHJvcCkgXAo+IMKgCSghISgocGxhbmUpLT5jaGFuZ2VkICYgKDEgPDwgKHByb3ApKSkpCj4g wqAKPiBAQCAtNTM2LDYgKzUzOCw4IEBAIGlndF9vdXRwdXRfaGFzX3Byb3AoaWd0X291dHB1dF90 ICpvdXRwdXQsIGVudW0KPiBpZ3RfYXRvbWljX2Nvbm5lY3Rvcl9wcm9wZXJ0aWVzIHAKPiDCoAly ZXR1cm4gb3V0cHV0LT5wcm9wc1twcm9wXTsKPiDCoH0KPiDCoAo+ICt1aW50NjRfdCBpZ3Rfb3V0 cHV0X2dldF9wcm9wKGlndF9vdXRwdXRfdCAqb3V0cHV0LCBlbnVtCj4gaWd0X2F0b21pY19jb25u ZWN0b3JfcHJvcGVydGllcyBwcm9wKTsKPiArCj4gwqAjZGVmaW5lIGlndF9vdXRwdXRfaXNfcHJv cF9jaGFuZ2VkKG91dHB1dCwgcHJvcCkgXAo+IMKgCSghISgob3V0cHV0KS0+Y2hhbmdlZCAmICgx IDw8IChwcm9wKSkpKQo+IMKgI2RlZmluZSBpZ3Rfb3V0cHV0X3NldF9wcm9wX2NoYW5nZWQob3V0 cHV0LCBwcm9wKSBcCj4gQEAgLTU2OCw2ICs1NzIsMjYgQEAgaWd0X3BpcGVfb2JqX2hhc19wcm9w KGlndF9waXBlX3QgKnBpcGUsIGVudW0KPiBpZ3RfYXRvbWljX2NydGNfcHJvcGVydGllcyBwcm9w KQo+IMKgCXJldHVybiBwaXBlLT5wcm9wc1twcm9wXTsKPiDCoH0KPiDCoAo+ICt1aW50NjRfdCBp Z3RfcGlwZV9vYmpfZ2V0X3Byb3AoaWd0X3BpcGVfdCAqcGlwZSwgZW51bQo+IGlndF9hdG9taWNf Y3J0Y19wcm9wZXJ0aWVzIHByb3ApOwo+ICsKPiArLyoqCj4gKyAqIGlndF9waXBlX2dldF9wcm9w IC0gUmV0dXJuIGN1cnJlbnQgdmFsdWUgb24gYSBwaXBlIGZvciBhIGdpdmVuCj4gcHJvcGVydHku Cj4gKyAqCj4gKyAqIEBkaXNwbGF5OiBQb2ludGVyIHRvIGRpc3BsYXkuCj4gKyAqIEBwaXBlOiBU YXJnZXQgcGlwZS4KPiArICogQHByb3A6IFByb3BlcnR5IHRvIHJldHVybi4KPiArICoKPiArICog UmV0dXJuczogVGhlIHZhbHVlIHRoZSBwcm9wZXJ0eSBpcyBzZXQgdG8sIGlmIHRoaXMKPiArICog aXMgYSBibG9iLCB0aGUgYmxvYiBpZCBpcyByZXR1cm5lZC4gVGhpcyBjYW4gYmUgcGFzc2VkCj4g KyAqIHRvIGRybU1vZGVHZXRQcm9wZXJ0eUJsb2IoKSB0byBnZXQgdGhlIGNvbnRlbnRzIG9mIHRo ZSBibG9iLgo+ICsgKi8KPiArc3RhdGljIGlubGluZSB1aW50NjRfdAo+ICtpZ3RfcGlwZV9nZXRf cHJvcChpZ3RfZGlzcGxheV90ICpkaXNwbGF5LCBlbnVtIHBpcGUgcGlwZSwKPiArCQnCoMKgZW51 bSBpZ3RfYXRvbWljX2NydGNfcHJvcGVydGllcyBwcm9wKQo+ICt7Cj4gKwlyZXR1cm4gaWd0X3Bp cGVfb2JqX2dldF9wcm9wKCZkaXNwbGF5LT5waXBlc1twaXBlXSwgcHJvcCk7Cj4gK30KPiArCj4g wqAvKioKPiDCoCAqIGlndF9waXBlX2hhc19wcm9wIC0gQ2hlY2sgd2hldGhlciBwaXBlIHN1cHBv cnRzIGEgZ2l2ZW4gcHJvcGVydHkuCj4gwqAgKgotLSAKTWlrYSBLYWhvbGEgLSBJbnRlbCBPVEMK Cl9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fCkludGVsLWdm eCBtYWlsaW5nIGxpc3QKSW50ZWwtZ2Z4QGxpc3RzLmZyZWVkZXNrdG9wLm9yZwpodHRwczovL2xp c3RzLmZyZWVkZXNrdG9wLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2ludGVsLWdmeAo=