All of lore.kernel.org
 help / color / mirror / Atom feed
From: no-reply@patchew.org
To: gabriel291075@gmail.com
Cc: famz@redhat.com, qemu-devel@nongnu.org, peter.maydell@linaro.org
Subject: Re: [Qemu-devel] [PATCH v2] arm: Adding makefile for Kinetis K64 MK64FN1M0
Date: Thu, 19 Oct 2017 12:29:19 -0700 (PDT)	[thread overview]
Message-ID: <150844135941.413.2688233951724465156@b58463cdfd5f> (raw)
In-Reply-To: <1508417485-31911-1-git-send-email-gabriel291075@gmail.com>

Hi,

This series seems to have some coding style problems. See output below for
more information:

Type: series
Message-id: 1508417485-31911-1-git-send-email-gabriel291075@gmail.com
Subject: [Qemu-devel] [PATCH v2] arm: Adding makefile for Kinetis K64 MK64FN1M0

=== TEST SCRIPT BEGIN ===
#!/bin/bash

BASE=base
n=1
total=$(git log --oneline $BASE.. | wc -l)
failed=0

git config --local diff.renamelimit 0
git config --local diff.renames True

commits="$(git log --format=%H --reverse $BASE..)"
for c in $commits; do
    echo "Checking PATCH $n/$total: $(git log -n 1 --format=%s $c)..."
    if ! git show $c --format=email | ./scripts/checkpatch.pl --mailback -; then
        failed=1
        echo
    fi
    n=$((n+1))
done

exit $failed
=== TEST SCRIPT END ===

Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384
Switched to a new branch 'test'
ed890a8734 arm: Adding makefile for Kinetis K64 MK64FN1M0

=== OUTPUT BEGIN ===
Checking PATCH 1/1: arm: Adding makefile for Kinetis K64 MK64FN1M0...
ERROR: do not set execute permissions for source files
#25: FILE: hw/arm/Makefile.objs

ERROR: trailing whitespace
#36: FILE: hw/arm/Makefile.objs:26:
+^I$

total: 2 errors, 0 warnings, 7 lines checked

Your patch has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

=== OUTPUT END ===

Test command exited with code: 1


---
Email generated automatically by Patchew [http://patchew.org/].
Please send your feedback to patchew-devel@freelists.org

      parent reply	other threads:[~2017-10-19 19:30 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-10-19 12:51 [Qemu-devel] [PATCH v2] arm: Adding makefile for Kinetis K64 MK64FN1M0 gabriel291075
2017-10-19 17:52 ` no-reply
2017-10-19 18:55 ` no-reply
2017-10-19 19:29 ` no-reply [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=150844135941.413.2688233951724465156@b58463cdfd5f \
    --to=no-reply@patchew.org \
    --cc=famz@redhat.com \
    --cc=gabriel291075@gmail.com \
    --cc=peter.maydell@linaro.org \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.