From mboxrd@z Thu Jan 1 00:00:00 1970 From: Mika Kahola Subject: Re: [PATCH i-g-t v2 05/14] lib/igt_kms: Allow setting any output property through the !atomic paths Date: Fri, 20 Oct 2017 12:38:58 +0300 Message-ID: <1508492338.3274.142.camel@intel.com> References: <20171012115435.18880-1-maarten.lankhorst@linux.intel.com> <20171012115435.18880-6-maarten.lankhorst@linux.intel.com> Reply-To: mika.kahola@intel.com Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) by gabe.freedesktop.org (Postfix) with ESMTPS id A64946EBFC for ; Fri, 20 Oct 2017 09:41:11 +0000 (UTC) In-Reply-To: <20171012115435.18880-6-maarten.lankhorst@linux.intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Maarten Lankhorst , intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org UmV2aWV3ZWQtYnk6IE1pa2EgS2Fob2xhIDxtaWthLmthaG9sYUBpbnRlbC5jb20+CgpPbiBUaHUs IDIwMTctMTAtMTIgYXQgMTM6NTQgKzAyMDAsIE1hYXJ0ZW4gTGFua2hvcnN0IHdyb3RlOgo+IEV2 ZXJ5dGhpbmcgZXhjZXB0IENSVENfSUQgY2FuIGJlIHNldCBpbiB0aGUgbGVnYWN5IHBhdGhzLAo+ IHdlIGV2ZW4gaGF2ZSAyLCB0aGUgbGVnYWN5IGFuZCB1bml2ZXJzYWwgcGF0aC4gRXhjZXJjaXNl IGJvdGguIDpECj4gCj4gU2lnbmVkLW9mZi1ieTogTWFhcnRlbiBMYW5raG9yc3QgPG1hYXJ0ZW4u bGFua2hvcnN0QGxpbnV4LmludGVsLmNvbT4KPiAtLS0KPiDCoGxpYi9pZ3Rfa21zLmMgfCA1MyAr KysrKysrKysrKysrKysrKysrKysrKysrKysrKysrKysrKysrLS0tLS0tLS0tLQo+IC0tLS0tLQo+ IMKgMSBmaWxlIGNoYW5nZWQsIDM3IGluc2VydGlvbnMoKyksIDE2IGRlbGV0aW9ucygtKQo+IAo+ IGRpZmYgLS1naXQgYS9saWIvaWd0X2ttcy5jIGIvbGliL2lndF9rbXMuYwo+IGluZGV4IGJlODk2 MzI1NDdlNS4uZTdiOWZiYWJhNzA5IDEwMDY0NAo+IC0tLSBhL2xpYi9pZ3Rfa21zLmMKPiArKysg Yi9saWIvaWd0X2ttcy5jCj4gQEAgLTI0MTMsNiArMjQxMywzNiBAQCBzdGF0aWMgaW50IGlndF9w aXBlX2NvbW1pdChpZ3RfcGlwZV90ICpwaXBlLAo+IMKgCXJldHVybiAwOwo+IMKgfQo+IMKgCj4g K3N0YXRpYyBpbnQgaWd0X291dHB1dF9jb21taXQoaWd0X291dHB1dF90ICpvdXRwdXQsCj4gKwkJ CcKgwqDCoMKgwqBlbnVtIGlndF9jb21taXRfc3R5bGUgcywKPiArCQkJwqDCoMKgwqDCoGJvb2wg ZmFpbF9vbl9lcnJvcikKPiArewo+ICsJaW50IGksIHJldDsKPiArCj4gKwlmb3IgKGkgPSAwOyBp IDwgSUdUX05VTV9DT05ORUNUT1JfUFJPUFM7IGkrKykgewo+ICsJCWlmICghaWd0X291dHB1dF9p c19wcm9wX2NoYW5nZWQob3V0cHV0LCBpKSkKPiArCQkJY29udGludWU7Cj4gKwo+ICsJCS8qIENS VENfSUQgaXMgc2V0IGJ5IGNhbGxpbmcgZHJtTW9kZVNldENydGMgaW4gdGhlCj4gbGVnYWN5IHBh dGguICovCj4gKwkJaWYgKGkgPT0gSUdUX0NPTk5FQ1RPUl9DUlRDX0lEKQo+ICsJCQljb250aW51 ZTsKPiArCj4gKwkJaWd0X2Fzc2VydChvdXRwdXQtPnByb3BzW2ldKTsKPiArCj4gKwkJaWYgKHMg PT0gQ09NTUlUX0xFR0FDWSkKPiArCQkJcmV0ID0gZHJtTW9kZUNvbm5lY3RvclNldFByb3BlcnR5 KG91dHB1dC0KPiA+ZGlzcGxheS0+ZHJtX2ZkLCBvdXRwdXQtPmlkLAo+ICsJCQkJCQkJwqDCoG91 dHB1dC0KPiA+cHJvcHNbaV0sIG91dHB1dC0+dmFsdWVzW2ldKTsKPiArCQllbHNlCj4gKwkJCXJl dCA9IGRybU1vZGVPYmplY3RTZXRQcm9wZXJ0eShvdXRwdXQtCj4gPmRpc3BsYXktPmRybV9mZCwg b3V0cHV0LT5pZCwKPiArCQkJCQkJwqDCoMKgwqDCoMKgwqBEUk1fTU9ERV9PQkpFCj4gQ1RfQ09O TkVDVE9SLAo+ICsJCQkJCQnCoMKgwqDCoMKgwqDCoG91dHB1dC0KPiA+cHJvcHNbaV0sIG91dHB1 dC0+dmFsdWVzW2ldKTsKPiArCj4gKwkJQ0hFQ0tfUkVUVVJOKHJldCwgZmFpbF9vbl9lcnJvcik7 Cj4gKwl9Cj4gKwo+ICsJcmV0dXJuIDA7Cj4gK30KPiArCj4gwqBzdGF0aWMgdm9pZAo+IMKgaWd0 X3BpcGVfcmVwbGFjZV9ibG9iKGlndF9waXBlX3QgKnBpcGUsIGVudW0KPiBpZ3RfYXRvbWljX2Ny dGNfcHJvcGVydGllcyBwcm9wLCB2b2lkICpwdHIsIHNpemVfdCBsZW5ndGgpCj4gwqB7Cj4gQEAg LTI1OTAsMTAgKzI2MjAsMTEgQEAgZGlzcGxheV9jb21taXRfY2hhbmdlZChpZ3RfZGlzcGxheV90 Cj4gKmRpc3BsYXksIGVudW0gaWd0X2NvbW1pdF9zdHlsZSBzKQo+IMKgCWZvciAoaSA9IDA7IGkg PCBkaXNwbGF5LT5uX291dHB1dHM7IGkrKykgewo+IMKgCQlpZ3Rfb3V0cHV0X3QgKm91dHB1dCA9 ICZkaXNwbGF5LT5vdXRwdXRzW2ldOwo+IMKgCj4gLQkJaWYgKHMgPT0gQ09NTUlUX0FUT01JQykK PiArCQlpZiAocyAhPSBDT01NSVRfVU5JVkVSU0FMKQo+IMKgCQkJb3V0cHV0LT5jaGFuZ2VkID0g MDsKPiAtCQllbHNlIGlmIChzICE9IENPTU1JVF9VTklWRVJTQUwpCj4gLQkJCWlndF9vdXRwdXRf Y2xlYXJfcHJvcF9jaGFuZ2VkKG91dHB1dCwKPiBJR1RfQ09OTkVDVE9SX0NSVENfSUQpOwo+ICsJ CWVsc2UKPiArCQkJLyogbm8gbW9kZXNldCBpbiB1bml2ZXJzYWwgY29tbWl0LCBubyBjaGFuZ2UK PiB0byBjcnRjLiAqLwo+ICsJCQlvdXRwdXQtPmNoYW5nZWQgJj0gMSA8PAo+IElHVF9DT05ORUNU T1JfQ1JUQ19JRDsKPiDCoAl9Cj4gwqB9Cj4gwqAKPiBAQCAtMjYxMCw3ICsyNjQxLDcgQEAgc3Rh dGljIGludCBkb19kaXNwbGF5X2NvbW1pdChpZ3RfZGlzcGxheV90Cj4gKmRpc3BsYXksCj4gwqAJ CQnCoMKgwqDCoMKgZW51bSBpZ3RfY29tbWl0X3N0eWxlIHMsCj4gwqAJCQnCoMKgwqDCoMKgYm9v bCBmYWlsX29uX2Vycm9yKQo+IMKgewo+IC0JaW50IHJldDsKPiArCWludCBpLCByZXQgPSAwOwo+ IMKgCWVudW0gcGlwZSBwaXBlOwo+IMKgCUxPR19JTkRFTlQoZGlzcGxheSwgImNvbW1pdCIpOwo+ IMKgCj4gQEAgLTI2MTksMjggKzI2NTAsMTggQEAgc3RhdGljIGludCBkb19kaXNwbGF5X2NvbW1p dChpZ3RfZGlzcGxheV90Cj4gKmRpc3BsYXksCj4gwqAJaWYgKHMgPT0gQ09NTUlUX0FUT01JQykg ewo+IMKgCQlyZXQgPSBpZ3RfYXRvbWljX2NvbW1pdChkaXNwbGF5LAo+IERSTV9NT0RFX0FUT01J Q19BTExPV19NT0RFU0VULCBOVUxMKTsKPiDCoAl9IGVsc2Ugewo+IC0JCWludCB2YWxpZF9vdXRz ID0gMDsKPiAtCj4gwqAJCWZvcl9lYWNoX3BpcGUoZGlzcGxheSwgcGlwZSkgewo+IMKgCQkJaWd0 X3BpcGVfdCAqcGlwZV9vYmogPSAmZGlzcGxheS0KPiA+cGlwZXNbcGlwZV07Cj4gLQkJCWlndF9v dXRwdXRfdCAqb3V0cHV0ID0KPiBpZ3RfcGlwZV9nZXRfb3V0cHV0KHBpcGVfb2JqKTsKPiAtCj4g LQkJCWlmIChvdXRwdXQpCj4gLQkJCQl2YWxpZF9vdXRzKys7Cj4gwqAKPiDCoAkJCXJldCA9IGln dF9waXBlX2NvbW1pdChwaXBlX29iaiwgcywKPiBmYWlsX29uX2Vycm9yKTsKPiDCoAkJCWlmIChy ZXQpCj4gwqAJCQkJYnJlYWs7Cj4gwqAJCX0KPiDCoAo+IC0JCWlmICh2YWxpZF9vdXRzID09IDAp IHsKPiAtCQkJTE9HX1VOSU5ERU5UKGRpc3BsYXkpOwo+IC0KPiAtCQkJcmV0dXJuIC0xOwo+IC0J CX0KPiArCQlmb3IgKGkgPSAwOyAhcmV0ICYmIGkgPCBkaXNwbGF5LT5uX291dHB1dHM7IGkrKykK PiArCQkJcmV0ID0gaWd0X291dHB1dF9jb21taXQoJmRpc3BsYXktCj4gPm91dHB1dHNbaV0sIHMs IGZhaWxfb25fZXJyb3IpOwo+IMKgCX0KPiDCoAo+IC0KPiDCoAlMT0dfVU5JTkRFTlQoZGlzcGxh eSk7Cj4gwqAJQ0hFQ0tfUkVUVVJOKHJldCwgZmFpbF9vbl9lcnJvcik7Cj4gwqAKLS0gCk1pa2Eg S2Fob2xhIC0gSW50ZWwgT1RDCgpfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fXwpJbnRlbC1nZnggbWFpbGluZyBsaXN0CkludGVsLWdmeEBsaXN0cy5mcmVlZGVz a3RvcC5vcmcKaHR0cHM6Ly9saXN0cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0aW5mby9p bnRlbC1nZngK