From mboxrd@z Thu Jan 1 00:00:00 1970 From: Joonas Lahtinen Subject: Re: [PATCH 1/2] drm/i915: Introduce execlist_port_* accessors Date: Fri, 20 Oct 2017 13:34:38 +0300 Message-ID: <1508495678.5349.31.camel@linux.intel.com> References: <20171019143942.909-1-mika.kuoppala@linux.intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) by gabe.freedesktop.org (Postfix) with ESMTPS id F0FE56E0A3 for ; Fri, 20 Oct 2017 10:34:42 +0000 (UTC) In-Reply-To: <20171019143942.909-1-mika.kuoppala@linux.intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Mika Kuoppala , intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org T24gVGh1LCAyMDE3LTEwLTE5IGF0IDE3OjM5ICswMzAwLCBNaWthIEt1b3BwYWxhIHdyb3RlOgo+ IEZyb206IE1pa2EgS3VvcHBhbGEgPG1pa2Eua3VvcHBhbGFAaW50ZWwuY29tPgo+IAo+IEluc3Rl YWQgb2YgdHJ1c3RpbmcgdGhhdCBmaXJzdCBhdmFpbGFibGUgcG9ydCBpcyBhdCBpbmRleCAwLAo+ IHVzZSBhY2Nlc3NvciB0byBoaWRlIHRoaXMuIFRoaXMgaXMgYSBwcmVwYXJhdGlvbiBmb3IgYQo+ IGZvbGxvd2luZyBwYXRjaGVzIHdoZXJlIGhlYWQgY2FuIGJlIGF0IGFyYml0cmFyeSBsb2NhdGlv bgo+IGluIHRoZSBwb3J0IGFycmF5Lgo+IAo+IHYyOiBpbXByb3ZlZCBjb21taXQgbWVzc2FnZSwg ZWxzcF9yZWFkeSByZWFkYWJpbGl0eSAoQ2hyaXMpCj4gdjM6IHMvZXhlY2xpc3RfcG9ydF9pbmRl eC9leGVjbGlzdF9wb3J0IChDaHJpcykKPiB2NDogcmViYXNlIHRvIG5ldyBuYW1pbmcKPiB2NTog Zml4IHBvcnRfbmV4dCBpbmRleGluZwo+IAo+IENjOiBNaWNoYcWCIFdpbmlhcnNraSA8bWljaGFs LndpbmlhcnNraUBpbnRlbC5jb20+Cj4gQ2M6IEpvb25hcyBMYWh0aW5lbiA8am9vbmFzLmxhaHRp bmVuQGxpbnV4LmludGVsLmNvbT4KPiBDYzogQ2hyaXMgV2lsc29uIDxjaHJpc0BjaHJpcy13aWxz b24uY28udWs+Cj4gU2lnbmVkLW9mZi1ieTogTWlrYSBLdW9wcGFsYSA8bWlrYS5rdW9wcGFsYUBp bnRlbC5jb20+Cgo8U05JUD4KCj4gQEAgLTU2MSwxNSArNTYzLDIwIEBAIHN0YXRpYyB2b2lkIHBv cnRfYXNzaWduKHN0cnVjdCBleGVjbGlzdF9wb3J0ICpwb3J0LAo+ICBzdGF0aWMgdm9pZCBpOTE1 X2d1Y19kZXF1ZXVlKHN0cnVjdCBpbnRlbF9lbmdpbmVfY3MgKmVuZ2luZSkKPiAgewo+ICAJc3Ry dWN0IGludGVsX2VuZ2luZV9leGVjbGlzdHMgKiBjb25zdCBleGVjbGlzdHMgPSAmZW5naW5lLT5l eGVjbGlzdHM7Cj4gLQlzdHJ1Y3QgZXhlY2xpc3RfcG9ydCAqcG9ydCA9IGV4ZWNsaXN0cy0+cG9y dDsKPiArCXN0cnVjdCBleGVjbGlzdF9wb3J0ICpwb3J0Owo+ICAJc3RydWN0IGRybV9pOTE1X2dl bV9yZXF1ZXN0ICpsYXN0ID0gTlVMTDsKPiAtCWNvbnN0IHN0cnVjdCBleGVjbGlzdF9wb3J0ICog Y29uc3QgbGFzdF9wb3J0ID0KPiAtCQkmZXhlY2xpc3RzLT5wb3J0W2V4ZWNsaXN0cy0+cG9ydF9t YXNrXTsKPiAgCWJvb2wgc3VibWl0ID0gZmFsc2U7Cj4gIAlzdHJ1Y3QgcmJfbm9kZSAqcmI7Cj4g IAo+IC0JaWYgKHBvcnRfaXNzZXQocG9ydCkpCj4gLQkJcG9ydCsrOwo+ICsJcG9ydCA9IGV4ZWNs aXN0c19wb3J0X2hlYWQoZXhlY2xpc3RzKTsKPiArCj4gKwkvKgo+ICsJICogV2UgZG9uJ3QgY29h bGVzY2UgaW50byBsYXN0IHN1Ym1pdHRlZCBwb3J0IHdpdGggZ3VjLgo+ICsJICogRmluZCBmaXJz dCBmcmVlIHBvcnQsIHRoaXMgaXMgc2FmZSBhcyB3ZSBkb250IGRlcXVldWUgd2l0aG91dAo+ICsJ ICogYXRsZWFzdCBsYXN0IHBvcnQgZnJlZS4KCiJhdCBsZWFzdCIgKyAidGhlIgoKPFNOSVA+Cgo+ IEBAIC01NTcsNiArNTU3LDkgQEAgc3RhdGljIHZvaWQgZXhlY2xpc3RzX2RlcXVldWUoc3RydWN0 IGludGVsX2VuZ2luZV9jcyAqZW5naW5lKQo+ICAJaWYgKCFyYikKPiAgCQlnb3RvIHVubG9jazsK PiAgCj4gKwlwb3J0ID0gZXhlY2xpc3RzX3BvcnRfaGVhZChleGVjbGlzdHMpOwo+ICsJbGFzdCA9 IHBvcnRfcmVxdWVzdChwb3J0KTsKPiArCj4gIAlpZiAobGFzdCkgewo+ICAJCS8qCj4gIAkJICog RG9uJ3QgcmVzdWJtaXQgb3Igc3dpdGNoIHVudGlsIGFsbCBvdXRzdGFuZGluZwo+IEBAIC01NjQs NyArNTY3LDcgQEAgc3RhdGljIHZvaWQgZXhlY2xpc3RzX2RlcXVldWUoc3RydWN0IGludGVsX2Vu Z2luZV9jcyAqZW5naW5lKQo+ICAJCSAqIGtub3cgdGhlIG5leHQgcHJlZW1wdGlvbiBzdGF0dXMg d2Ugc2VlIGNvcnJlc3BvbmRzCj4gIAkJICogdG8gdGhpcyBFTFNQIHVwZGF0ZS4KPiAgCQkgKi8K PiAtCQlpZiAocG9ydF9jb3VudCgmcG9ydFswXSkgPiAxKQo+ICsJCWlmIChwb3J0X2NvdW50KHBv cnQpID4gMSkKPiAgCQkJZ290byB1bmxvY2s7Cj4gIAo+ICAJCWlmIChjYW5fcHJlZW1wdChlbmdp bmUpICYmCj4gQEAgLTU5OCw3ICs2MDEsNyBAQCBzdGF0aWMgdm9pZCBleGVjbGlzdHNfZGVxdWV1 ZShzdHJ1Y3QgaW50ZWxfZW5naW5lX2NzICplbmdpbmUpCj4gIAkJCSAqIHRoZSBkcml2ZXIgaXMg dW5hYmxlIHRvIGtlZXAgdXAgdGhlIHN1cHBseSBvZiBuZXcKPiAgCQkJICogd29yaykuCj4gIAkJ CSAqLwo+IC0JCQlpZiAocG9ydF9jb3VudCgmcG9ydFsxXSkpCj4gKwkJCWlmIChwb3J0X2NvdW50 KGV4ZWNsaXN0c19wb3J0X25leHQoZXhlY2xpc3RzLCBwb3J0KSkpCj4gIAkJCQlnb3RvIHVubG9j azsKPiAgCj4gIAkJCS8qIFdhSWRsZUxpdGVSZXN0b3JlOmJkdyxza2wKPiBAQCAtNjM0LDcgKzYz Nyw3IEBAIHN0YXRpYyB2b2lkIGV4ZWNsaXN0c19kZXF1ZXVlKHN0cnVjdCBpbnRlbF9lbmdpbmVf Y3MgKmVuZ2luZSkKPiAgCQkJCSAqIGNvbWJpbmUgdGhpcyByZXF1ZXN0IHdpdGggdGhlIGxhc3Qs IHRoZW4gd2UKPiAgCQkJCSAqIGFyZSBkb25lLgo+ICAJCQkJICovCj4gLQkJCQlpZiAocG9ydCA9 PSBsYXN0X3BvcnQpIHsKPiArCQkJCWlmIChwb3J0ID09IGV4ZWNsaXN0c19wb3J0X3RhaWwoZXhl Y2xpc3RzKSkgewo+ICAJCQkJCV9fbGlzdF9kZWxfbWFueSgmcC0+cmVxdWVzdHMsCj4gIAkJCQkJ CQkmcnEtPnByaW90cmVlLmxpbmspOwoKTm90aGluZyB0byBmaXggcmVsYXRlZCB0byB0aGlzIHBh dGNoLCBidXQgSSB3YXMgc3VyZSBuZXh0IGh1bmsgd2FzCmdvaW5nIHRvIGVzY2FwZSBteSBzY3Jl ZW4gOikgTWF5YmUgd2UgbmVlZCB0byBjdXQgdGhlIGluZGVudHMgYSBiaXQuCgo+IEBAIC04OTAs NyArOTAyLDcgQEAgc3RhdGljIHZvaWQgaW50ZWxfbHJjX2lycV9oYW5kbGVyKHVuc2lnbmVkIGxv bmcgZGF0YSkKPiAgCQkJfQo+ICAKPiAgCQkJLyogQWZ0ZXIgdGhlIGZpbmFsIGVsZW1lbnQsIHRo ZSBodyBzaG91bGQgYmUgaWRsZSAqLwo+IC0JCQlHRU1fQlVHX09OKHBvcnRfY291bnQocG9ydCkg PT0gMCAmJgo+ICsJCQlHRU1fQlVHX09OKHBvcnRfY291bnQoZXhlY2xpc3RzX3BvcnRfaGVhZChl eGVjbGlzdHMpKSA9PSAwICYmCj4gIAkJCQkgICAhKHN0YXR1cyAmIEdFTjhfQ1RYX1NUQVRVU19B Q1RJVkVfSURMRSkpOwoKV2h5IGRpZCB5b3Ugc3RvcCB0cnVzdGluZyBwb3J0IHZhcmlhYmxlIGhl cmU/CgpPdGhlciB0aGFuIHRoYXQsIGxvb2tzIGdvb2QgdG8gbWUuCgpSZWdhcmRzLCBKb29uYXMK LS0gCkpvb25hcyBMYWh0aW5lbgpPcGVuIFNvdXJjZSBUZWNobm9sb2d5IENlbnRlcgpJbnRlbCBD b3Jwb3JhdGlvbgpfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f XwpJbnRlbC1nZnggbWFpbGluZyBsaXN0CkludGVsLWdmeEBsaXN0cy5mcmVlZGVza3RvcC5vcmcK aHR0cHM6Ly9saXN0cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0aW5mby9pbnRlbC1nZngK