Re: [PATCH v3] drm/i915: Add Guc/HuC firmware details to error state

From: Chris Wilson <chris@chris-wilson.co.uk>
To: Joonas Lahtinen <joonas.lahtinen@linux.intel.com>,
	Michal Wajdeczko <michal.wajdeczko@intel.com>,
	intel-gfx@lists.freedesktop.org
Subject: Re: [PATCH v3] drm/i915: Add Guc/HuC firmware details to error state
Date: Fri, 20 Oct 2017 12:44:04 +0100	[thread overview]
Message-ID: <150849984460.29194.5998056658435701895@mail.alporthouse.com> (raw)
In-Reply-To: <1508492517.5349.25.camel@linux.intel.com>

Quoting Joonas Lahtinen (2017-10-20 10:41:57)
> On Thu, 2017-10-19 at 20:23 +0000, Michal Wajdeczko wrote:
> > @@ -774,6 +793,11 @@ int i915_error_state_to_str(struct drm_i915_error_state_buf *m,
> >       err_print_capabilities(m, &error->device_info);
> >       err_print_params(m, &error->params);
> >  
> > +     if (error->device_info.has_guc) {
> > +             intel_uc_fw_dump(&error->guc_fw, &p);
> > +             intel_uc_fw_dump(&error->huc_fw, &p);
> > +     }
> 
> I might use "error->{g,h}uc_fw.path" as the condition, for both
> individually. We will have DMC here in the future, too.

That's the type of predicate I was looking for. If we can tell when the
fw has been loaded just by looking at the uc_fw struct, please do so.
-Chris
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx