From mboxrd@z Thu Jan 1 00:00:00 1970 From: Chee, Tien Fong Date: Tue, 24 Oct 2017 05:11:19 +0000 Subject: [U-Boot] [PATCH v3 18/20] arm: socfpga: Enable function visible to other file In-Reply-To: <7de425f6-22e7-b02f-b04f-8e4ce3c78170@kernel.org> References: <1507882137-27841-1-git-send-email-tien.fong.chee@intel.com> <1507882137-27841-19-git-send-email-tien.fong.chee@intel.com> <1508746742.3650.52.camel@intel.com> <7de425f6-22e7-b02f-b04f-8e4ce3c78170@kernel.org> Message-ID: <1508821876.2221.0.camel@intel.com> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de On Isn, 2017-10-23 at 09:24 -0500, Dinh Nguyen wrote: > > On 10/23/2017 03:19 AM, Chee, Tien Fong wrote: > > > > On Jum, 2017-10-20 at 09:39 -0500, Dinh Nguyen wrote: > > > > > > > > > On 10/13/2017 03:08 AM, tien.fong.chee at intel.com wrote: > > > > > > > > > > > > From: Tien Fong Chee > > > > > > > > Enable function visible to other file, so it can be used by > > > > other > > > > functions from other file. > > > Huh? What function? What other file? Why? > > > > > > Please bear in mind for future patches, when reading the commit > > > message, > > > you should have a good idea of what the patch is doing without > > > even > > > looking at the patch. > > > > > > Need to include more people listed in get_maintainer.pl > > > > > > Maybe Marek has already commented, but this patch can be > > > separated > > > out > > > from the A10 series. > > > > > > Also, the commit header "arm:socfpga: Enable function visible to > > > other > > > file" is horrible and this patch has nothing to do with socfpga. > > > > > This patch is required by later patches, so this patch can't be > > separated out. This function is static declaration, but this > > function > > is required by the caller from other file(later patches). So, this > > patch is to remove ths static declaration so it is accessible by > > the > > caller from other file. > yes, I know what it means to remove the static declaration. Ok, I > understand the need for this patch in this series. Please fix up the > commit header and message. > Okay. > Dinh