From: Paulo Zanoni <paulo.r.zanoni@intel.com>
To: Rodrigo Vivi <rodrigo.vivi@intel.com>
Cc: intel-gfx@lists.freedesktop.org,
Dhinakaran Pandiyan <dhinakaran.pandiyan@intel.com>
Subject: Re: [PATCH i-g-t] tests/kms_frontbuffer_tracking: Skip tests when PSR cannot be enabled
Date: Thu, 26 Oct 2017 17:35:31 -0200 [thread overview]
Message-ID: <1509046531.2840.17.camel@intel.com> (raw)
In-Reply-To: <20171026193258.6tp3vhlwgdvwrskj@intel.com>
Em Qui, 2017-10-26 às 12:32 -0700, Rodrigo Vivi escreveu:
> On Thu, Oct 26, 2017 at 01:29:57PM +0000, Paulo Zanoni wrote:
> > Em Qua, 2017-10-25 às 17:37 -0700, Dhinakaran Pandiyan escreveu:
> > > The frontbuffer_tracking PSR tests fail if PSR cannot be
> > > activated
> > > when
> > > there is sink support. But, there are several other requirements
> > > related to
> > > mode timings that have to be satisfied before PSR can be enabled.
> > > No
> > > reason
> > > to fail these tests when PSR cannot be enabled.
> > >
> > > Cc: Paulo Zanoni <paulo.r.zanoni@intel.com>
> > > Cc: Rodrigo Vivi <rodrigo.vivi@intel.com>
> > > Signed-off-by: Dhinakaran Pandiyan <dhinakaran.pandiyan@intel.com
> > > >
> > > ---
> > > tests/kms_frontbuffer_tracking.c | 8 ++++----
> > > 1 file changed, 4 insertions(+), 4 deletions(-)
> > >
> > > diff --git a/tests/kms_frontbuffer_tracking.c
> > > b/tests/kms_frontbuffer_tracking.c
> > > index a068c8af..13c948de 100644
> > > --- a/tests/kms_frontbuffer_tracking.c
> > > +++ b/tests/kms_frontbuffer_tracking.c
> > > @@ -1548,12 +1548,12 @@ static void teardown_fbc(void)
> > > {
> > > }
> > >
> > > -static bool psr_sink_has_support(void)
> > > +static bool psr_has_support(void)
> > > {
> > > char buf[256];
> > >
> > > debugfs_read("i915_edp_psr_status", buf);
> > > - return strstr(buf, "Sink_Support: yes\n");
> > > + return strstr(buf, "Enabled: yes\n");
> >
> > What if PSR can be enabled but is just not enabled due to a bug?
>
> then psr basic should be the one failing...
But if we apply this patch we'll skip it instead of fail.
>
> >
> > I suppose we could print on debugfs whether source+sink support
> > equals
> > yes.
>
> or maybe here instead of sink: yes or enable: yes
> we could check
> sink: yes && source: yes
>
> if sink yes and source yes and psr is still disabled when we
> expect that enabled than we have the bug paulo mentioned.
>
> >
> > > }
> > >
> > > static void setup_psr(void)
> > > @@ -1564,8 +1564,8 @@ static void setup_psr(void)
> > > return;
> > > }
> > >
> > > - if (!psr_sink_has_support()) {
> > > - igt_info("Can't test PSR: not supported by
> > > sink.\n");
> > > + if (!psr_has_support()) {
> > > + igt_info("Can't test PSR: not supported.\n");
> > > return;
> > > }
> > > psr.can_test = true;
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
next prev parent reply other threads:[~2017-10-26 19:35 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-10-26 0:37 [PATCH i-g-t] tests/kms_frontbuffer_tracking: Skip tests when PSR cannot be enabled Dhinakaran Pandiyan
2017-10-26 1:10 ` ✓ Fi.CI.BAT: success for " Patchwork
2017-10-26 2:27 ` ✓ Fi.CI.IGT: " Patchwork
2017-10-26 13:29 ` [PATCH i-g-t] " Paulo Zanoni
2017-10-26 19:32 ` Rodrigo Vivi
2017-10-26 19:35 ` Paulo Zanoni [this message]
2017-10-26 19:46 ` Pandiyan, Dhinakaran
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1509046531.2840.17.camel@intel.com \
--to=paulo.r.zanoni@intel.com \
--cc=dhinakaran.pandiyan@intel.com \
--cc=intel-gfx@lists.freedesktop.org \
--cc=rodrigo.vivi@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.