From mboxrd@z Thu Jan 1 00:00:00 1970 From: Chris Wilson Subject: Re: [PATCH] drm/i915: Fallback to reserve forcewake if primary ack missing Date: Fri, 27 Oct 2017 15:38:36 +0100 Message-ID: <150911511653.2864.5500670008427954903@mail.alporthouse.com> References: <20171026140144.12267-1-mika.kuoppala@linux.intel.com> <20171027140421.15752-1-mika.kuoppala@linux.intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from fireflyinternet.com (mail.fireflyinternet.com [109.228.58.192]) by gabe.freedesktop.org (Postfix) with ESMTPS id 248F46E948 for ; Fri, 27 Oct 2017 14:39:08 +0000 (UTC) In-Reply-To: <20171027140421.15752-1-mika.kuoppala@linux.intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Mika Kuoppala , intel-gfx@lists.freedesktop.org Cc: Rodrigo Vivi List-Id: intel-gfx@lists.freedesktop.org UXVvdGluZyBNaWthIEt1b3BwYWxhICgyMDE3LTEwLTI3IDE1OjA0OjIxKQo+IFRoZXJlIGlzIGEg cG9zc2liaWxpdHkgb24gZ2VuOSBoYXJkd2FyZSB0byBtaXNzIHRoZSBmb3JjZXdha2UgYWNrCj4g bWVzc2FnZS4gVGhlIHJlY29tbWVuZGVkIHdvcmthcm91bmQgaXMgdG8gdXNlIGFub3RoZXIgZnJl ZQo+IGJpdCBhbmQgdG9nZ2xlIGl0IHVudGlsIG9yaWdpbmFsIGJpdCBpcyBzdWNjZXNzZnVsbHkg YWNrbm93bGVkZ2VkLgo+IAo+IFNvbWUgZnV0dXJlIGdlbjkgcmV2cyBtaWdodCBvciBtaWdodCBu b3QgZml4IHRoZSB1bmRlcmx5aW5nIGlzc3VlIGJ1dAo+IHRoZSBmYWxsYmFjayB0byByZXNlcnZl IGJpdCBkYW5jZSBjYW4gYmUgY29uc2lkZXJlZCBhcyBoYXJtbGVzczoKPiB3aXRob3V0IHRoZSBh Y2sgdGltZW91dCB3ZSBuZXZlciByZWFjaCB0aGUgcmVzZXJ2ZSBiaXQgZm9yY2V3YWtlLgo+IFRo dXMgYXMgb2Ygbm93IHdlIGFkb3B0IGEgYmxhbmtldCBhcHByb2FjaCBmb3IgYWxsIGdlbjkgYW5k IGxlYXZlCj4gdGhlIGJ5cGFzc2luZyB0aGUgcmVzZXJ2ZSBiaXQgYXBwcm9hY2ggZm9yIGZ1dHVy ZSBwYXRjaGVzIGlmCj4gY29ycmVzcG9uZGluZyBodyByZXZpc2lvbnMgZG8gYXBwZWFyLgo+IAo+ IENvbW1pdCA4M2UzMzM3MjA0YjIgKCJkcm0vaTkxNTogSW5jcmVhc2UgbWF4aW11bSBwb2xsaW5n IHRpbWUgdG8gNTBtcwo+IGZvciBmb3JjZXdha2UgcmVxdWVzdC9jbGVhciBhY2siKSBkaWQgaW5j cmVhc2UgdGhlIGZvcmNld2FrZSB0aW1lb3V0Lgo+IElmIHRoZSBpc3N1ZSB3YXMgYSBkZWxheWVk IGFjaywgZnV0dXJlIHdvcmsgY291bGQgaW5jbHVkZSBmaW5kaW5nCj4gYSBzdWl0YWJsZSB0aW1l b3V0IHZhbHVlIGJvdGggZm9yIHByaW1hcnkgYWNrIGFuZCByZXNlcnZlIHRvZ2dsZQo+IHRvIHJl ZHVjZSB0aGUgd29yc3QgY2FzZSBsYXRlbmN5Lgo+IAo+IHYyOiB1c2UgYml0IDE1LCBuYW1pbmcs IGNvbW1lbnQgKENocmlzKSwgb25seSB3YWl0IGZhbGxiYWNrIGFjawo+IAo+IFJlZmVyZW5jZXM6 IEhTREVTICMxNjA0MjU0NTI0Cj4gUmVmZXJlbmNlczogaHR0cHM6Ly9idWdzLmZyZWVkZXNrdG9w Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTAyMDUxCj4gQ2M6IENocmlzIFdpbHNvbiA8Y2hyaXNAY2hy aXMtd2lsc29uLmNvLnVrPgo+IENjOiBSb2RyaWdvIFZpdmkgPHJvZHJpZ28udml2aUBpbnRlbC5j b20+Cj4gQ2M6IFR2cnRrbyBVcnN1bGluIDx0dnJ0a28udXJzdWxpbkBpbnRlbC5jb20+Cj4gQ2M6 IEpvb25hcyBMYWh0aW5lbiA8am9vbmFzLmxhaHRpbmVuQGxpbnV4LmludGVsLmNvbT4KPiBDYzog U2FnYXIgQXJ1biBLYW1ibGUgPHNhZ2FyLmEua2FtYmxlQGludGVsLmNvbT4KPiBTaWduZWQtb2Zm LWJ5OiBNaWthIEt1b3BwYWxhIDxtaWthLmt1b3BwYWxhQGxpbnV4LmludGVsLmNvbT4KPiAtLS0K PiAgZHJpdmVycy9ncHUvZHJtL2k5MTUvaTkxNV9yZWcuaCAgICAgfCAgIDUgKy0KPiAgZHJpdmVy cy9ncHUvZHJtL2k5MTUvaW50ZWxfdW5jb3JlLmMgfCAxNDEgKysrKysrKysrKysrKysrKysrKysr KysrKysrKysrKysrLS0tCj4gIDIgZmlsZXMgY2hhbmdlZCwgMTM0IGluc2VydGlvbnMoKyksIDEy IGRlbGV0aW9ucygtKQo+IAo+IGRpZmYgLS1naXQgYS9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pOTE1 X3JlZy5oIGIvZHJpdmVycy9ncHUvZHJtL2k5MTUvaTkxNV9yZWcuaAo+IGluZGV4IDhjNzc1ZTk2 YjRlNC4uZjBmOGY2MDU5NjUyIDEwMDY0NAo+IC0tLSBhL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2k5 MTVfcmVnLmgKPiArKysgYi9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pOTE1X3JlZy5oCj4gQEAgLTc3 NzQsOCArNzc3NCw5IEBAIGVudW0gewo+ICAjZGVmaW5lICBGT1JDRVdBS0VfQUNLX01FRElBX0dF TjkgICAgICAgICAgICAgIF9NTUlPKDB4MEQ4OCkKPiAgI2RlZmluZSAgRk9SQ0VXQUtFX0FDS19S RU5ERVJfR0VOOSAgICAgICAgICAgICBfTU1JTygweDBEODQpCj4gICNkZWZpbmUgIEZPUkNFV0FL RV9BQ0tfQkxJVFRFUl9HRU45ICAgICAgICAgICAgX01NSU8oMHgxMzAwNDQpCj4gLSNkZWZpbmUg ICBGT1JDRVdBS0VfS0VSTkVMICAgICAgICAgICAgICAgICAgICAgMHgxCj4gLSNkZWZpbmUgICBG T1JDRVdBS0VfVVNFUiAgICAgICAgICAgICAgICAgICAgICAgMHgyCj4gKyNkZWZpbmUgICBGT1JD RVdBS0VfS0VSTkVMICAgICAgICAgICAgICAgICAgICAgQklUKDApCj4gKyNkZWZpbmUgICBGT1JD RVdBS0VfVVNFUiAgICAgICAgICAgICAgICAgICAgICAgQklUKDEpCj4gKyNkZWZpbmUgICBGT1JD RVdBS0VfS0VSTkVMX0ZBTExCQUNLICAgICAgICAgICAgQklUKDE1KQo+ICAjZGVmaW5lICBGT1JD RVdBS0VfTVRfQUNLICAgICAgICAgICAgICAgICAgICAgIF9NTUlPKDB4MTMwMDQwKQo+ICAjZGVm aW5lICBFQ09CVVMgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgX01NSU8o MHhhMTgwKQo+ICAjZGVmaW5lICAgIEZPUkNFV0FLRV9NVF9FTkFCTEUgICAgICAgICAgICAgICAg ICgxPDw1KQo+IGRpZmYgLS1naXQgYS9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF91bmNvcmUu YyBiL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX3VuY29yZS5jCj4gaW5kZXggOTZlZTZiMjc1 NGJlLi41ODhhZTM1YzhjOWEgMTAwNjQ0Cj4gLS0tIGEvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50 ZWxfdW5jb3JlLmMKPiArKysgYi9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF91bmNvcmUuYwo+ IEBAIC02OSwxNyArNjksMTA4IEBAIGZ3X2RvbWFpbl9hcm1fdGltZXIoc3RydWN0IGludGVsX3Vu Y29yZV9mb3JjZXdha2VfZG9tYWluICpkKQo+ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICBIUlRJTUVSX01PREVfUkVMKTsKPiAgfQo+ICAKPiArc3RhdGljIGlubGluZSBpbnQKPiArX193 YWl0X2Zvcl9hY2soY29uc3Qgc3RydWN0IGRybV9pOTE1X3ByaXZhdGUgKmk5MTUsCj4gKyAgICAg ICAgICAgICAgY29uc3Qgc3RydWN0IGludGVsX3VuY29yZV9mb3JjZXdha2VfZG9tYWluICpkLAo+ ICsgICAgICAgICAgICAgIGNvbnN0IHUzMiBhY2ssCj4gKyAgICAgICAgICAgICAgY29uc3QgdTMy IHZhbHVlKQo+ICt7Cj4gKyAgICAgICByZXR1cm4gd2FpdF9mb3JfYXRvbWljKChfX3Jhd19pOTE1 X3JlYWQzMihpOTE1LCBkLT5yZWdfYWNrKSAmIGFjaykgPT0gdmFsdWUsCj4gKyAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgIEZPUkNFV0FLRV9BQ0tfVElNRU9VVF9NUyk7Cj4gK30KPiArCj4g KwoKRG91YmxlIFxuCgo+ICtzdGF0aWMgaW5saW5lIGludAo+ICt3YWl0X2Fja19jbGVhcihjb25z dCBzdHJ1Y3QgZHJtX2k5MTVfcHJpdmF0ZSAqaTkxNSwKPiArICAgICAgICAgICAgICBjb25zdCBz dHJ1Y3QgaW50ZWxfdW5jb3JlX2ZvcmNld2FrZV9kb21haW4gKmQsCj4gKyAgICAgICAgICAgICAg Y29uc3QgdTMyIGFjaykKPiArewo+ICsgICAgICAgcmV0dXJuIF9fd2FpdF9mb3JfYWNrKGk5MTUs IGQsIGFjaywgMCk7Cj4gK30KPiArCj4gK3N0YXRpYyBpbmxpbmUgaW50Cj4gK3dhaXRfYWNrX3Nl dChjb25zdCBzdHJ1Y3QgZHJtX2k5MTVfcHJpdmF0ZSAqaTkxNSwKPiArICAgICAgICAgICAgY29u c3Qgc3RydWN0IGludGVsX3VuY29yZV9mb3JjZXdha2VfZG9tYWluICpkLAo+ICsgICAgICAgICAg ICBjb25zdCB1MzIgYWNrKQo+ICt7Cj4gKyAgICAgICByZXR1cm4gX193YWl0X2Zvcl9hY2soaTkx NSwgZCwgYWNrLCBhY2spOwo+ICt9Cj4gKwo+ICBzdGF0aWMgaW5saW5lIHZvaWQKPiAgZndfZG9t YWluX3dhaXRfYWNrX2NsZWFyKGNvbnN0IHN0cnVjdCBkcm1faTkxNV9wcml2YXRlICppOTE1LAo+ ICAgICAgICAgICAgICAgICAgICAgICAgICBjb25zdCBzdHJ1Y3QgaW50ZWxfdW5jb3JlX2ZvcmNl d2FrZV9kb21haW4gKmQpCj4gIHsKPiAtICAgICAgIGlmICh3YWl0X2Zvcl9hdG9taWMoKF9fcmF3 X2k5MTVfcmVhZDMyKGk5MTUsIGQtPnJlZ19hY2spICYKPiAtICAgICAgICAgICAgICAgICAgICAg ICAgICAgIEZPUkNFV0FLRV9LRVJORUwpID09IDAsCj4gLSAgICAgICAgICAgICAgICAgICAgICAg ICAgIEZPUkNFV0FLRV9BQ0tfVElNRU9VVF9NUykpCj4gKyAgICAgICBpZiAod2FpdF9hY2tfY2xl YXIoaTkxNSwgZCwgRk9SQ0VXQUtFX0tFUk5FTCkpCj4gICAgICAgICAgICAgICAgIERSTV9FUlJP UigiJXM6IHRpbWVkIG91dCB3YWl0aW5nIGZvciBmb3JjZXdha2UgYWNrIHRvIGNsZWFyLlxuIiwK PiAgICAgICAgICAgICAgICAgICAgICAgICAgIGludGVsX3VuY29yZV9mb3JjZXdha2VfZG9tYWlu X3RvX3N0cihkLT5pZCkpOwo+ICB9Cj4gIAo+ICtzdGF0aWMgaW50Cj4gK3dhaXRfYWNrX3dpdGhf ZmFsbGJhY2soY29uc3Qgc3RydWN0IGRybV9pOTE1X3ByaXZhdGUgKmk5MTUsCj4gKyAgICAgICAg ICAgICAgICAgICAgICBjb25zdCBzdHJ1Y3QgaW50ZWxfdW5jb3JlX2ZvcmNld2FrZV9kb21haW4g KmQsCj4gKyAgICAgICAgICAgICAgICAgICAgICBjb25zdCB1MzIgYWNrLAo+ICsgICAgICAgICAg ICAgICAgICAgICAgY29uc3QgdTMyIHZhbHVlKQo+ICt7Cj4gKyAgICAgICBpbnQgcmV0Owo+ICsK PiArICAgICAgIC8qCj4gKyAgICAgICAgKiBUaGVyZSBpcyBhIHBvc3NpYmlsaXR5IG9mIGRyaXZl cidzIHdha2UgcmVxdWVzdCBjb2xsaWRpbmcKPiArICAgICAgICAqIHdpdGggaGFyZHdhcmUncyBv d24gd2FrZSByZXF1ZXN0cyBhbmQgdGhhdCBjYW4gY2F1c2UKPiArICAgICAgICAqIGhhcmR3YXJl IHRvIG5vdCBkZWxpdmVyIHRoZSBkcml2ZXIncyBhY2sgbWVzc2FnZS4KPiArICAgICAgICAqCj4g KyAgICAgICAgKiBVc2UgYSBmYWxsYmFjayBiaXQgdG9nZ2xlIHRvIGtpY2sgdGhlIGdwdSBzdGF0 ZSBtYWNoaW5lCj4gKyAgICAgICAgKiBpbiBob3BlcyB0aGF0IHRoZSBvcmlnaW5hbCBhY2sgd2ls bCBiZSBkZWxpdmVyZWQgYWxvbmcgd2l0aAo+ICsgICAgICAgICogdGhlIGZhbGxiYWNrIGFjay4K PiArICAgICAgICAqCj4gKyAgICAgICAgKiBUaGlzIHdvcmthcm91bmQgaXMgZGVzY3JpYmVkIGlu IEhTREVTICMxNjA0MjU0NTI0Cj4gKyAgICAgICAgKi8KPiArCj4gKyAgICAgICB3YWl0X2Fja19j bGVhcihpOTE1LCBkLCBGT1JDRVdBS0VfS0VSTkVMX0ZBTExCQUNLKTsKPiArICAgICAgIF9fcmF3 X2k5MTVfd3JpdGUzMihpOTE1LCBkLT5yZWdfc2V0LAo+ICsgICAgICAgICAgICAgICAgICAgICAg ICAgIF9NQVNLRURfQklUX0VOQUJMRShGT1JDRVdBS0VfS0VSTkVMX0ZBTExCQUNLKSk7Cj4gKyAg ICAgICB3YWl0X2Fja19zZXQoaTkxNSwgZCwgRk9SQ0VXQUtFX0tFUk5FTF9GQUxMQkFDSyk7CgpN eSBtaW5kIGJvZ2dsZXMgd2hlbiBpdCBjb21lcyB0byB0aGlua2luZyBob3cgdGhpcyBpbnRlcmFj dHMgd2l0aCBhCnNlY29uZCBmYWlsdXJlIG9mIHRoZSBzYW1lIHR5cGUuICBGb3IgdGhhdCBsZXZl bCBvZiBwYXJhbm9pYSBJIHRoaW5rCnlvdSByZWFsbHkgZG8gbmVlZCB0byByZWN1cnNlIG9udG8g dGhlIG5leHQgZmFsbGJhY2sgYml0Li4uIChBbmQgdGhlbgp1bndpbmQgdGhlIGFja3MgYWxsIHRo ZSB3YXkgYmFjay4pIElmIHRoZSBidWcgaGFwcGVucyB0d2ljZSwgdGhlCmFja19jbGVhciBmb2xs b3dpbmcgdGhlIGNsZWFyIGlzIHNob3J0Y2lyY3VpdGVkLCBzbyB0aGUgc3Vic2VxdWVudAp3cml0 ZSthY2tfc2V0IGlzIGlsbC1kZWZpbmVkLCBhbmQgbWF5IG5vdCBldmVuIGJlIG5vdGljZWQuCgpP aywgSSBjYW4gc2VlIGhvdyB0aGlzIHdvdWxkIHdvcmsgaWYgdGhlIHJlZ2lzdGVyIHdhcyB1cGRh dGVkIG9uIGVkZ2UKZXZlbnRzLCBhbmQgb25lIG9mIHRob3NlIHdlbnQgbWlzc2luZy4gT24gdGhl IHNlY29uZCBhY2ssIHRoZSByZWZyZXNoIG9mCnRoZSByZWdpc3RlciB3b3VsZCBzZWUgYm90aCBi aXRzIHNldC4KCkkgdGhpbmsgeW91IHdhbnQgdG8gaW5zZXJ0IGEgdmFyaWFibGUgdWRlbGF5IChz YXkgMTAqcGFzcykgYmV0d2VlbiB0aGUKRkFMTEJBQ0sgd3JpdGUgKyB3YWl0X2Fja19zZXQoKS4g SSB3b3VsZCBhbHNvIG1vdmUgdGhlIGxvb3BzIHRvZ2V0aGVyIHRvCm1ha2UgdGhhdCBwYXNzIGtu b3duLgoKPiArCj4gKyAgICAgICByZXQgPSAoX19yYXdfaTkxNV9yZWFkMzIoaTkxNSwgZC0+cmVn X2FjaykgJiBhY2spID09IHZhbHVlOwo+ICsKPiArICAgICAgIF9fcmF3X2k5MTVfd3JpdGUzMihp OTE1LCBkLT5yZWdfc2V0LAo+ICsgICAgICAgICAgICAgICAgICAgICAgICAgIF9NQVNLRURfQklU X0RJU0FCTEUoRk9SQ0VXQUtFX0tFUk5FTF9GQUxMQkFDSykpOwo+ICsKPiArICAgICAgIHJldHVy biByZXQ7Cj4gK30KPiArCj4gK2VudW0gYWNrX3R5cGUgewo+ICsgICAgICAgQUNLX0NMRUFSID0g MCwKPiArICAgICAgIEFDS19TRVQKPiArfTsKPiArCj4gK3N0YXRpYyBpbnQKPiArZndfZG9tYWlu X3dhaXRfYWNrX3dpdGhfZmFsbGJhY2soY29uc3Qgc3RydWN0IGRybV9pOTE1X3ByaXZhdGUgKmk5 MTUsCj4gKyAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgY29uc3Qgc3RydWN0IGludGVs X3VuY29yZV9mb3JjZXdha2VfZG9tYWluICpkLAo+ICsgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgIGNvbnN0IGVudW0gYWNrX3R5cGUgdHlwZSkKPiArewo+ICsgICAgICAgaW50IHJldHJ5 ID0gMTA7Cj4gKyAgICAgICBpbnQgcmV0Owo+ICsKPiArICAgICAgIGRvIHsKPiArICAgICAgICAg ICAgICAgcmV0ID0gd2FpdF9hY2tfd2l0aF9mYWxsYmFjayhpOTE1LCBkLCBGT1JDRVdBS0VfS0VS TkVMLAo+ICsgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIHR5cGUg PT0gQUNLX1NFVCA/Cj4gKyAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgRk9SQ0VXQUtFX0tFUk5FTCA6IDApOwoKL21lIGNoYW5uZWxpbmcgSm9vbmFzCgpTdGljayB0 aGF0IHRlcm5hcnkgaW50byBhIGxvY2FsIGZvciByZWFkYWJpbGl0eS4KCj4gKyAgICAgICB9IHdo aWxlIChyZXQgJiYgLS1yZXRyeSk7CgpTaW5jZSB0aGlzIGlzIHRoZSBmYWxsYmFjayBwYXRoLCB3 ZSBjYW4gYWZmb3JkIGEgRFJNX0RFQlVHX0RSSVZFUiBoZXJlLgotQ2hyaXMKX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KSW50ZWwtZ2Z4IG1haWxpbmcgbGlz dApJbnRlbC1nZnhAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHBzOi8vbGlzdHMuZnJlZWRlc2t0 b3Aub3JnL21haWxtYW4vbGlzdGluZm8vaW50ZWwtZ2Z4Cg==