From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752056AbdJ3M5n (ORCPT ); Mon, 30 Oct 2017 08:57:43 -0400 Received: from mail-pg0-f66.google.com ([74.125.83.66]:56154 "EHLO mail-pg0-f66.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751869AbdJ3M5k (ORCPT ); Mon, 30 Oct 2017 08:57:40 -0400 X-Google-Smtp-Source: ABhQp+RcL3SkQ3T67RWkj+IRaxkiNPesGc038bK4GjKfz8hT2ZpUt0co15NHNAnOhCN0bLcEoEtxJA== From: Ryusuke Konishi To: Andrew Morton Cc: LKML , linux-nilfs , Ryusuke Konishi Subject: [PATCH 4/4] nilfs2: use octal for unreadable permission macro Date: Mon, 30 Oct 2017 21:52:15 +0900 Message-Id: <1509367935-3086-5-git-send-email-konishi.ryusuke@lab.ntt.co.jp> X-Mailer: git-send-email 1.8.3.1 In-Reply-To: <1509367935-3086-1-git-send-email-konishi.ryusuke@lab.ntt.co.jp> References: <1509367935-3086-1-git-send-email-konishi.ryusuke@lab.ntt.co.jp> X-Dispatcher: imput version 20110525(IM151) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Replace S_IRWXUGO with 0777 because symbolic permissions are considered harmful: https://lwn.net/Articles/696229/ Signed-off-by: Ryusuke Konishi --- fs/nilfs2/namei.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/fs/nilfs2/namei.c b/fs/nilfs2/namei.c index 515d13c..1a2894a 100644 --- a/fs/nilfs2/namei.c +++ b/fs/nilfs2/namei.c @@ -150,7 +150,7 @@ static int nilfs_symlink(struct inode *dir, struct dentry *dentry, if (err) return err; - inode = nilfs_new_inode(dir, S_IFLNK | S_IRWXUGO); + inode = nilfs_new_inode(dir, S_IFLNK | 0777); err = PTR_ERR(inode); if (IS_ERR(inode)) goto out; -- 1.8.3.1