From mboxrd@z Thu Jan 1 00:00:00 1970 From: Chris Wilson Subject: Re: [PATCH] drm/i915: Fallback to reserve forcewake if primary ack missing Date: Mon, 30 Oct 2017 13:08:17 +0000 Message-ID: <150936889791.4195.3473571417961107425@mail.alporthouse.com> References: <20171026140144.12267-1-mika.kuoppala@linux.intel.com> <20171030122707.10816-1-mika.kuoppala@linux.intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from fireflyinternet.com (mail.fireflyinternet.com [109.228.58.192]) by gabe.freedesktop.org (Postfix) with ESMTPS id 202E589E4C for ; Mon, 30 Oct 2017 13:09:18 +0000 (UTC) In-Reply-To: <20171030122707.10816-1-mika.kuoppala@linux.intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Mika Kuoppala , intel-gfx@lists.freedesktop.org Cc: Rodrigo Vivi List-Id: intel-gfx@lists.freedesktop.org UXVvdGluZyBNaWthIEt1b3BwYWxhICgyMDE3LTEwLTMwIDEyOjI3OjA3KQo+IFRoZXJlIGlzIGEg cG9zc2liaWxpdHkgb24gZ2VuOSBoYXJkd2FyZSB0byBtaXNzIHRoZSBmb3JjZXdha2UgYWNrCj4g bWVzc2FnZS4gVGhlIHJlY29tbWVuZGVkIHdvcmthcm91bmQgaXMgdG8gdXNlIGFub3RoZXIgZnJl ZQo+IGJpdCBhbmQgdG9nZ2xlIGl0IHVudGlsIG9yaWdpbmFsIGJpdCBpcyBzdWNjZXNzZnVsbHkg YWNrbm93bGVkZ2VkLgo+IAo+IFNvbWUgZnV0dXJlIGdlbjkgcmV2cyBtaWdodCBvciBtaWdodCBu b3QgZml4IHRoZSB1bmRlcmx5aW5nIGlzc3VlIGJ1dAo+IHRoZSBmYWxsYmFjayB0byByZXNlcnZl IGJpdCBkYW5jZSBjYW4gYmUgY29uc2lkZXJlZCBhcyBoYXJtbGVzczoKPiB3aXRob3V0IHRoZSBh Y2sgdGltZW91dCB3ZSBuZXZlciByZWFjaCB0aGUgcmVzZXJ2ZSBiaXQgZm9yY2V3YWtlLgo+IFRo dXMgYXMgb2Ygbm93IHdlIGFkb3B0IGEgYmxhbmtldCBhcHByb2FjaCBmb3IgYWxsIGdlbjkgYW5k IGxlYXZlCj4gdGhlIGJ5cGFzc2luZyB0aGUgcmVzZXJ2ZSBiaXQgYXBwcm9hY2ggZm9yIGZ1dHVy ZSBwYXRjaGVzIGlmCj4gY29ycmVzcG9uZGluZyBodyByZXZpc2lvbnMgZG8gYXBwZWFyLgo+IAo+ IENvbW1pdCA4M2UzMzM3MjA0YjIgKCJkcm0vaTkxNTogSW5jcmVhc2UgbWF4aW11bSBwb2xsaW5n IHRpbWUgdG8gNTBtcwo+IGZvciBmb3JjZXdha2UgcmVxdWVzdC9jbGVhciBhY2siKSBkaWQgaW5j cmVhc2UgdGhlIGZvcmNld2FrZSB0aW1lb3V0Lgo+IElmIHRoZSBpc3N1ZSB3YXMgYSBkZWxheWVk IGFjaywgZnV0dXJlIHdvcmsgY291bGQgaW5jbHVkZSBmaW5kaW5nCj4gYSBzdWl0YWJsZSB0aW1l b3V0IHZhbHVlIGJvdGggZm9yIHByaW1hcnkgYWNrIGFuZCByZXNlcnZlIHRvZ2dsZQo+IHRvIHJl ZHVjZSB0aGUgd29yc3QgY2FzZSBsYXRlbmN5Lgo+IAo+IHYyOiB1c2UgYml0IDE1LCBuYW1pbmcs IGNvbW1lbnQgKENocmlzKSwgb25seSB3YWl0IGZhbGxiYWNrIGFjawo+IHYzOiBmaXggcmV0dXJu IG9uIGZhbGxiYWNrLCBiYWNrb2ZmIGFmdGVyIGZhbGxiYWNrIHdyaXRlIChDaHJpcykKPiAKPiBS ZWZlcmVuY2VzOiBIU0RFUyAjMTYwNDI1NDUyNAo+IFJlZmVyZW5jZXM6IGh0dHBzOi8vYnVncy5m cmVlZGVza3RvcC5vcmcvc2hvd19idWcuY2dpP2lkPTEwMjA1MQo+IENjOiBDaHJpcyBXaWxzb24g PGNocmlzQGNocmlzLXdpbHNvbi5jby51az4KPiBDYzogUm9kcmlnbyBWaXZpIDxyb2RyaWdvLnZp dmlAaW50ZWwuY29tPgo+IENjOiBUdnJ0a28gVXJzdWxpbiA8dHZydGtvLnVyc3VsaW5AaW50ZWwu Y29tPgo+IENjOiBKb29uYXMgTGFodGluZW4gPGpvb25hcy5sYWh0aW5lbkBsaW51eC5pbnRlbC5j b20+Cj4gQ2M6IFNhZ2FyIEFydW4gS2FtYmxlIDxzYWdhci5hLmthbWJsZUBpbnRlbC5jb20+Cj4g U2lnbmVkLW9mZi1ieTogTWlrYSBLdW9wcGFsYSA8bWlrYS5rdW9wcGFsYUBsaW51eC5pbnRlbC5j b20+Cj4gLS0tCj4gK3N0YXRpYyBpbnQKPiArZndfZG9tYWluX3dhaXRfYWNrX3dpdGhfZmFsbGJh Y2soY29uc3Qgc3RydWN0IGRybV9pOTE1X3ByaXZhdGUgKmk5MTUsCj4gKyAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgY29uc3Qgc3RydWN0IGludGVsX3VuY29yZV9mb3JjZXdha2VfZG9t YWluICpkLAo+ICsgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIGNvbnN0IGVudW0gYWNr X3R5cGUgdHlwZSkKPiArewo+ICsgICAgICAgY29uc3QgdTMyIGFja19iaXQgPSBGT1JDRVdBS0Vf S0VSTkVMOwo+ICsgICAgICAgY29uc3QgdTMyIHZhbHVlID0gdHlwZSA9PSBBQ0tfU0VUID8gYWNr X2JpdCA6IDA7Cj4gKyAgICAgICB1bnNpZ25lZCBpbnQgcGFzcyA9IDA7Cj4gKyAgICAgICBib29s IGFja19kZXRlY3RlZDsKPiArCj4gKyAgICAgICAvKgo+ICsgICAgICAgICogVGhlcmUgaXMgYSBw b3NzaWJpbGl0eSBvZiBkcml2ZXIncyB3YWtlIHJlcXVlc3QgY29sbGlkaW5nCj4gKyAgICAgICAg KiB3aXRoIGhhcmR3YXJlJ3Mgb3duIHdha2UgcmVxdWVzdHMgYW5kIHRoYXQgY2FuIGNhdXNlCj4g KyAgICAgICAgKiBoYXJkd2FyZSB0byBub3QgZGVsaXZlciB0aGUgZHJpdmVyJ3MgYWNrIG1lc3Nh Z2UuCj4gKyAgICAgICAgKgo+ICsgICAgICAgICogVXNlIGEgZmFsbGJhY2sgYml0IHRvZ2dsZSB0 byBraWNrIHRoZSBncHUgc3RhdGUgbWFjaGluZQo+ICsgICAgICAgICogaW4gaG9wZXMgdGhhdCB0 aGUgb3JpZ2luYWwgYWNrIHdpbGwgYmUgZGVsaXZlcmVkIGFsb25nIHdpdGgKPiArICAgICAgICAq IHRoZSBmYWxsYmFjayBhY2suCgpzL2luIGhvcGVzL2luIHRoZSBob3BlLwoKPiArICAgICAgICAq Cj4gKyAgICAgICAgKiBUaGlzIHdvcmthcm91bmQgaXMgZGVzY3JpYmVkIGluIEhTREVTICMxNjA0 MjU0NTI0Cj4gKyAgICAgICAgKi8KPiArCj4gKyAgICAgICBkbyB7Cj4gKyAgICAgICAgICAgICAg IHdhaXRfYWNrX2NsZWFyKGk5MTUsIGQsIEZPUkNFV0FLRV9LRVJORUxfRkFMTEJBQ0spOwo+ICsK PiArICAgICAgICAgICAgICAgX19yYXdfaTkxNV93cml0ZTMyKGk5MTUsIGQtPnJlZ19zZXQsCj4g KyAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICBfTUFTS0VEX0JJVF9FTkFCTEUoRk9S Q0VXQUtFX0tFUk5FTF9GQUxMQkFDSykpOwo+ICsgICAgICAgICAgICAgICAvKiBHaXZlIGd0IHNv bWUgdGltZSB0byByZWxheCBiZWZvcmUgdGhlIHBvbGxpbmcgZnJlbnp5ICovCj4gKyAgICAgICAg ICAgICAgIHVkZWxheSgxMCAqIHBhc3MpOwo+ICsgICAgICAgICAgICAgICB3YWl0X2Fja19zZXQo aTkxNSwgZCwgRk9SQ0VXQUtFX0tFUk5FTF9GQUxMQkFDSyk7CgpJIHdvdWxkIGhhdmUgc3RhcnRl ZCBmcm9tIHBhc3M9MSAoaS5lLiB1ZGVsYXkoMTApKSBhcyB3ZSBhbHJlYWR5IGhhdmUgYQowLWRl bGF5IGZvciB0aGUgcHJpbWFyeSB3YWl0X2FjayBiZWZvcmUgd2UgaGl0IHRoZSBmYWxsYmFjay4K Cj4gKwo+ICsgICAgICAgICAgICAgICBhY2tfZGV0ZWN0ZWQgPSAoX19yYXdfaTkxNV9yZWFkMzIo aTkxNSwgZC0+cmVnX2FjaykgJiBhY2tfYml0KSA9PSB2YWx1ZTsKPiArCj4gKyAgICAgICAgICAg ICAgIF9fcmF3X2k5MTVfd3JpdGUzMihpOTE1LCBkLT5yZWdfc2V0LAo+ICsgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgX01BU0tFRF9CSVRfRElTQUJMRShGT1JDRVdBS0VfS0VSTkVM X0ZBTExCQUNLKSk7Cj4gKyAgICAgICAgICAgICAgIHBhc3MrKzsKPiArICAgICAgIH0gd2hpbGUg KCFhY2tfZGV0ZWN0ZWQgJiYgcGFzcyA8IDEwKTsKCgl1bnNpZ25lZCBpbnQgcGFzcyA9IDE7Cglk byB7CgkJLi4uCgl9IHdoaWxlICghYWNrX2RldGVjdGVkICYmIHBhc3MrKyA8IDEwKTsKCj4gKwo+ ICsgICAgICAgRFJNX0RFQlVHX0RSSVZFUigiJXMgaGFkIHRvIHVzZSBmYWxsYmFjayB0byAlcyBh Y2ssIDB4JXggKHBhc3NlcyAldSlcbiIsCj4gKyAgICAgICAgICAgICAgICAgICAgICAgIGludGVs X3VuY29yZV9mb3JjZXdha2VfZG9tYWluX3RvX3N0cihkLT5pZCksCj4gKyAgICAgICAgICAgICAg ICAgICAgICAgIHR5cGUgPT0gQUNLX1NFVCA/ICJzZXQiIDogImNsZWFyIiwKPiArICAgICAgICAg ICAgICAgICAgICAgICAgX19yYXdfaTkxNV9yZWFkMzIoaTkxNSwgZC0+cmVnX2FjayksCj4gKyAg ICAgICAgICAgICAgICAgICAgICAgIHBhc3MpOwo+ICsKPiArICAgICAgIHJldHVybiBhY2tfZGV0 ZWN0ZWQgPyAwIDogLUVUSU1FRE9VVDsKPiArfQoKSSB3YXMgZ29pbmcgdG8gc2F5IGEtYiwgYnV0 IGdpdmVuIHRoZSBzdGF0ZSBtYWNoaW5lIHdlJ3ZlIGRlZHVjZWQgdGhhdApleHBsYWlucyB3aHkg dGhpcyB3L2EgaGFzIGFueSBjaGFuY2Ugb2Ygc3VjY2VlZGluZywgSSBmZWVsIGEKClJldmlld2Vk LWJ5OiBDaHJpcyBXaWxzb24gPGNocmlzQGNocmlzLXdpbHNvbi5jby51az4KCmlzIGp1c3RpZmll ZC4gKElmIGl0J3Mgd3JvbmcsIEknbSBlcXVhbGx5IGN1bHBhYmxlIDspCi1DaHJpcwpfX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwpJbnRlbC1nZnggbWFpbGlu ZyBsaXN0CkludGVsLWdmeEBsaXN0cy5mcmVlZGVza3RvcC5vcmcKaHR0cHM6Ly9saXN0cy5mcmVl ZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0aW5mby9pbnRlbC1nZngK