From: Mike Galbraith <efault@gmx.de>
To: Atish Patra <atish.patra@oracle.com>,
Peter Zijlstra <peterz@infradead.org>
Cc: linux-kernel@vger.kernel.org, joelaf@google.com,
brendan.jackman@arm.com, jbacik@fb.com, mingo@redhat.com
Subject: Re: [PATCH RFC 1/2] sched: Minimize the idle cpu selection race window.
Date: Wed, 01 Nov 2017 07:54:23 +0100 [thread overview]
Message-ID: <1509519263.12290.30.camel@gmx.de> (raw)
In-Reply-To: <bc5730d4-b3ee-1fcc-7f57-824db606734f@oracle.com>
On Wed, 2017-11-01 at 01:08 -0500, Atish Patra wrote:
>
> On 10/31/2017 03:48 AM, Mike Galbraith wrote:
>
> > I played with something ~similar (cmpxchg() idle cpu reservation)
> I had an atomic version earlier as well. Peter's suggestion for per cpu
> seems to perform slightly better than atomic.
Yeah, no doubt about that.
> Thus, this patch has the per cpu version.
> > a
> > while back in the context of schbench, and it did help that,
> Do you have the schbench configuration somewhere that I can test? I
> tried various configurations but did not
> see any improvement or regression.
No, as noted, I didn't save anything. I watched and fiddled with
several configurations on various sized boxen, doing this/that on top
of the reservation thing to try to improve the "it's 100% about perfect
spread" schbench, but didn't like the pricetag, so tossed the lot over
my shoulder and walked away.
-Mike
next prev parent reply other threads:[~2017-11-01 6:55 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-10-31 5:27 [PATCH RFC 0/2] Fix race window during idle cpu selection Atish Patra
2017-10-31 5:27 ` [PATCH RFC 1/2] sched: Minimize the idle cpu selection race window Atish Patra
2017-10-31 8:20 ` Peter Zijlstra
2017-10-31 8:48 ` Mike Galbraith
2017-11-01 6:08 ` Atish Patra
2017-11-01 6:54 ` Mike Galbraith [this message]
2017-11-01 7:18 ` Mike Galbraith
2017-11-01 16:36 ` Atish Patra
2017-11-01 20:20 ` Mike Galbraith
2017-11-05 0:58 ` Joel Fernandes
2017-11-22 5:23 ` Atish Patra
2017-11-23 10:52 ` Uladzislau Rezki
2017-11-23 13:13 ` Mike Galbraith
2017-11-23 16:00 ` Josef Bacik
2017-11-23 17:40 ` Mike Galbraith
2017-11-23 21:11 ` Atish Patra
2017-11-24 10:26 ` Uladzislau Rezki
2017-11-24 18:46 ` Mike Galbraith
2017-11-26 20:58 ` Mike Galbraith
2017-11-28 9:34 ` Uladzislau Rezki
2017-11-28 10:49 ` Mike Galbraith
2017-11-29 10:41 ` Uladzislau Rezki
2017-11-29 18:15 ` Mike Galbraith
2017-11-30 12:30 ` Uladzislau Rezki
2017-10-31 5:27 ` [PATCH DEBUG 2/2] sched: Add a stat for " Atish Patra
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1509519263.12290.30.camel@gmx.de \
--to=efault@gmx.de \
--cc=atish.patra@oracle.com \
--cc=brendan.jackman@arm.com \
--cc=jbacik@fb.com \
--cc=joelaf@google.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=peterz@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.