From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754982AbdKAQuN (ORCPT ); Wed, 1 Nov 2017 12:50:13 -0400 Received: from smtprelay0185.hostedemail.com ([216.40.44.185]:52839 "EHLO smtprelay.hostedemail.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751681AbdKAQuJ (ORCPT ); Wed, 1 Nov 2017 12:50:09 -0400 X-Session-Marker: 6A6F6540706572636865732E636F6D X-Spam-Summary: 2,0,0,,d41d8cd98f00b204,joe@perches.com,:::::::,RULES_HIT:41:355:379:541:599:800:960:973:982:988:989:1260:1277:1311:1313:1314:1345:1359:1373:1431:1437:1515:1516:1518:1534:1542:1593:1594:1711:1730:1747:1777:1792:2393:2553:2559:2562:2691:2828:2895:3138:3139:3140:3141:3142:3353:3865:3867:3868:3870:3871:3872:4250:4321:4384:4605:5007:6119:7903:8957:9010:9545:10004:10400:10848:11026:11232:11657:11658:11914:12043:12296:12555:12679:12740:12760:12895:13161:13229:13439:14093:14097:14180:14181:14659:14721:21080:21451:21627:30054:30091,0,RBL:none,CacheIP:none,Bayesian:0.5,0.5,0.5,Netcheck:none,DomainCache:0,MSF:not bulk,SPF:,MSBL:0,DNSBL:none,Custom_rules:0:0:0,LFtime:3,LUA_SUMMARY:none X-HE-Tag: fifth13_1189d12c9d4c X-Filterd-Recvd-Size: 2967 Message-ID: <1509555005.31043.43.camel@perches.com> Subject: Re: [PATCH] scripts: warn about invalid MAINTAINERS patterns From: Joe Perches To: Tom Saeger , linux-kernel@vger.kernel.org Cc: xen-devel , mercurial-devel@mercurial-scm.org Date: Wed, 01 Nov 2017 09:50:05 -0700 In-Reply-To: <20171031213740.25510-1-tom.saeger@oracle.com> References: <20171031213740.25510-1-tom.saeger@oracle.com> Content-Type: text/plain; charset="ISO-8859-1" X-Mailer: Evolution 3.26.1-1 Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org (add mercurial-devel and xen-devel to cc's) On Tue, 2017-10-31 at 16:37 -0500, Tom Saeger wrote: > Add "--pattern-checks" option to get_maintainer.pl to warn about invalid > "F" and "X" patterns found in MAINTAINERS file(s). Hey again Tom. About mercurial/hg. While as far as I know there hasn't been a mercurial tree for the linux kernel sources in many years, I believe the mercurial command to list files should be different. > my %VCS_cmds_hg = ( > @@ -167,6 +169,7 @@ my %VCS_cmds_hg = ( > "subject_pattern" => "^HgSubject: (.*)", > "stat_pattern" => "^(\\d+)\t(\\d+)\t\$file\$", > "file_exists_cmd" => "hg files \$file", > + "list_files_cmd" => "hg files \$file", I think this should be "list_files_cmd" => "hg manifest -R \$file", It seems to work on a XEN test branch but does anyone really care about hg support in get_maintainers? btw: to the XEN maintainers The XEN mercurial branch for MAINTAINERS has a few odd entries and a few missing file patterns I think the XEN MAINTAINERS file should be updated to: --- diff -r c60f04b73240 MAINTAINERS --- a/MAINTAINERS Mon Oct 16 15:24:44 2017 +0100 +++ b/MAINTAINERS Wed Nov 01 09:39:34 2017 -0700 @@ -246,7 +246,8 @@ KCONFIG M: Doug Goldstein S: Supported -F: docs/misc/kconfig{,-language}.txt +F: docs/misc/kconfig.txt +F: docs/misc/kconfig-language.txt F: xen/tools/kconfig/ KDD DEBUGGER @@ -257,8 +258,8 @@ KEXEC M: Andrew Cooper S: Supported -F: xen/common/{kexec,kimage}.c -F: xen/include/{kexec,kimage}.h +F: xen/common/kexec.[ch] +F: xen/common/kimage.[ch] F: xen/arch/x86/machine_kexec.c F: xen/arch/x86/x86_64/kexec_reloc.S --- After the patch above is applied, --self-test shows: $ ~/linux/next/scripts/get_maintainer.pl --self-test ./MAINTAINERS:403: warning: no matches F: drivers/xen/usb*/ ./MAINTAINERS:415: warning: no matches F: xen/arch/x88/hvm/vm_event.c ./MAINTAINERS:429: warning: no matches F: extras/mini-os/tpm* ./MAINTAINERS:430: warning: no matches F: extras/mini-os/include/tpm*