From mboxrd@z Thu Jan 1 00:00:00 1970 From: Amir Goldstein Subject: [PATCH v6 1/9] ovl: move include of ovl_entry.h into overlayfs.h Date: Wed, 1 Nov 2017 22:22:45 +0200 Message-ID: <1509567773-25590-2-git-send-email-amir73il@gmail.com> References: <1509567773-25590-1-git-send-email-amir73il@gmail.com> Return-path: Received: from mail-wr0-f195.google.com ([209.85.128.195]:57263 "EHLO mail-wr0-f195.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755206AbdKAUWN (ORCPT ); Wed, 1 Nov 2017 16:22:13 -0400 Received: by mail-wr0-f195.google.com with SMTP id r79so2995749wrb.13 for ; Wed, 01 Nov 2017 13:22:12 -0700 (PDT) In-Reply-To: <1509567773-25590-1-git-send-email-amir73il@gmail.com> Sender: linux-unionfs-owner@vger.kernel.org List-Id: linux-unionfs@vger.kernel.org To: Miklos Szeredi Cc: Chandan Rajendra , Vivek Goyal , linux-unionfs@vger.kernel.org Most overlayfs c files already explicitly include ovl_entry.h to use overlay entry struct definitions and upcoming changes are going to require even more c files to include this header. All overlayfs c files include overlayfs.h and overlayfs.h itself refers to some structs defined in ovl_entry.h, so it seems more logic to include ovl_entry.h from overlayfs.h than from c files. Signed-off-by: Amir Goldstein --- fs/overlayfs/copy_up.c | 1 - fs/overlayfs/inode.c | 1 - fs/overlayfs/namei.c | 1 - fs/overlayfs/overlayfs.h | 1 + fs/overlayfs/super.c | 1 - fs/overlayfs/util.c | 1 - 6 files changed, 1 insertion(+), 5 deletions(-) diff --git a/fs/overlayfs/copy_up.c b/fs/overlayfs/copy_up.c index c441f9387a1b..9311d183b532 100644 --- a/fs/overlayfs/copy_up.c +++ b/fs/overlayfs/copy_up.c @@ -22,7 +22,6 @@ #include #include #include "overlayfs.h" -#include "ovl_entry.h" #define OVL_COPY_UP_CHUNK_SIZE (1 << 20) diff --git a/fs/overlayfs/inode.c b/fs/overlayfs/inode.c index 2949448d0c7d..b772e5a2a730 100644 --- a/fs/overlayfs/inode.c +++ b/fs/overlayfs/inode.c @@ -14,7 +14,6 @@ #include #include #include "overlayfs.h" -#include "ovl_entry.h" int ovl_setattr(struct dentry *dentry, struct iattr *attr) { diff --git a/fs/overlayfs/namei.c b/fs/overlayfs/namei.c index a12dc10bf726..505a4b8902fc 100644 --- a/fs/overlayfs/namei.c +++ b/fs/overlayfs/namei.c @@ -15,7 +15,6 @@ #include #include #include "overlayfs.h" -#include "ovl_entry.h" struct ovl_lookup_data { struct qstr name; diff --git a/fs/overlayfs/overlayfs.h b/fs/overlayfs/overlayfs.h index d53157ccf0d7..1cf3bdd193a4 100644 --- a/fs/overlayfs/overlayfs.h +++ b/fs/overlayfs/overlayfs.h @@ -9,6 +9,7 @@ #include #include +#include "ovl_entry.h" enum ovl_path_type { __OVL_PATH_UPPER = (1 << 0), diff --git a/fs/overlayfs/super.c b/fs/overlayfs/super.c index f5738e96a052..8702803ba328 100644 --- a/fs/overlayfs/super.c +++ b/fs/overlayfs/super.c @@ -18,7 +18,6 @@ #include #include #include "overlayfs.h" -#include "ovl_entry.h" MODULE_AUTHOR("Miklos Szeredi "); MODULE_DESCRIPTION("Overlay filesystem"); diff --git a/fs/overlayfs/util.c b/fs/overlayfs/util.c index 51ca8bd16009..9158d17bb320 100644 --- a/fs/overlayfs/util.c +++ b/fs/overlayfs/util.c @@ -17,7 +17,6 @@ #include #include #include "overlayfs.h" -#include "ovl_entry.h" int ovl_want_write(struct dentry *dentry) { -- 2.7.4