From mboxrd@z Thu Jan 1 00:00:00 1970 From: Chris Wilson Subject: Re: [PATCH 1/2] drm/i915: Introduce execlist_port_* accessors Date: Thu, 02 Nov 2017 15:03:31 +0000 Message-ID: <150963501181.6111.10657282814200657443@mail.alporthouse.com> References: <20171031152734.11016-1-mika.kuoppala@linux.intel.com> <20171102143238.4829-1-mika.kuoppala@linux.intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from fireflyinternet.com (mail.fireflyinternet.com [109.228.58.192]) by gabe.freedesktop.org (Postfix) with ESMTPS id 5ECED6E912 for ; Thu, 2 Nov 2017 15:03:37 +0000 (UTC) In-Reply-To: <20171102143238.4829-1-mika.kuoppala@linux.intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Mika Kuoppala , intel-gfx@lists.freedesktop.org Cc: Mika@freedesktop.org List-Id: intel-gfx@lists.freedesktop.org UXVvdGluZyBNaWthIEt1b3BwYWxhICgyMDE3LTExLTAyIDE0OjMyOjM4KQo+IEZyb206IE1pa2Eg S3VvcHBhbGEgPG1pa2Eua3VvcHBhbGFAaW50ZWwuY29tPgo+IAo+IEluc3RlYWQgb2YgdHJ1c3Rp bmcgdGhhdCBmaXJzdCBhdmFpbGFibGUgcG9ydCBpcyBhdCBpbmRleCAwLAo+IHVzZSBhY2Nlc3Nv ciB0byBoaWRlIHRoaXMuIFRoaXMgaXMgYSBwcmVwYXJhdGlvbiBmb3IgYQo+IGZvbGxvd2luZyBw YXRjaGVzIHdoZXJlIGhlYWQgY2FuIGJlIGF0IGFyYml0cmFyeSBsb2NhdGlvbgo+IGluIHRoZSBw b3J0IGFycmF5Lgo+IAo+IHYyOiBpbXByb3ZlZCBjb21taXQgbWVzc2FnZSwgZWxzcF9yZWFkeSBy ZWFkYWJpbGl0eSAoQ2hyaXMpCj4gdjM6IHMvZXhlY2xpc3RfcG9ydF9pbmRleC9leGVjbGlzdF9w b3J0IChDaHJpcykKPiB2NDogcmViYXNlIHRvIG5ldyBuYW1pbmcKPiB2NTogZml4IHBvcnRfbmV4 dCBpbmRleGluZwo+IHY2OiBhZGFwdCB0byBwcmVlbXB0Cj4gdjc6IGltcHJvdmVkIF9wb3J0X25l eHQgKENocmlzKQo+IAo+IENjOiBNaWNoYcWCIFdpbmlhcnNraSA8bWljaGFsLndpbmlhcnNraUBp bnRlbC5jb20+Cj4gQ2M6IEpvb25hcyBMYWh0aW5lbiA8am9vbmFzLmxhaHRpbmVuQGxpbnV4Lmlu dGVsLmNvbT4KPiBDYzogQ2hyaXMgV2lsc29uIDxjaHJpc0BjaHJpcy13aWxzb24uY28udWs+Cj4g U2lnbmVkLW9mZi1ieTogTWlrYSBLdW9wcGFsYSA8bWlrYS5rdW9wcGFsYUBsaW51eC5pbnRlbC5j b20+Cj4gLS0tCj4gIGRyaXZlcnMvZ3B1L2RybS9pOTE1L2k5MTVfZ3B1X2Vycm9yLmMgICAgICB8 ICA2ICsrLS0KPiAgZHJpdmVycy9ncHUvZHJtL2k5MTUvaTkxNV9ndWNfc3VibWlzc2lvbi5jIHwg NTAgKysrKysrKysrKysrKysrKysrLS0tLS0tLS0tLS0tCj4gIGRyaXZlcnMvZ3B1L2RybS9pOTE1 L2ludGVsX2VuZ2luZV9jcy5jICAgICB8IDE4ICsrKysrKy0tLS0tCj4gIGRyaXZlcnMvZ3B1L2Ry bS9pOTE1L2ludGVsX2xyYy5jICAgICAgICAgICB8IDQ5ICsrKysrKysrKysrKysrKysrKy0tLS0t LS0tLS0tCj4gIGRyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX3JpbmdidWZmZXIuaCAgICB8IDQ0 ICsrKysrKysrKysrKysrKysrKysrKysrKy0tCj4gIDUgZmlsZXMgY2hhbmdlZCwgMTE5IGluc2Vy dGlvbnMoKyksIDQ4IGRlbGV0aW9ucygtKQo+IAo+IGRpZmYgLS1naXQgYS9kcml2ZXJzL2dwdS9k cm0vaTkxNS9pOTE1X2dwdV9lcnJvci5jIGIvZHJpdmVycy9ncHUvZHJtL2k5MTUvaTkxNV9ncHVf ZXJyb3IuYwo+IGluZGV4IDY1M2ZiNjllN2VjYi4uNmQwYmRiMDNiM2YwIDEwMDY0NAo+IC0tLSBh L2RyaXZlcnMvZ3B1L2RybS9pOTE1L2k5MTVfZ3B1X2Vycm9yLmMKPiArKysgYi9kcml2ZXJzL2dw dS9kcm0vaTkxNS9pOTE1X2dwdV9lcnJvci5jCj4gQEAgLTEzMzMsMTEgKzEzMzMsMTMgQEAgc3Rh dGljIHZvaWQgZW5naW5lX3JlY29yZF9yZXF1ZXN0cyhzdHJ1Y3QgaW50ZWxfZW5naW5lX2NzICpl bmdpbmUsCj4gIHN0YXRpYyB2b2lkIGVycm9yX3JlY29yZF9lbmdpbmVfZXhlY2xpc3RzKHN0cnVj dCBpbnRlbF9lbmdpbmVfY3MgKmVuZ2luZSwKPiAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICBzdHJ1Y3QgZHJtX2k5MTVfZXJyb3JfZW5naW5lICplZSkKPiAgewo+IC0g ICAgICAgY29uc3Qgc3RydWN0IGludGVsX2VuZ2luZV9leGVjbGlzdHMgKiBjb25zdCBleGVjbGlz dHMgPSAmZW5naW5lLT5leGVjbGlzdHM7Cj4gKyAgICAgICBzdHJ1Y3QgaW50ZWxfZW5naW5lX2V4 ZWNsaXN0cyAqIGNvbnN0IGV4ZWNsaXN0cyA9ICZlbmdpbmUtPmV4ZWNsaXN0czsKPiAgICAgICAg IHVuc2lnbmVkIGludCBuOwo+ICAKPiAgICAgICAgIGZvciAobiA9IDA7IG4gPCBleGVjbGlzdHNf bnVtX3BvcnRzKGV4ZWNsaXN0cyk7IG4rKykgewo+IC0gICAgICAgICAgICAgICBzdHJ1Y3QgZHJt X2k5MTVfZ2VtX3JlcXVlc3QgKnJxID0gcG9ydF9yZXF1ZXN0KCZleGVjbGlzdHMtPnBvcnRbbl0p Owo+ICsgICAgICAgICAgICAgICBzdHJ1Y3QgZHJtX2k5MTVfZ2VtX3JlcXVlc3QgKnJxOwo+ICsK PiArICAgICAgICAgICAgICAgcnEgPSBwb3J0X3JlcXVlc3QoZXhlY2xpc3RzX3BvcnQoZXhlY2xp c3RzLCBuKSk7Cj4gIApUaGlzIG5ld2xpbmUgaXNuJ3QgYXMgaW50ZXJlc3RpbmcgYXMgdGhlIG90 aGVycy4gTm8gb25lIHdpbGwgc2hlZCBhIHRlYXIKaWYgaXQgaXMgcmVtb3ZlZC4KCj4gICAgICAg ICAgICAgICAgIGlmICghcnEpCj4gICAgICAgICAgICAgICAgICAgICAgICAgYnJlYWs7Cgo+IEBA IC02NjUsNyArNjcwLDggQEAgc3RhdGljIHZvaWQgZXhlY2xpc3RzX2RlcXVldWUoc3RydWN0IGlu dGVsX2VuZ2luZV9jcyAqZW5naW5lKQo+ICAKPiAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgIGlmIChzdWJtaXQpCj4gICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg IHBvcnRfYXNzaWduKHBvcnQsIGxhc3QpOwo+IC0gICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgcG9ydCsrOwo+ICsKPiArICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIHBvcnQgPSBl eGVjbGlzdHNfcG9ydF9uZXh0KGV4ZWNsaXN0cywgcG9ydCk7Cj4gIAoKU3BhcmUgdXMgdGhpcyBu ZXdsaW5lIGFzIHdlbGwuIExldCdzIGhhdmUgdGhlIGFkdmFuY2UgYW5kIEJVRygpIHRpZ2h0bHkK Y291cGxlZC4KCj4gICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICBHRU1fQlVHX09OKHBv cnRfaXNzZXQocG9ydCkpOwo+ICAgICAgICAgICAgICAgICAgICAgICAgIH0KPiBAQCAtNjk5LDgg KzcwNSwxMCBAQCBzdGF0aWMgdm9pZCBleGVjbGlzdHNfZGVxdWV1ZShzdHJ1Y3QgaW50ZWxfZW5n aW5lX2NzICplbmdpbmUpCj4gIHZvaWQKPiAgZXhlY2xpc3RzX2NhbmNlbF9wb3J0X3JlcXVlc3Rz KHN0cnVjdCBpbnRlbF9lbmdpbmVfZXhlY2xpc3RzICogY29uc3QgZXhlY2xpc3RzKQo+ICB7Cj4g LSAgICAgICBzdHJ1Y3QgZXhlY2xpc3RfcG9ydCAqcG9ydCA9IGV4ZWNsaXN0cy0+cG9ydDsKPiAg ICAgICAgIHVuc2lnbmVkIGludCBudW1fcG9ydHMgPSBleGVjbGlzdHNfbnVtX3BvcnRzKGV4ZWNs aXN0cyk7Cj4gKyAgICAgICBzdHJ1Y3QgZXhlY2xpc3RfcG9ydCAqcG9ydDsKPiArCj4gKyAgICAg ICBwb3J0ID0gZXhlY2xpc3RzX3BvcnRfaGVhZChleGVjbGlzdHMpOwo+ICAKPiAgICAgICAgIHdo aWxlIChudW1fcG9ydHMtLSAmJiBwb3J0X2lzc2V0KHBvcnQpKSB7CgoJZm9yIChwb3J0ID0gZXhl Y2xpc3RzX3BvcnRfaGVhZChleGVjbGlzdHMpOwoJICAgICBudW1fcG9ydHMtLSAmJiBwb3J0X2lz c2V0KHBvcnQpOwoJICAgICBwb3J0ID0gZXhlY2xpc3RzX2hlYWRfY29tcGxldGUoZXhlY2xpc3Rz LCBwb3J0KSkgewoKTWlnaHQgYXMgd2VsbCBjb21wbGV0ZSB0aGUgdHJhbnNmb3JtYXRpb24gdG8g bW9yZSBub3JtYWwgY29kZSA7KQoKPiArc3RhdGljIGlubGluZSBzdHJ1Y3QgZXhlY2xpc3RfcG9y dCAqCj4gK2V4ZWNsaXN0c19oZWFkX2NvbXBsZXRlKHN0cnVjdCBpbnRlbF9lbmdpbmVfZXhlY2xp c3RzICogY29uc3QgZXhlY2xpc3RzLAo+ICAgICAgICAgICAgICAgICAgICAgICAgIHN0cnVjdCBl eGVjbGlzdF9wb3J0ICogY29uc3QgcG9ydCkKPiAgewo+ICAgICAgICAgY29uc3QgdW5zaWduZWQg aW50IG0gPSBleGVjbGlzdHMtPnBvcnRfbWFzazsKPiBAQCAtNTgwLDYgKzYxOCw4IEBAIGV4ZWNs aXN0c19wb3J0X2NvbXBsZXRlKHN0cnVjdCBpbnRlbF9lbmdpbmVfZXhlY2xpc3RzICogY29uc3Qg ZXhlY2xpc3RzLAo+ICAKPiAgICAgICAgIG1lbW1vdmUocG9ydCwgcG9ydCArIDEsIG0gKiBzaXpl b2Yoc3RydWN0IGV4ZWNsaXN0X3BvcnQpKTsKPiAgICAgICAgIG1lbXNldChwb3J0ICsgbSwgMCwg c2l6ZW9mKHN0cnVjdCBleGVjbGlzdF9wb3J0KSk7Cj4gKwo+ICsgICAgICAgcmV0dXJuIGV4ZWNs aXN0c19wb3J0X2hlYWQoZXhlY2xpc3RzKTsKCkhhbmcgb24gYSBzZWMsIGlzbid0IHBvcnQtPmhl YWQgaXRzZWxmIG1lYW50IHRvIGFkdmFuY2UgaGVyZT8gT2gsCnRoYXQnbGwgYmUgdGhlIG5leHQg cGF0Y2ggYW5kIHRoaXMgaXMganVzdCBwcmVwLgoKUmV2aWV3ZWQtYnk6IENocmlzIFdpbHNvbiA8 Y2hyaXNAY2hyaXMtd2lsc29uLmNvLnVrPgotQ2hyaXMKX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX18KSW50ZWwtZ2Z4IG1haWxpbmcgbGlzdApJbnRlbC1nZnhA bGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHBzOi8vbGlzdHMuZnJlZWRlc2t0b3Aub3JnL21haWxt YW4vbGlzdGluZm8vaW50ZWwtZ2Z4Cg==