From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933739AbdKCUJ4 (ORCPT ); Fri, 3 Nov 2017 16:09:56 -0400 Received: from esa5.hgst.iphmx.com ([216.71.153.144]:38026 "EHLO esa5.hgst.iphmx.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932280AbdKCUJx (ORCPT ); Fri, 3 Nov 2017 16:09:53 -0400 X-IronPort-AV: E=Sophos;i="5.44,339,1505750400"; d="scan'208";a="61115147" From: Bart Van Assche To: "yang.s@alibaba-inc.com" , "akpm@linux-foundation.org" CC: "joe@perches.com" , "linux-kernel@vger.kernel.org" , "linux-mm@kvack.org" , "mhocko@kernel.org" , "mingo@redhat.com" Subject: Re: [PATCH] mm: use in_atomic() in print_vma_addr() Thread-Topic: [PATCH] mm: use in_atomic() in print_vma_addr() Thread-Index: AQHTU1nXg4zbvvRS0ky9Dp449q994qMAudMAgACkAgCAAZddgIAAI30A Date: Fri, 3 Nov 2017 20:09:49 +0000 Message-ID: <1509739786.2473.33.camel@wdc.com> References: <1509572313-102989-1-git-send-email-yang.s@alibaba-inc.com> <20171102075744.whhxjmqbdkfaxghd@dhcp22.suse.cz> <20171103110245.7049460a05cc18c7e8a9feb2@linux-foundation.org> In-Reply-To: <20171103110245.7049460a05cc18c7e8a9feb2@linux-foundation.org> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: spf=none (sender IP is ) smtp.mailfrom=Bart.VanAssche@wdc.com; x-originating-ip: [63.163.107.100] x-ms-publictraffictype: Email x-microsoft-exchange-diagnostics: 1;CY1PR0401MB1535;20:o/YhWUaB4M231vMigjYKStn5rG8m4tFoeTGUkShqB3V+wKSyQ3OGih+u+8OBN3cyMwdn6ileeDslpNjA5gm9uTk3saFa6tpf0VQIvPV9MogxOMzkFFrdCddN1xtUjQFo9W+zgWRhJ8AiREJeDr01uJguqgYQPu1kwsPint6NOG4= x-ms-exchange-antispam-srfa-diagnostics: SSOS; x-ms-office365-filtering-correlation-id: 934649f7-68a4-4a42-7a80-08d522f6d62f x-ms-office365-filtering-ht: Tenant x-microsoft-antispam: UriScan:;BCL:0;PCL:0;RULEID:(22001)(4534020)(4602075)(4627115)(201703031133081)(201702281549075)(48565401081)(2017052603199);SRVR:CY1PR0401MB1535; x-ms-traffictypediagnostic: CY1PR0401MB1535: wdcipoutbound: EOP-TRUE x-exchange-antispam-report-test: UriScan:; x-microsoft-antispam-prvs: x-exchange-antispam-report-cfa-test: BCL:0;PCL:0;RULEID:(100000700101)(100105000095)(100000701101)(100105300095)(100000702101)(100105100095)(6040450)(2401047)(5005006)(8121501046)(93006095)(93001095)(3231021)(100000703101)(100105400095)(3002001)(10201501046)(6055026)(6041248)(20161123558100)(201703131423075)(201702281528075)(201703061421075)(201703061406153)(20161123555025)(20161123560025)(20161123562025)(20161123564025)(6072148)(201708071742011)(100000704101)(100105200095)(100000705101)(100105500095);SRVR:CY1PR0401MB1535;BCL:0;PCL:0;RULEID:(100000800101)(100110000095)(100000801101)(100110300095)(100000802101)(100110100095)(100000803101)(100110400095)(100000804101)(100110200095)(100000805101)(100110500095);SRVR:CY1PR0401MB1535; x-forefront-prvs: 0480A51D4A x-forefront-antispam-report: SFV:NSPM;SFS:(10019020)(6009001)(39860400002)(346002)(376002)(189002)(377424004)(199003)(24454002)(2906002)(2501003)(14454004)(93886005)(101416001)(103116003)(53936002)(76176999)(54356999)(66066001)(50986999)(5660300001)(72206003)(33646002)(105586002)(106356001)(3660700001)(2950100002)(36756003)(97736004)(3280700002)(478600001)(2900100001)(305945005)(7736002)(4326008)(68736007)(86362001)(81156014)(8936002)(81166006)(8676002)(6436002)(102836003)(6116002)(189998001)(3846002)(229853002)(6486002)(6246003)(77096006)(316002)(6506006)(110136005)(25786009)(54906003)(99286004)(6512007);DIR:OUT;SFP:1102;SCL:1;SRVR:CY1PR0401MB1535;H:CY1PR0401MB1536.namprd04.prod.outlook.com;FPR:;SPF:None;PTR:InfoNoRecords;MX:1;A:1;LANG:en; spamdiagnosticoutput: 1:99 spamdiagnosticmetadata: NSPM Content-Type: text/plain; charset="utf-8" Content-ID: <705B0B1A9A19B64DB2B2837224F4A43C@namprd04.prod.outlook.com> MIME-Version: 1.0 X-OriginatorOrg: wdc.com X-MS-Exchange-CrossTenant-Network-Message-Id: 934649f7-68a4-4a42-7a80-08d522f6d62f X-MS-Exchange-CrossTenant-originalarrivaltime: 03 Nov 2017 20:09:49.1809 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: b61c8803-16f3-4c35-9b17-6f65f441df86 X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY1PR0401MB1535 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Transfer-Encoding: 8bit X-MIME-Autoconverted: from base64 to 8bit by nfs id vA3K9xu5009537 On Fri, 2017-11-03 at 11:02 -0700, Andrew Morton wrote: > Also, checkpatch says > > WARNING: use of in_atomic() is incorrect outside core kernel code > #43: FILE: mm/memory.c:4491: > + if (in_atomic()) > > I don't recall why we did that, but perhaps this should be revisited? Is the comment above in_atomic() still up-to-date? From : /* * Are we running in atomic context? WARNING: this macro cannot * always detect atomic context; in particular, it cannot know about * held spinlocks in non-preemptible kernels. Thus it should not be * used in the general case to determine whether sleeping is possible. * Do not use in_atomic() in driver code. */ #define in_atomic() (preempt_count() != 0) Bart. From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pg0-f69.google.com (mail-pg0-f69.google.com [74.125.83.69]) by kanga.kvack.org (Postfix) with ESMTP id 5574D6B025F for ; Fri, 3 Nov 2017 16:09:54 -0400 (EDT) Received: by mail-pg0-f69.google.com with SMTP id b192so4527904pga.14 for ; Fri, 03 Nov 2017 13:09:54 -0700 (PDT) Received: from esa5.hgst.iphmx.com (esa5.hgst.iphmx.com. [216.71.153.144]) by mx.google.com with ESMTPS id j13si6758807pgf.700.2017.11.03.13.09.53 for (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Fri, 03 Nov 2017 13:09:53 -0700 (PDT) From: Bart Van Assche Subject: Re: [PATCH] mm: use in_atomic() in print_vma_addr() Date: Fri, 3 Nov 2017 20:09:49 +0000 Message-ID: <1509739786.2473.33.camel@wdc.com> References: <1509572313-102989-1-git-send-email-yang.s@alibaba-inc.com> <20171102075744.whhxjmqbdkfaxghd@dhcp22.suse.cz> <20171103110245.7049460a05cc18c7e8a9feb2@linux-foundation.org> In-Reply-To: <20171103110245.7049460a05cc18c7e8a9feb2@linux-foundation.org> Content-Language: en-US Content-Type: text/plain; charset="utf-8" Content-ID: <705B0B1A9A19B64DB2B2837224F4A43C@namprd04.prod.outlook.com> Content-Transfer-Encoding: base64 MIME-Version: 1.0 Sender: owner-linux-mm@kvack.org List-ID: To: "yang.s@alibaba-inc.com" , "akpm@linux-foundation.org" Cc: "joe@perches.com" , "linux-kernel@vger.kernel.org" , "linux-mm@kvack.org" , "mhocko@kernel.org" , "mingo@redhat.com" T24gRnJpLCAyMDE3LTExLTAzIGF0IDExOjAyIC0wNzAwLCBBbmRyZXcgTW9ydG9uIHdyb3RlOg0K PiBBbHNvLCBjaGVja3BhdGNoIHNheXMNCj4gDQo+IFdBUk5JTkc6IHVzZSBvZiBpbl9hdG9taWMo KSBpcyBpbmNvcnJlY3Qgb3V0c2lkZSBjb3JlIGtlcm5lbCBjb2RlDQo+ICM0MzogRklMRTogbW0v bWVtb3J5LmM6NDQ5MToNCj4gKyAgICAgICBpZiAoaW5fYXRvbWljKCkpDQo+IA0KPiBJIGRvbid0 IHJlY2FsbCB3aHkgd2UgZGlkIHRoYXQsIGJ1dCBwZXJoYXBzIHRoaXMgc2hvdWxkIGJlIHJldmlz aXRlZD8NCg0KSXMgdGhlIGNvbW1lbnQgYWJvdmUgaW5fYXRvbWljKCkgc3RpbGwgdXAtdG8tZGF0 ZT8gRnJvbSA8bGludXgvcHJlZW1wdC5oPjoNCg0KLyoNCiAqIEFyZSB3ZSBydW5uaW5nIGluIGF0 b21pYyBjb250ZXh0PyAgV0FSTklORzogdGhpcyBtYWNybyBjYW5ub3QNCiAqIGFsd2F5cyBkZXRl Y3QgYXRvbWljIGNvbnRleHQ7IGluIHBhcnRpY3VsYXIsIGl0IGNhbm5vdCBrbm93IGFib3V0DQog KiBoZWxkIHNwaW5sb2NrcyBpbiBub24tcHJlZW1wdGlibGUga2VybmVscy4gIFRodXMgaXQgc2hv dWxkIG5vdCBiZQ0KICogdXNlZCBpbiB0aGUgZ2VuZXJhbCBjYXNlIHRvIGRldGVybWluZSB3aGV0 aGVyIHNsZWVwaW5nIGlzIHBvc3NpYmxlLg0KICogRG8gbm90IHVzZSBpbl9hdG9taWMoKSBpbiBk cml2ZXIgY29kZS4NCiAqLw0KI2RlZmluZSBpbl9hdG9taWMoKQkocHJlZW1wdF9jb3VudCgpICE9 IDApDQoNCkJhcnQu -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org