From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752709AbdKFJFp (ORCPT ); Mon, 6 Nov 2017 04:05:45 -0500 Received: from mx1.redhat.com ([209.132.183.28]:43252 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752440AbdKFJFl (ORCPT ); Mon, 6 Nov 2017 04:05:41 -0500 DMARC-Filter: OpenDMARC Filter v1.3.2 mx1.redhat.com 94580329E Authentication-Results: ext-mx05.extmail.prod.ext.phx2.redhat.com; dmarc=none (p=none dis=none) header.from=redhat.com Authentication-Results: ext-mx05.extmail.prod.ext.phx2.redhat.com; spf=fail smtp.mailfrom=kraxel@redhat.com Message-ID: <1509959134.30277.6.camel@redhat.com> Subject: Re: [PATCH v16 5/6] vfio: ABI for mdev display dma-buf operation From: Gerd Hoffmann To: "Zhang, Tina" , Alex Williamson Cc: "Tian, Kevin" , Daniel Vetter , "intel-gfx@lists.freedesktop.org" , "joonas.lahtinen@linux.intel.com" , "linux-kernel@vger.kernel.org" , "zhenyuw@linux.intel.com" , "chris@chris-wilson.co.uk" , "kwankhede@nvidia.com" , "Lv, Zhiyuan" , "daniel@ffwll.ch" , "intel-gvt-dev@lists.freedesktop.org" , "Wang, Zhi A" Date: Mon, 06 Nov 2017 10:05:34 +0100 In-Reply-To: <237F54289DF84E4997F34151298ABEBC7C62533C@SHSMSX101.ccr.corp.intel.com> References: <1509934758-5003-1-git-send-email-tina.zhang@intel.com> <1509934758-5003-6-git-send-email-tina.zhang@intel.com> <20171105193922.5dc9356a@t450s.home> <237F54289DF84E4997F34151298ABEBC7C62533C@SHSMSX101.ccr.corp.intel.com> Content-Type: text/plain; charset="UTF-8" Mime-Version: 1.0 Content-Transfer-Encoding: 8bit X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.29]); Mon, 06 Nov 2017 09:05:40 +0000 (UTC) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi, > > I thought we had agreed to make this behave similar to > > VFIO_GROUP_GET_DEVICE_FD, the ioctl would take a __u32 dmabuf_id > > and > > return the file descriptor as the ioctl return value.  Thanks, > > If we follow VFIO_GROUP_GET_DEVICE_FD, we would lose flags > functionality. > Zhi and Zhenyu, how do you think about it? The ioctl is simple enough that not having flags should not be a problem I think. Also note that dmabuf_id is received using the PLANE_INFO ioctl, so should the need arise to negotiate something in the future chances are high that it can be done using the PLANE_INFO ioctl flags. cheers, Gerd From mboxrd@z Thu Jan 1 00:00:00 1970 From: Gerd Hoffmann Subject: Re: [PATCH v16 5/6] vfio: ABI for mdev display dma-buf operation Date: Mon, 06 Nov 2017 10:05:34 +0100 Message-ID: <1509959134.30277.6.camel@redhat.com> References: <1509934758-5003-1-git-send-email-tina.zhang@intel.com> <1509934758-5003-6-git-send-email-tina.zhang@intel.com> <20171105193922.5dc9356a@t450s.home> <237F54289DF84E4997F34151298ABEBC7C62533C@SHSMSX101.ccr.corp.intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: In-Reply-To: <237F54289DF84E4997F34151298ABEBC7C62533C@SHSMSX101.ccr.corp.intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: "Zhang, Tina" , Alex Williamson Cc: Daniel Vetter , "intel-gfx@lists.freedesktop.org" , "linux-kernel@vger.kernel.org" , "kwankhede@nvidia.com" , "Lv, Zhiyuan" , "intel-gvt-dev@lists.freedesktop.org" List-Id: intel-gfx@lists.freedesktop.org ICBIaSwKCj4gPiBJIHRob3VnaHQgd2UgaGFkIGFncmVlZCB0byBtYWtlIHRoaXMgYmVoYXZlIHNp bWlsYXIgdG8KPiA+IFZGSU9fR1JPVVBfR0VUX0RFVklDRV9GRCwgdGhlIGlvY3RsIHdvdWxkIHRh a2UgYSBfX3UzMiBkbWFidWZfaWQKPiA+IGFuZAo+ID4gcmV0dXJuIHRoZSBmaWxlIGRlc2NyaXB0 b3IgYXMgdGhlIGlvY3RsIHJldHVybiB2YWx1ZS7CoMKgVGhhbmtzLAo+IAo+IElmIHdlIGZvbGxv dyBWRklPX0dST1VQX0dFVF9ERVZJQ0VfRkQsIHdlIHdvdWxkIGxvc2UgZmxhZ3MKPiBmdW5jdGlv bmFsaXR5Lgo+IFpoaSBhbmQgWmhlbnl1LCBob3cgZG8geW91IHRoaW5rIGFib3V0IGl0PwoKVGhl IGlvY3RsIGlzIHNpbXBsZSBlbm91Z2ggdGhhdCBub3QgaGF2aW5nIGZsYWdzIHNob3VsZCBub3Qg YmUgYQpwcm9ibGVtIEkgdGhpbmsuCgpBbHNvIG5vdGUgdGhhdCBkbWFidWZfaWQgaXMgcmVjZWl2 ZWQgdXNpbmcgdGhlIFBMQU5FX0lORk8gaW9jdGwsIHNvCnNob3VsZCB0aGUgbmVlZCBhcmlzZSB0 byBuZWdvdGlhdGUgc29tZXRoaW5nIGluIHRoZSBmdXR1cmUgY2hhbmNlcyBhcmUKaGlnaCB0aGF0 IGl0IGNhbiBiZSBkb25lIHVzaW5nIHRoZSBQTEFORV9JTkZPIGlvY3RsIGZsYWdzLgoKY2hlZXJz LAogIEdlcmQKCl9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f CkludGVsLWdmeCBtYWlsaW5nIGxpc3QKSW50ZWwtZ2Z4QGxpc3RzLmZyZWVkZXNrdG9wLm9yZwpo dHRwczovL2xpc3RzLmZyZWVkZXNrdG9wLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2ludGVsLWdmeAo=