From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932669AbdKGILM (ORCPT ); Tue, 7 Nov 2017 03:11:12 -0500 Received: from conuserg-09.nifty.com ([210.131.2.76]:24938 "EHLO conuserg-09.nifty.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932539AbdKGIKz (ORCPT ); Tue, 7 Nov 2017 03:10:55 -0500 DKIM-Filter: OpenDKIM Filter v2.10.3 conuserg-09.nifty.com vA789u4J027191 X-Nifty-SrcIP: [153.142.97.92] From: Masahiro Yamada To: Wolfram Sang , linux-mmc@vger.kernel.org Cc: Simon Horman , Yoshihiro Shimoda , Masahiro Yamada , linux-kernel@vger.kernel.org, Ulf Hansson Subject: [PATCH 1/6] mmc: renesas_sdhc: remove eprobe jump label Date: Tue, 7 Nov 2017 17:09:27 +0900 Message-Id: <1510042172-27220-2-git-send-email-yamada.masahiro@socionext.com> X-Mailer: git-send-email 2.7.4 In-Reply-To: <1510042172-27220-1-git-send-email-yamada.masahiro@socionext.com> References: <1510042172-27220-1-git-send-email-yamada.masahiro@socionext.com> Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org "goto eprobe" does nothing useful. Return directly. Signed-off-by: Masahiro Yamada --- drivers/mmc/host/renesas_sdhi_core.c | 13 +++++-------- 1 file changed, 5 insertions(+), 8 deletions(-) diff --git a/drivers/mmc/host/renesas_sdhi_core.c b/drivers/mmc/host/renesas_sdhi_core.c index fcf7235..4b7a4e2 100644 --- a/drivers/mmc/host/renesas_sdhi_core.c +++ b/drivers/mmc/host/renesas_sdhi_core.c @@ -495,9 +495,8 @@ int renesas_sdhi_probe(struct platform_device *pdev, priv->clk = devm_clk_get(&pdev->dev, NULL); if (IS_ERR(priv->clk)) { - ret = PTR_ERR(priv->clk); - dev_err(&pdev->dev, "cannot get clock: %d\n", ret); - goto eprobe; + dev_err(&pdev->dev, "cannot get clock\n"); + return PTR_ERR(priv->clk); } /* @@ -524,10 +523,8 @@ int renesas_sdhi_probe(struct platform_device *pdev, } host = tmio_mmc_host_alloc(pdev); - if (!host) { - ret = -ENOMEM; - goto eprobe; - } + if (!host) + return -ENOMEM; if (of_data) { mmc_data->flags |= of_data->tmio_flags; @@ -652,7 +649,7 @@ int renesas_sdhi_probe(struct platform_device *pdev, tmio_mmc_host_remove(host); efree: tmio_mmc_host_free(host); -eprobe: + return ret; } EXPORT_SYMBOL_GPL(renesas_sdhi_probe); -- 2.7.4