From: Ophir Munk <ophirmu@mellanox.com>
To: Jingjing Wu <jingjing.wu@intel.com>
Cc: Gaetan Rivet <gaetan.rivet@6wind.com>,
<Ophir Munk <ophirmu@mellanox.com>,
dev@dpdk.org, Thomas Monjalon <thomas@monjalon.net>,
Olga Shern <olgas@mellanox.com>,
stable@dpdk.org, Raslan Darawsheh <rasland@mellanox.com>
Subject: [PATCH v2] app/testpmd: fix forwarding between non consecutive ports
Date: Tue, 7 Nov 2017 13:31:48 +0000 [thread overview]
Message-ID: <1510061508-28196-1-git-send-email-ophirmu@mellanox.com> (raw)
In-Reply-To: <1509977954-4333-1-git-send-email-ophirmu@mellanox.com>
When defining two failsafe devices in testpmd the port numbers of the
failsafe devices may not be consecutive.
For example: if failsafe device includes a PCI device and a TAP device
then failsafe port numbers would be 0 and 3.
Port 0 - failsafe #1 device
Port 1 - PCI #1 device
Port 2 - TAP #1 device
Port 3 - failsafe #2 device
Port 4 - PCI #2 device
Port 5 - TAP #2 device
If forwarding is defined between the failsafe devices including a peer
address the forwarding should be between peer addresses of ports 0
and 3. Instead testpmd establishes forwarding between peer addresses
of consecutive ports 0 and 1. This commit fixes this bug.
Fixes: af75078fece3 ("first public release")
Cc: stable@dpdk.org
Signed-off-by: Ophir Munk <ophirmu@mellanox.com>
Signed-off-by: Raslan Darawsheh <rasland@mellanox.com>
---
v1:
=========
original patch
v2:
========
Update commit message. Update title to indicate the fix is for any non
consecutive ports and not just for failsafe devices.
---
app/test-pmd/config.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/app/test-pmd/config.c b/app/test-pmd/config.c
index 7bc721f..cd2ac11 100644
--- a/app/test-pmd/config.c
+++ b/app/test-pmd/config.c
@@ -1905,7 +1905,7 @@ simple_fwd_config_setup(void)
fwd_streams[i]->rx_queue = 0;
fwd_streams[i]->tx_port = fwd_ports_ids[j];
fwd_streams[i]->tx_queue = 0;
- fwd_streams[i]->peer_addr = j;
+ fwd_streams[i]->peer_addr = fwd_streams[i]->tx_port;
fwd_streams[i]->retry_enabled = retry_enabled;
if (port_topology == PORT_TOPOLOGY_PAIRED) {
@@ -1913,7 +1913,7 @@ simple_fwd_config_setup(void)
fwd_streams[j]->rx_queue = 0;
fwd_streams[j]->tx_port = fwd_ports_ids[i];
fwd_streams[j]->tx_queue = 0;
- fwd_streams[j]->peer_addr = i;
+ fwd_streams[j]->peer_addr = fwd_streams[j]->tx_port;
fwd_streams[j]->retry_enabled = retry_enabled;
}
}
--
2.7.4
next prev parent reply other threads:[~2017-11-07 13:31 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-11-06 14:19 [PATCH v1] app/testpmd: fix fwd between two failsafe devices Ophir Munk
2017-11-07 13:31 ` Ophir Munk [this message]
2017-11-07 13:47 ` [PATCH v2] app/testpmd: fix forwarding between non consecutive ports Ophir Munk
2017-11-07 13:52 ` Ophir Munk
2017-11-07 14:26 ` [dpdk-stable] " Thomas Monjalon
2017-11-07 17:43 ` De Lara Guarch, Pablo
2017-11-07 20:42 ` Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1510061508-28196-1-git-send-email-ophirmu@mellanox.com \
--to=ophirmu@mellanox.com \
--cc=gaetan.rivet@6wind.com \
--cc=jingjing.wu@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.