From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757813AbdKGQDb (ORCPT ); Tue, 7 Nov 2017 11:03:31 -0500 Received: from smtprelay0210.hostedemail.com ([216.40.44.210]:36779 "EHLO smtprelay.hostedemail.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1757570AbdKGQDa (ORCPT ); Tue, 7 Nov 2017 11:03:30 -0500 X-Session-Marker: 6A6F6540706572636865732E636F6D X-Spam-Summary: 2,0,0,,d41d8cd98f00b204,joe@perches.com,:::::,RULES_HIT:41:355:379:541:599:988:989:1260:1277:1311:1313:1314:1345:1359:1373:1437:1515:1516:1518:1534:1539:1593:1594:1711:1730:1747:1777:1792:2393:2559:2562:2691:2693:2828:3138:3139:3140:3141:3142:3352:3622:3865:3866:3867:3868:3870:3871:3872:3873:3874:4250:4321:5007:6119:7903:10004:10400:10848:11026:11232:11658:11914:12740:12760:12895:13069:13138:13231:13311:13357:13439:14659:14721:21080:21451:21627:30034:30054:30091,0,RBL:none,CacheIP:none,Bayesian:0.5,0.5,0.5,Netcheck:none,DomainCache:0,MSF:not bulk,SPF:,MSBL:0,DNSBL:none,Custom_rules:0:0:0,LFtime:2,LUA_SUMMARY:none X-HE-Tag: cows39_589655b99ae4d X-Filterd-Recvd-Size: 1695 Message-ID: <1510070607.1000.23.camel@perches.com> Subject: Re: [PATCH] mm/page_alloc: Avoid KERN_CONT uses in warn_alloc From: Joe Perches To: Michal Hocko Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org Date: Tue, 07 Nov 2017 08:03:27 -0800 In-Reply-To: <20171107154351.ebtitvjyo5v3bt26@dhcp22.suse.cz> References: <20171107125055.cl5pyp2zwon44x5l@dhcp22.suse.cz> <1510068865.1000.19.camel@perches.com> <20171107154351.ebtitvjyo5v3bt26@dhcp22.suse.cz> Content-Type: text/plain; charset="ISO-8859-1" X-Mailer: Evolution 3.26.1-1 Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, 2017-11-07 at 16:43 +0100, Michal Hocko wrote: > On Tue 07-11-17 07:34:25, Joe Perches wrote: [] > > I believe, but have not tested, that using a specific width > > as an argument to %*pb[l] will constrain the number of > > spaces before the '(null)' output in any NULL pointer use. > > > > So how about a #define like > > > > /* > > * nodemask_pr_args is only used with a "%*pb[l]" format for a nodemask. > > * A NULL nodemask uses 6 to emit "(null)" without leading spaces. > > */ > > #define nodemask_pr_args(maskp) \ > > (maskp) ? MAX_NUMNODES : 6, \ > > (maskp) ? (maskp)->bits : NULL > > Why not -1 then? I believe it's the field width and not the precision that needs to be set. But if you test it and it works, then that's fine by me. From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-io0-f198.google.com (mail-io0-f198.google.com [209.85.223.198]) by kanga.kvack.org (Postfix) with ESMTP id 4AFFA28026B for ; Tue, 7 Nov 2017 11:03:31 -0500 (EST) Received: by mail-io0-f198.google.com with SMTP id 189so2672875iow.14 for ; Tue, 07 Nov 2017 08:03:31 -0800 (PST) Received: from smtprelay.hostedemail.com (smtprelay0089.hostedemail.com. [216.40.44.89]) by mx.google.com with ESMTPS id 6si1561601itv.66.2017.11.07.08.03.30 for (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 07 Nov 2017 08:03:30 -0800 (PST) Message-ID: <1510070607.1000.23.camel@perches.com> Subject: Re: [PATCH] mm/page_alloc: Avoid KERN_CONT uses in warn_alloc From: Joe Perches Date: Tue, 07 Nov 2017 08:03:27 -0800 In-Reply-To: <20171107154351.ebtitvjyo5v3bt26@dhcp22.suse.cz> References: <20171107125055.cl5pyp2zwon44x5l@dhcp22.suse.cz> <1510068865.1000.19.camel@perches.com> <20171107154351.ebtitvjyo5v3bt26@dhcp22.suse.cz> Content-Type: text/plain; charset="ISO-8859-1" Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Sender: owner-linux-mm@kvack.org List-ID: To: Michal Hocko Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org On Tue, 2017-11-07 at 16:43 +0100, Michal Hocko wrote: > On Tue 07-11-17 07:34:25, Joe Perches wrote: [] > > I believe, but have not tested, that using a specific width > > as an argument to %*pb[l] will constrain the number of > > spaces before the '(null)' output in any NULL pointer use. > > > > So how about a #define like > > > > /* > > * nodemask_pr_args is only used with a "%*pb[l]" format for a nodemask. > > * A NULL nodemask uses 6 to emit "(null)" without leading spaces. > > */ > > #define nodemask_pr_args(maskp) \ > > (maskp) ? MAX_NUMNODES : 6, \ > > (maskp) ? (maskp)->bits : NULL > > Why not -1 then? I believe it's the field width and not the precision that needs to be set. But if you test it and it works, then that's fine by me. -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org