From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755062AbdKIOlV (ORCPT ); Thu, 9 Nov 2017 09:41:21 -0500 Received: from mailrelay1-2.pub.mailoutpod1-cph3.one.com ([46.30.212.0]:62419 "EHLO mailrelay1-2.pub.mailoutpod1-cph3.one.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753529AbdKIOlU (ORCPT ); Thu, 9 Nov 2017 09:41:20 -0500 X-HalOne-Cookie: 5e5a4fa52f4b30f3ba26e5ba3aa41665657c98df X-HalOne-ID: 0ace31f0-c55c-11e7-b91f-d0431ea8a283 From: "Ola N. Kaldestad" To: keescook@chromium.org Cc: mcgrof@kernel.org, linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org, "Ola N. Kaldestad" Subject: [PATCH] Fix code-style warning Date: Thu, 9 Nov 2017 15:40:35 +0100 Message-Id: <1510238435-1655-1-git-send-email-mail@okal.no> X-Mailer: git-send-email 2.7.4 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Removed unnecessary else block, and removed redundant return and call to kfree in if block. Signed-off-by: Ola N. Kaldestad --- kernel/sysctl.c | 8 +++----- 1 file changed, 3 insertions(+), 5 deletions(-) diff --git a/kernel/sysctl.c b/kernel/sysctl.c index d9c31bc..87fbb3e 100644 --- a/kernel/sysctl.c +++ b/kernel/sysctl.c @@ -3089,14 +3089,12 @@ int proc_do_large_bitmap(struct ctl_table *table, int write, else bitmap_copy(bitmap, tmp_bitmap, bitmap_len); } - kfree(tmp_bitmap); *lenp -= left; *ppos += *lenp; - return 0; - } else { - kfree(tmp_bitmap); - return err; } + + kfree(tmp_bitmap); + return err; } #else /* CONFIG_PROC_SYSCTL */ -- 2.7.4