From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from mail-wr0-f194.google.com ([209.85.128.194]:50864 "EHLO mail-wr0-f194.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755348AbdKIXi7 (ORCPT ); Thu, 9 Nov 2017 18:38:59 -0500 From: =?UTF-8?q?Pali=20Roh=C3=A1r?= To: Ming Lei , "Luis R. Rodriguez" , Greg Kroah-Hartman , Kalle Valo , David Gnedt , Michal Kazior , Daniel Wagner , Tony Lindgren , Sebastian Reichel , Pavel Machek , Ivaylo Dimitrov , Aaro Koskinen , Grazvydas Ignotas Cc: linux-kernel@vger.kernel.org, linux-wireless@vger.kernel.org, netdev@vger.kernel.org, =?UTF-8?q?Pali=20Roh=C3=A1r?= Subject: [PATCH v2 6/6] wl1251: Use request_firmware_prefer_user() for loading NVS calibration data Date: Fri, 10 Nov 2017 00:38:28 +0100 Message-Id: <1510270708-14377-7-git-send-email-pali.rohar@gmail.com> (sfid-20171110_003920_772263_1F41AABF) In-Reply-To: <1510270708-14377-1-git-send-email-pali.rohar@gmail.com> References: <1482598381-16513-1-git-send-email-pali.rohar@gmail.com> <1510270708-14377-1-git-send-email-pali.rohar@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Sender: linux-wireless-owner@vger.kernel.org List-ID: NVS calibration data for wl1251 are model specific. Every one device with wl1251 chip has different and calibrated in factory. Not all wl1251 chips have own EEPROM where are calibration data stored. And in that case there is no "standard" place. Every device has stored them on different place (some in rootfs file, some in dedicated nand partition, some in another proprietary structure). Kernel wl1251 driver cannot support every one different storage decided by device manufacture so it will use request_firmware_prefer_user() call for loading NVS calibration data and userspace helper will be responsible to prepare correct data. In case userspace helper fails request_firmware_prefer_user() still try to load data file directly from VFS as fallback mechanism. On Nokia N900 device, which has wl1251 chip, NVS calibration data are stored in CAL nand partition. CAL is proprietary Nokia key/value format for nand devices. With this patch it is finally possible to load correct model specific NVS calibration data for Nokia N900. Userspace tool for reading NVS calibration data on Nokia N900 is available in git repository at: https://github.com/community-ssu/wl1251-cal Signed-off-by: Pali Rohár --- drivers/net/wireless/ti/wl1251/Kconfig | 1 + drivers/net/wireless/ti/wl1251/main.c | 2 +- 2 files changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/net/wireless/ti/wl1251/Kconfig b/drivers/net/wireless/ti/wl1251/Kconfig index 7142ccf..affe154 100644 --- a/drivers/net/wireless/ti/wl1251/Kconfig +++ b/drivers/net/wireless/ti/wl1251/Kconfig @@ -2,6 +2,7 @@ config WL1251 tristate "TI wl1251 driver support" depends on MAC80211 select FW_LOADER + select FW_LOADER_USER_HELPER select CRC7 ---help--- This will enable TI wl1251 driver support. The drivers make diff --git a/drivers/net/wireless/ti/wl1251/main.c b/drivers/net/wireless/ti/wl1251/main.c index 1f423be..e9d232c 100644 --- a/drivers/net/wireless/ti/wl1251/main.c +++ b/drivers/net/wireless/ti/wl1251/main.c @@ -108,7 +108,7 @@ static int wl1251_fetch_nvs(struct wl1251 *wl) struct device *dev = wiphy_dev(wl->hw->wiphy); int ret; - ret = request_firmware(&fw, WL1251_NVS_NAME, dev); + ret = request_firmware_prefer_user(&fw, WL1251_NVS_NAME, dev); if (ret < 0) { wl1251_error("could not get nvs file: %d", ret); -- 1.7.9.5