From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753502AbcGLJvS (ORCPT ); Tue, 12 Jul 2016 05:51:18 -0400 Received: from mout.kundenserver.de ([217.72.192.73]:53444 "EHLO mout.kundenserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751887AbcGLJvQ convert rfc822-to-8bit (ORCPT ); Tue, 12 Jul 2016 05:51:16 -0400 From: Arnd Bergmann To: linux-arm-kernel@lists.infradead.org Cc: Wan Zongshun , devicetree@vger.kernel.org, jason@lakedaemon.net, Wan Zongshun , Daniel Lezcano , linux-kernel@vger.kernel.org, Russell King , p.zabel@pengutronix.de, Thomas Gleixner , linux-clk@vger.kernel.org Subject: Re: [PATCH v2 06/10] soc: Add SoC specific driver support for nuc900 Date: Tue, 12 Jul 2016 11:50:28 +0200 Message-ID: <1510379.YVtTfMI32O@wuerfel> User-Agent: KMail/5.1.3 (Linux/4.4.0-28-generic; KDE/5.18.0; x86_64; ; ) In-Reply-To: <5784B302.80307@iommu.org> References: <1468135649-19980-1-git-send-email-vw@iommu.org> <4765191.NGpMC1JR46@wuerfel> <5784B302.80307@iommu.org> MIME-Version: 1.0 Content-Transfer-Encoding: 8BIT Content-Type: text/plain; charset="UTF-8" X-Provags-ID: V03:K0:WbukrBKAqZBKbSiYtiO+ADt5DIXnOyvvoVMC+TRDxO4DrF5QdNL 4iML3jQO6QuRo+y0tN5McOzW0Z/orBQWRHX9aqmxhmNvjGwPdwtvYvBqeLYuO93Hd8AQV4Q o07CEv8QNgmIB0yjNicVbRJ13z24pfUoVtEhDwWPh6sgByvPKI6BczHcUSBLRdNHM1cYXbK oDfKpF39mf3VVwPtKvScQ== X-UI-Out-Filterresults: notjunk:1;V01:K0:6hclwMaLmEA=:EPykgmtTJIOw/hEUUs1pgD xqNtcEZo+/ctrDT/cPJ3QIfBrX4QSgO+lB3cjrdx8PBKExp+A4K53ymjmdVUslyhMu3yqbLwx pIC8SQ32d/5iQalCGFzxgEj3gaH6QeGPgy4xOXh5tYFc0sNgD6oiyASqzji/JZ0tOVLavkzKt 6QEuJyyGtkDgTbLiR91Go32AnzF6d73OFz6VcrGqvJaGar4yvtJrPd9oOoPBb/6/x5LDlpnvT H9oUgOdZfCH0JXNkFxf89FLB3ARzOTSOjtyFxztGFkjqZK7JqS9/akx9aiWrDvN5obqhx4eDD H0kBECzQ0PLOkrXqGOw+Tng5M+iprIKkAUk+AvNgkGldWXiZ3W0izWEqenHu+MHpHVVm30J9u EGULxlEYLbamm3bmcz7yZrvpiEJR8oPf0LSRmSFkhtZ/uBwdAyH8+HM4thVY2ZZqAUaflHPUg o/f08AVQKGAHLkH2J1/nn3HkAAAmhc+xB6GAMNeXtejj0orO1EhewcpnDcsM+Tn2iSbP+nCCT 1eEdugmcBC7lSYpUxPQO2F8aYBZovnucCdcEjtFC7mzQWiwg1cOMTQseGzH4PVtENjiYL7raS usYZWRGitdvHbxxliXMGgskMInejeMYcskaIzeZldF5NFULntYVVeT2zN3BGk5BoVAXiYHOCa PFFXqU/fL5QMDk97MIzbjJ5xaUM3RJaozE2CZRNEgTSViJ5ES4ui/P9ftoKQowO3tTcwWObSq /pPQlqFOv4po5FPI Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tuesday, July 12, 2016 5:06:10 PM CEST Wan Zongshun wrote: > On 2016年07月11日 16:03, Arnd Bergmann wrote: > > On Sunday, July 10, 2016 3:27:26 PM CEST Wan Zongshun wrote: > > I'm still a bit unsure about the set of attributes here. > > > > - The "soc_id" is read from the device tree from the field that contains > > the board name, I think for consistency you should try to map the > > GCR_CHIPID to the name of the SoC and assign that here > > > > - The "machine" is hardcoded to "NUC900EVB", which in turn looks like > > a particular board but not the one you are running on. Maybe read > > that from the DT instead? > > > > - The "revision" is not filled at all, I would suggest using something > > derived from the GCR_CHIPID register here > > > > - you have two nonstandard attributes "chipid" and "version", which > > I'd hope to avoid -- the set of standard attributes is supposed to > > give enough information about the machine, and platform independent > > user space will never read those. > > So, Maybe I can remove those two codes, no need push those information > to user space? > > device_create_file(soc_device_to_device(soc_dev), &nuc900_chipid_attr); > device_create_file(soc_device_to_device(soc_dev), &nuc900_version_attr); > Yes, that would be good. Arnd From mboxrd@z Thu Jan 1 00:00:00 1970 From: arnd@arndb.de (Arnd Bergmann) Date: Tue, 12 Jul 2016 11:50:28 +0200 Subject: [PATCH v2 06/10] soc: Add SoC specific driver support for nuc900 In-Reply-To: <5784B302.80307@iommu.org> References: <1468135649-19980-1-git-send-email-vw@iommu.org> <4765191.NGpMC1JR46@wuerfel> <5784B302.80307@iommu.org> Message-ID: <1510379.YVtTfMI32O@wuerfel> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On Tuesday, July 12, 2016 5:06:10 PM CEST Wan Zongshun wrote: > On 2016?07?11? 16:03, Arnd Bergmann wrote: > > On Sunday, July 10, 2016 3:27:26 PM CEST Wan Zongshun wrote: > > I'm still a bit unsure about the set of attributes here. > > > > - The "soc_id" is read from the device tree from the field that contains > > the board name, I think for consistency you should try to map the > > GCR_CHIPID to the name of the SoC and assign that here > > > > - The "machine" is hardcoded to "NUC900EVB", which in turn looks like > > a particular board but not the one you are running on. Maybe read > > that from the DT instead? > > > > - The "revision" is not filled at all, I would suggest using something > > derived from the GCR_CHIPID register here > > > > - you have two nonstandard attributes "chipid" and "version", which > > I'd hope to avoid -- the set of standard attributes is supposed to > > give enough information about the machine, and platform independent > > user space will never read those. > > So, Maybe I can remove those two codes, no need push those information > to user space? > > device_create_file(soc_device_to_device(soc_dev), &nuc900_chipid_attr); > device_create_file(soc_device_to_device(soc_dev), &nuc900_version_attr); > Yes, that would be good. Arnd