From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1750892AbdCNNpO (ORCPT ); Tue, 14 Mar 2017 09:45:14 -0400 Received: from mailout3.samsung.com ([203.254.224.33]:44643 "EHLO mailout3.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751047AbdCNNpH (ORCPT ); Tue, 14 Mar 2017 09:45:07 -0400 X-AuditID: b6c32a35-f79d66d000001a37-19-58c7f3dfd7ca From: Bartlomiej Zolnierkiewicz To: Krzysztof Kozlowski Cc: Wim Van Sebroeck , Guenter Roeck , Rob Herring , Kukjin Kim , Javier Martinez Canillas , linux-watchdog@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org Subject: Re: [PATCH v2 3/8] ARM: dts: exynos: Fix watchdog reset on Exynos4412 Date: Tue, 14 Mar 2017 14:45 +0100 Message-id: <1510739.WtREN49XT5@amdc3058> User-Agent: KMail/4.13.3 (Linux/3.13.0-96-generic; KDE/4.13.3; x86_64; ; ) In-reply-to: MIME-version: 1.0 Content-transfer-encoding: 7Bit Content-type: text/plain; charset=us-ascii X-Brightmail-Tracker: H4sIAAAAAAAAA02Se0hTcRTH+d27+3C5uk2zgzKFQYTmExKuFZZUMKJCjECEqJHXV86NTUWL SIVamvjIZbYilUptio+5zJSWzzS0aRoaUquY2Mwepq0FleR2Ffzvc875fs/h++NH4+JGwpdO zcjk1BnydCkpFHT0B4aEvF8eig9vGPBjqwcsBPvlaxPGltoWcHZsrJVijbYpgp3sukOyVWNm jH3TbKbY2dpRjL38dIBiZ6rsxIFNsql2H5nRUEjK2u9fkplK31GyJ848SrZs9I8lE4T7Ern0 1GxOHRZ9RphSV99Lqu575pjy5/A8ZPcoQh40MLthpqAB49kHxq0tZBES0mKmE4G9TkfxhRYD k2EYW3eMWVYIflCPoGzRRroGYsaBwFgDLiaZPVCuNSAXezOBMP3P6TbgzCcMHo3Ouw1eTCy0 lvTjLhYwUphsKXL3RasG29u/lIu3MUfAZNa6L3swJ6ByegTnNVvhd4VV4GKcCQDzsxsEz8Hw 8nkzch0DxkLBbO/sqoFeLSRg7MH5BIegqfID4tkLPg+ZKJ79wLAys5byJoLHf4Df047A0F22 JtoL/UOv1o5thm+OYoLfL4KrV8S8RAYj8441eQw4rG0C/rW+I5i2DpBlKEC/IYN+Qwb9hgw1 CDcgH06lUSRzmghVRKhGrtBkZSSHnlUqjMj9hYIiO5HOcrQPMTSSeopal4bixYQ8W5Or6ENA 41Jvkc2+2hIlynPPc2rlaXVWOqfpQ360QLpdRISXx4uZZHkmd47jVJx6fYrRHr55iCzpMsvv PpT8ipEUwPhiUodTf4xVRukskhdxt5aiUq5PWHRJF4Ojf1pzBusqdh48nK9YrL2wIFEWpe0q diRoJ9SekX0FD/w/2rdgYXT+yeXXrH/K4Nxsmv74NTqOCZlKUtbNDDOG24U77imd3e3JYae8 q3oaK+2q/W1xPzqrpQJNijwiCFdr5P8BxlQ23T4DAAA= X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFjrLIsWRmVeSWpSXmKPExsVy+t9jAd37n49HGBzewWMx/8g5Vos3b9cw WfQ/fs1scf78BnaLTY+vsVpc3jWHzWLG+X1MFjfW7WO3eLLwDJNF694j7Ba3ZrxgdeD2uLZZ zGPTqk42j81L6j229N9l99j5vYHd4/MmuQC2KDebjNTElNQihdS85PyUzLx0W6XQEDddCyWF vMTcVFulCF3fkCAlhbLEnFIgz8gADTg4B7gHK+nbJbhlLFt+kK1gCU/FlsZnzA2MLzi7GDk5 JARMJM6f+8cKYYtJXLi3nq2LkYtDSGApo8SGU1NZIJyvjBL/v39gBKliE7CSmNi+CswWEdCU uP73OytIEbPASyaJK88fs4MkhAX8JHZ8XwVmswgoSVxe38UGYvMCNTy+8wcsLirgJbFlXzsT iM0pECyxc+ohZhBbSGA2o8SkiXEQ9YISPybfYwGxmQXkJfbtn8oKYWtJrN95nGkCo8AsJGWz kJTNQlK2gJF5FaNEakFyQXFSeq5hXmq5XnFibnFpXrpecn7uJkZwVD6T2sF4cJf7IUYBDkYl Ht4Nn45HCLEmlhVX5h5ilOBgVhLhffwCKMSbklhZlVqUH19UmpNafIjRFOjBicxSosn5wISR VxJvaGJuYm5sYGFuaWlipCTO2zj7WbiQQHpiSWp2ampBahFMHxMHp1QD47ytiyxcWHquhpXK Z/gt2tEkd6Dt7e1patz+QnwWByVnLmX7m39txjnV7Rwe01Y93rm40GBzgXSMkszn7C+HlBI+ /Zj7f5PDkwaVniAv3Se8q59tSL0lF8I9bY9F35kSvZ2uOb++JBx6nBX8Zsv/T2uUt324Kci7 g/GL9APZvJywpNlXzqWkhiixFGckGmoxFxUnAgDCondO4AIAAA== X-MTR: 20000000000000000@CPGS X-CMS-MailID: 20170314134503epcas1p178241245d202edf9f3ea5885c605ffb6 X-Msg-Generator: CA X-Sender-IP: 203.254.230.26 X-Local-Sender: =?UTF-8?B?QmFydGxvbWllaiBab2xuaWVya2lld2ljehtTUlBPTC1LZXJu?= =?UTF-8?B?ZWwgKFRQKRvsgrzshLHsoITsnpAbU2VuaW9yIFNvZnR3YXJlIEVuZ2luZWVy?= X-Global-Sender: =?UTF-8?B?QmFydGxvbWllaiBab2xuaWVya2lld2ljehtTUlBPTC1LZXJu?= =?UTF-8?B?ZWwgKFRQKRtTYW1zdW5nIEVsZWN0cm9uaWNzG1NlbmlvciBTb2Z0d2FyZSBF?= =?UTF-8?B?bmdpbmVlcg==?= X-Sender-Code: =?UTF-8?B?QzEwG0VIURtDMTBDRDAyQ0QwMjczOTI=?= CMS-TYPE: 101P X-HopCount: 7 X-CMS-RootMailID: 20170314134503epcas1p178241245d202edf9f3ea5885c605ffb6 X-RootMTR: 20170314134503epcas1p178241245d202edf9f3ea5885c605ffb6 References: <20170311172527.16368-1-krzk@kernel.org> <6788694.7QfyuOlrPv@amdc3058> Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tuesday, March 14, 2017 03:09:25 PM Krzysztof Kozlowski wrote: > On Tue, Mar 14, 2017 at 3:03 PM, Bartlomiej Zolnierkiewicz > wrote: > > > > Hi, > > > > On Saturday, March 11, 2017 07:25:22 PM Krzysztof Kozlowski wrote: > >> The Exynos4412 has the same watchdog as newer SoCs (e.g. Exynos5250). > >> Just like the others, for working it requires additional steps in Power > >> Management Unit: unmasking the reset request and enabling the system > >> reset. Without these additional steps in PMU, the watchdog will not be > >> able to reset the system on expiration event. > >> > >> Change the compatible of Exynos4412 watchdog device node to > >> samsung,exynos5250-wdt which includes the additional PMU steps. > > > > This is going to confuse people. How's about doing it cleanly > > (by adding samsung,exynos4412-wdt compatible and convert existing > > users to use instead)? > > I don't find usage of 5250 in Exynos4412 DTS as confusing because > since long time I do not threat these numbers as having any meaning > (e.g. 3250 is newer...). Yes, we can duplicate the compatible for that > purpose. Care to send a patch for this? I don't buy this argument. The point is not in the number itself but in the fact that you as developer know than 3250 is newer than 4412 (the same way as you know that 5250 is also newer than 4412). This convention is used for all Exynos bindings so please don't break it. Best regards, -- Bartlomiej Zolnierkiewicz Samsung R&D Institute Poland Samsung Electronics From mboxrd@z Thu Jan 1 00:00:00 1970 From: Bartlomiej Zolnierkiewicz Subject: Re: [PATCH v2 3/8] ARM: dts: exynos: Fix watchdog reset on Exynos4412 Date: Tue, 14 Mar 2017 14:45 +0100 Message-ID: <1510739.WtREN49XT5@amdc3058> References: <20170311172527.16368-1-krzk@kernel.org> <6788694.7QfyuOlrPv@amdc3058> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-reply-to: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=m.gmane.org@lists.infradead.org To: Krzysztof Kozlowski Cc: linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org, linux-samsung-soc@vger.kernel.org, linux-watchdog@vger.kernel.org, linux-kernel@vger.kernel.org, Javier Martinez Canillas , Wim Van Sebroeck , Rob Herring , Kukjin Kim , Guenter Roeck List-Id: devicetree@vger.kernel.org On Tuesday, March 14, 2017 03:09:25 PM Krzysztof Kozlowski wrote: > On Tue, Mar 14, 2017 at 3:03 PM, Bartlomiej Zolnierkiewicz > wrote: > > > > Hi, > > > > On Saturday, March 11, 2017 07:25:22 PM Krzysztof Kozlowski wrote: > >> The Exynos4412 has the same watchdog as newer SoCs (e.g. Exynos5250). > >> Just like the others, for working it requires additional steps in Power > >> Management Unit: unmasking the reset request and enabling the system > >> reset. Without these additional steps in PMU, the watchdog will not be > >> able to reset the system on expiration event. > >> > >> Change the compatible of Exynos4412 watchdog device node to > >> samsung,exynos5250-wdt which includes the additional PMU steps. > > > > This is going to confuse people. How's about doing it cleanly > > (by adding samsung,exynos4412-wdt compatible and convert existing > > users to use instead)? > > I don't find usage of 5250 in Exynos4412 DTS as confusing because > since long time I do not threat these numbers as having any meaning > (e.g. 3250 is newer...). Yes, we can duplicate the compatible for that > purpose. Care to send a patch for this? I don't buy this argument. The point is not in the number itself but in the fact that you as developer know than 3250 is newer than 4412 (the same way as you know that 5250 is also newer than 4412). This convention is used for all Exynos bindings so please don't break it. Best regards, -- Bartlomiej Zolnierkiewicz Samsung R&D Institute Poland Samsung Electronics From mboxrd@z Thu Jan 1 00:00:00 1970 From: b.zolnierkie@samsung.com (Bartlomiej Zolnierkiewicz) Date: Tue, 14 Mar 2017 14:45 +0100 Subject: [PATCH v2 3/8] ARM: dts: exynos: Fix watchdog reset on Exynos4412 In-Reply-To: References: <20170311172527.16368-1-krzk@kernel.org> <6788694.7QfyuOlrPv@amdc3058> Message-ID: <1510739.WtREN49XT5@amdc3058> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On Tuesday, March 14, 2017 03:09:25 PM Krzysztof Kozlowski wrote: > On Tue, Mar 14, 2017 at 3:03 PM, Bartlomiej Zolnierkiewicz > wrote: > > > > Hi, > > > > On Saturday, March 11, 2017 07:25:22 PM Krzysztof Kozlowski wrote: > >> The Exynos4412 has the same watchdog as newer SoCs (e.g. Exynos5250). > >> Just like the others, for working it requires additional steps in Power > >> Management Unit: unmasking the reset request and enabling the system > >> reset. Without these additional steps in PMU, the watchdog will not be > >> able to reset the system on expiration event. > >> > >> Change the compatible of Exynos4412 watchdog device node to > >> samsung,exynos5250-wdt which includes the additional PMU steps. > > > > This is going to confuse people. How's about doing it cleanly > > (by adding samsung,exynos4412-wdt compatible and convert existing > > users to use instead)? > > I don't find usage of 5250 in Exynos4412 DTS as confusing because > since long time I do not threat these numbers as having any meaning > (e.g. 3250 is newer...). Yes, we can duplicate the compatible for that > purpose. Care to send a patch for this? I don't buy this argument. The point is not in the number itself but in the fact that you as developer know than 3250 is newer than 4412 (the same way as you know that 5250 is also newer than 4412). This convention is used for all Exynos bindings so please don't break it. Best regards, -- Bartlomiej Zolnierkiewicz Samsung R&D Institute Poland Samsung Electronics