All of lore.kernel.org
 help / color / mirror / Atom feed
From: Daniel Berrange <1732671@bugs.launchpad.net>
To: qemu-devel@nongnu.org
Subject: [Qemu-devel] [Bug 1732671] Re: vnc websocket compatibility issue
Date: Thu, 16 Nov 2017 11:23:39 -0000	[thread overview]
Message-ID: <151083141977.1390.1227053884336038141.malone@chaenomeles.canonical.com> (raw)
In-Reply-To: 151083063268.1193.17138246799552738242.malonedeb@chaenomeles.canonical.com

Which version of QEMU did you test this against ?  It should be fixed in
current GIT master AFAIK

-- 
You received this bug notification because you are a member of qemu-
devel-ml, which is subscribed to QEMU.
https://bugs.launchpad.net/bugs/1732671

Title:
  vnc websocket compatibility issue

Status in QEMU:
  Invalid

Bug description:
  WebSocket support in VNC should allow access from VNC client through
  upgraded WebSocket connection. This feature is not working in IE
  11/Edge with noVNC HTML5 client, in contrast to that in
  Firefox/Safari, etc.

  The reason that IE 11/Edge fails to accept the connection upgrade is
  that the value equality of the `Upgrade` header field is checked in a
  strict case-sensitive manner in QEMU side, however, the IE/Edge does
  not send the exactly same string value `websocket` but a capital
  letter `W` instead.

  Defined in section 4.2.1 of rfc6455, the upgrade header field shall be
  treated case-insensitively.

  A patch shall be made in `io/channel-websock.c`, converting the value
  of upgrade string to lowercase before comparison is made with
  QIO_CHANNEL_WEBSOCK_UPGRADE_WEBSOCKET, to allow case-insensitive
  comparison in the process.

To manage notifications about this bug go to:
https://bugs.launchpad.net/qemu/+bug/1732671/+subscriptions

  reply	other threads:[~2017-11-16 11:31 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-11-16 11:10 [Qemu-devel] [Bug 1732671] [NEW] vnc websocket compatibility issue Chen Zhang
2017-11-16 11:23 ` Daniel Berrange [this message]
2017-11-16 11:33 ` [Qemu-devel] [Bug 1732671] " Chen Zhang
2017-11-16 12:20 ` Daniel Berrange
2017-12-15 16:19 ` Thomas Huth

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=151083141977.1390.1227053884336038141.malone@chaenomeles.canonical.com \
    --to=1732671@bugs.launchpad.net \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.