From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S936249AbdKPRGA (ORCPT ); Thu, 16 Nov 2017 12:06:00 -0500 Received: from smtprelay0162.hostedemail.com ([216.40.44.162]:42639 "EHLO smtprelay.hostedemail.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S935627AbdKPRFo (ORCPT ); Thu, 16 Nov 2017 12:05:44 -0500 X-Session-Marker: 6A6F6540706572636865732E636F6D X-Spam-Summary: 2,0,0,,d41d8cd98f00b204,joe@perches.com,:::::::::::::::::,RULES_HIT:41:355:379:541:599:800:960:973:988:989:1260:1277:1311:1313:1314:1345:1359:1373:1437:1515:1516:1518:1534:1541:1593:1594:1711:1730:1747:1777:1792:2393:2553:2559:2562:2828:3138:3139:3140:3141:3142:3352:3622:3653:3865:3866:3868:3870:3871:3872:4250:4321:4605:5007:6119:10004:10400:10848:10967:11232:11658:11914:12295:12296:12740:12760:12895:13069:13149:13200:13229:13230:13311:13357:13439:14181:14659:14721:21080:21324:21451:21627:30054:30090:30091,0,RBL:none,CacheIP:none,Bayesian:0.5,0.5,0.5,Netcheck:none,DomainCache:0,MSF:not bulk,SPF:,MSBL:0,DNSBL:none,Custom_rules:0:0:0,LFtime:2,LUA_SUMMARY:none X-HE-Tag: silk66_88de75cab6e1d X-Filterd-Recvd-Size: 2475 Message-ID: <1510851938.31559.33.camel@perches.com> Subject: Re: [PATCH] tracing/probe: fix typo in pr_fmt in trace_uprobe.c From: Joe Perches To: Steven Rostedt , Michal Marek , Masahiro Yamada Cc: Masami Hiramatsu , Jiri Kosina , Song Liu , linux-kernel@vger.kernel.org, kernel-team@fb.com, trivial@kernel.org Date: Thu, 16 Nov 2017 09:05:38 -0800 In-Reply-To: <20171115215551.1afa1a8c@vmware.local.home> References: <20171113220246.4022518-1-songliubraving@fb.com> <20171114225831.4ecb6d02fc0fca718caa9f64@kernel.org> <20171115131410.13a5a4c8@vmware.local.home> <1510786519.25299.7.camel@perches.com> <20171115215551.1afa1a8c@vmware.local.home> Content-Type: text/plain; charset="ISO-8859-1" X-Mailer: Evolution 3.26.1-1 Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, 2017-11-15 at 21:55 -0500, Steven Rostedt wrote: > On Wed, 15 Nov 2017 14:55:19 -0800 > Joe Perches wrote: > > > Maybe use the much more common below instead? > > > > #define pr_fmt(fmt) KBUILD_MODNAME ": " fmt > > Is there someplace this is documented. My git grep foo isn't finding it > for me. Not so far as I know. Maybe Michal Marek or Masahiro Yamada might add some documentation in the future about these KBUILD defines. btw, there are about 1800 #define pr_fmt uses and most of them use KBUILD_MODNAME $ git grep -P "^\s*#\s*define\s+pr_fmt\b" | \ cut -f2- -d":" | \ sed -r 's/^\s*#\s*define\s+pr_fmt([^ ]+)\s++/#define pr_fmt\1 /' | \ sed -r 's/\)\s+/) /' | sort | uniq -c | sort -rn | head -10 1166 #define pr_fmt(fmt) KBUILD_MODNAME ": " fmt 134 #define pr_fmt(fmt) KMSG_COMPONENT ": " fmt 32 #define pr_fmt(fmt) "%s: " fmt, __func__ 22 #define pr_fmt(fmt) KBUILD_MODNAME ":%s: " fmt, __func__ 17 #define pr_fmt(fmt) KBUILD_MODNAME ":%s(): " fmt, __func__ 13 #define pr_fmt(fmt) "xen:" KBUILD_MODNAME ": " fmt 11 #define pr_fmt(fmt) "arcnet:" KBUILD_MODNAME ": " fmt 10 #define pr_fmt(fmt) KBUILD_MODNAME ": %s: " fmt, __func__ 10 #define pr_fmt(fmt) "IPv6: " fmt 9 #define pr_fmt(fmt) fmt