From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S936792AbdKPTfi (ORCPT ); Thu, 16 Nov 2017 14:35:38 -0500 Received: from mx0a-001b2d01.pphosted.com ([148.163.156.1]:60542 "EHLO mx0a-001b2d01.pphosted.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1759290AbdKPTfa (ORCPT ); Thu, 16 Nov 2017 14:35:30 -0500 Subject: Re: [PATCH 0/4] treewide: Fix line continuation formats From: Mimi Zohar To: Joe Perches , Chanwoo Choi , linux-pm@vger.kernel.org, linux-integrity@vger.kernel.org Cc: linux-kernel@vger.kernel.org, amd-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org, linux-media@vger.kernel.org, linux-security-module@vger.kernel.org Date: Thu, 16 Nov 2017 14:35:22 -0500 In-Reply-To: <1510852649.31559.38.camel@perches.com> References: <1510852273.3711.448.camel@linux.vnet.ibm.com> <1510852649.31559.38.camel@perches.com> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.20.5 (3.20.5-1.fc24) Mime-Version: 1.0 Content-Transfer-Encoding: 7bit X-TM-AS-GCONF: 00 x-cbid: 17111619-0016-0000-0000-000005023231 X-IBM-AV-DETECTION: SAVI=unused REMOTE=unused XFE=unused x-cbparentid: 17111619-0017-0000-0000-0000283DF286 Message-Id: <1510860922.3711.452.camel@linux.vnet.ibm.com> X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10432:,, definitions=2017-11-16_06:,, signatures=0 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 priorityscore=1501 malwarescore=0 suspectscore=3 phishscore=0 bulkscore=0 spamscore=0 clxscore=1015 lowpriorityscore=0 impostorscore=0 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1709140000 definitions=main-1711160262 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, 2017-11-16 at 09:17 -0800, Joe Perches wrote: > On Thu, 2017-11-16 at 12:11 -0500, Mimi Zohar wrote: > > On Thu, 2017-11-16 at 07:27 -0800, Joe Perches wrote: > > > Avoid using line continations in formats as that causes unexpected > > > output. > > > > Is having lines greater than 80 characters the preferred method? > > yes. > > > Could you add quotes before the backlash and before the first word on > > the next line instead? > > coalesced formats are preferred. In the future, please reference the commit 6f76b6fcaa60 "CodingStyle: Document the exception of not splitting user-visible strings, for grepping" thanks, Mimi From mboxrd@z Thu Jan 1 00:00:00 1970 From: zohar@linux.vnet.ibm.com (Mimi Zohar) Date: Thu, 16 Nov 2017 14:35:22 -0500 Subject: [PATCH 0/4] treewide: Fix line continuation formats In-Reply-To: <1510852649.31559.38.camel@perches.com> References: <1510852273.3711.448.camel@linux.vnet.ibm.com> <1510852649.31559.38.camel@perches.com> Message-ID: <1510860922.3711.452.camel@linux.vnet.ibm.com> To: linux-security-module@vger.kernel.org List-Id: linux-security-module.vger.kernel.org On Thu, 2017-11-16 at 09:17 -0800, Joe Perches wrote: > On Thu, 2017-11-16 at 12:11 -0500, Mimi Zohar wrote: > > On Thu, 2017-11-16 at 07:27 -0800, Joe Perches wrote: > > > Avoid using line continations in formats as that causes unexpected > > > output. > > > > Is having lines greater than 80 characters the preferred method? > > yes. > > > Could you add quotes before the backlash and before the first word on > > the next line instead? > > coalesced formats are preferred. In the future, please reference the commit 6f76b6fcaa60 "CodingStyle: Document the exception of not splitting user-visible strings, for grepping" thanks, Mimi -- To unsubscribe from this list: send the line "unsubscribe linux-security-module" in the body of a message to majordomo at vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html