All of lore.kernel.org
 help / color / mirror / Atom feed
From: Tom Rini <trini@konsulko.com>
To: openembedded-core@lists.openembedded.org
Subject: [PATCHv2 1/4] wic: kparser.py: Check for SquashFS and use-uuid
Date: Fri, 17 Nov 2017 11:08:17 -0500	[thread overview]
Message-ID: <1510934900-22044-2-git-send-email-trini@konsulko.com> (raw)
In-Reply-To: <1510934900-22044-1-git-send-email-trini@konsulko.com>

The SquashFS filesystem does not support UUIDs so make this combination
be an error.

Signed-off-by: Tom Rini <trini@konsulko.com>
---
 scripts/lib/wic/ksparser.py | 5 +++++
 1 file changed, 5 insertions(+)

diff --git a/scripts/lib/wic/ksparser.py b/scripts/lib/wic/ksparser.py
index 7850e81d2f37..4fb6868531df 100644
--- a/scripts/lib/wic/ksparser.py
+++ b/scripts/lib/wic/ksparser.py
@@ -195,6 +195,11 @@ class KickStart():
                         raise KickStartError('%s:%d: %s' % \
                                              (confpath, lineno, err))
                     if line.startswith('part'):
+                        # SquashFS does not support UUID
+                        if parsed.fstype == 'squashfs' and parsed.use_uuid:
+                            err = "%s:%d: SquashFS does not support UUID" \
+                                  % (confpath, lineno)
+                            raise KickStartError(err)
                         # using ArgumentParser one cannot easily tell if option
                         # was passed as argument, if said option has a default
                         # value; --overhead-factor/--extra-space cannot be used
-- 
2.7.4



  reply	other threads:[~2017-11-17 16:08 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-11-17 16:08 [PATCHv2 0/4] wic: Further enhance UUID / fstab support Tom Rini
2017-11-17 16:08 ` Tom Rini [this message]
2017-11-17 16:08 ` [PATCHv2 2/4] wic: partition.py: Update comments slightly Tom Rini
2017-11-17 16:08 ` [PATCHv2 3/4] wic: Introduce --fsuuid and have --use-uuid make use of UUID too Tom Rini
2017-11-17 16:08 ` [PATCHv2 4/4] meta-selftest: wic: Add test for --use-uuid / --fsuuid Tom Rini
2017-11-24 15:28   ` Burton, Ross
2017-11-24 15:36     ` Tom Rini
2017-11-28 15:55       ` Tom Rini
2017-12-13 14:40         ` Burton, Ross
2017-12-14  1:22           ` Tom Rini
2017-12-14  2:45           ` Tom Rini
2017-12-14  3:15             ` Tom Rini
2018-01-23 22:05               ` Khem Raj
2017-11-22  8:39 ` [PATCHv2 0/4] wic: Further enhance UUID / fstab support Ed Bartosh

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1510934900-22044-2-git-send-email-trini@konsulko.com \
    --to=trini@konsulko.com \
    --cc=openembedded-core@lists.openembedded.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.