From mboxrd@z Thu Jan  1 00:00:00 1970
From: Chris Wilson <chris@chris-wilson.co.uk>
Subject: Re: [PATCH igt 2/3] igt/perf_pmu: Stop peeking at
 intel_mmio registers
Date: Fri, 24 Nov 2017 10:47:22 +0000
Message-ID: <151152044268.9916.2307943147302672599@mail.alporthouse.com>
References: <20171123082237.9733-1-chris@chris-wilson.co.uk>
 <20171123082237.9733-3-chris@chris-wilson.co.uk>
 <b976007c-5cb9-60cd-6c9c-4ac898010a83@linux.intel.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: base64
Return-path: <intel-gfx-bounces@lists.freedesktop.org>
Received: from fireflyinternet.com (mail.fireflyinternet.com [109.228.58.192])
 by gabe.freedesktop.org (Postfix) with ESMTPS id A106F6E90B
 for <intel-gfx@lists.freedesktop.org>; Fri, 24 Nov 2017 10:47:27 +0000 (UTC)
In-Reply-To: <b976007c-5cb9-60cd-6c9c-4ac898010a83@linux.intel.com>
List-Unsubscribe: <https://lists.freedesktop.org/mailman/options/intel-gfx>,
 <mailto:intel-gfx-request@lists.freedesktop.org?subject=unsubscribe>
List-Archive: <https://lists.freedesktop.org/archives/intel-gfx>
List-Post: <mailto:intel-gfx@lists.freedesktop.org>
List-Help: <mailto:intel-gfx-request@lists.freedesktop.org?subject=help>
List-Subscribe: <https://lists.freedesktop.org/mailman/listinfo/intel-gfx>,
 <mailto:intel-gfx-request@lists.freedesktop.org?subject=subscribe>
Errors-To: intel-gfx-bounces@lists.freedesktop.org
Sender: "Intel-gfx" <intel-gfx-bounces@lists.freedesktop.org>
To: Tvrtko Ursulin <tvrtko.ursulin@linux.intel.com>, intel-gfx@lists.freedesktop.org
List-Id: intel-gfx@lists.freedesktop.org

UXVvdGluZyBUdnJ0a28gVXJzdWxpbiAoMjAxNy0xMS0yNCAwODo1NToxMykKPiAKPiBPbiAyMy8x
MS8yMDE3IDA4OjIyLCBDaHJpcyBXaWxzb24gd3JvdGU6Cj4gPiBQcm9ncmFtIHRoZSBNSV9XQUlU
X0ZPUl9FVkVOVCB3aXRob3V0IHJlZmVyZW5jZSB0byBERVJSTVIgYnkga25vd2luZyBpdHMKPiA+
IHN0YXRlIGlzIH4wdSB3aGVuIG5vdCBpbiB1c2UsIGFuZCBpcyBvbmx5IGluIHVzZSB3aGVuIHVz
ZXJzcGFjZSByZXF1aXJlcwo+ID4gaXQuIEJ5IG5vdCB0b3VjaGluZyBpbnRlbF9yZWdzaXRlcl9h
Y2Nlc3Mgd2UgY29tcGxldGVseSBlbGltaW5hdGUgdGhlCj4gPiByaXNrIHRoYXQgd2UgbGVhayB0
aGUgZm9yY2V3YWtlIHJlZiwgd2hpY2ggY2FuIGNhdXNlIGxhdGVyIHJjNiB0byBmYWlsLgo+ID4g
Cj4gPiBBdCB0aGUgc2FtZSB0aW1lLCBub3RlIHRoYXQgdmx2L2NodiB1c2UgYSBkaWZmZXJlbnQg
bWVjaGFuaXNtIChyZWFkCj4gPiBub25lKSBmb3IgY291cGxpbmcgYmV0d2VlbiB0aGUgcmVuZGVy
IGVuZ2luZSBhbmQgZGlzcGxheS4KPiA+IAo+ID4gU2lnbmVkLW9mZi1ieTogQ2hyaXMgV2lsc29u
IDxjaHJpc0BjaHJpcy13aWxzb24uY28udWs+Cj4gPiAtLS0KPiA+ICAgdGVzdHMvcGVyZl9wbXUu
YyB8IDYzICsrKysrKysrKysrKysrKysrKysrKysrKysrKystLS0tLS0tLS0tLS0tLS0tLS0tLS0t
LS0tLS0tCj4gPiAgIDEgZmlsZSBjaGFuZ2VkLCAzMiBpbnNlcnRpb25zKCspLCAzMSBkZWxldGlv
bnMoLSkKPiA+IAo+ID4gZGlmZiAtLWdpdCBhL3Rlc3RzL3BlcmZfcG11LmMgYi90ZXN0cy9wZXJm
X3BtdS5jCj4gPiBpbmRleCA1MTE4YzAyMy4uN2ZkMTUwNmUgMTAwNjQ0Cj4gPiAtLS0gYS90ZXN0
cy9wZXJmX3BtdS5jCj4gPiArKysgYi90ZXN0cy9wZXJmX3BtdS5jCj4gPiBAQCAtNDk4LDIwICs0
OTgsMjIgQEAgZXZlbnRfd2FpdChpbnQgZ2VtX2ZkLCBjb25zdCBzdHJ1Y3QgaW50ZWxfZXhlY3V0
aW9uX2VuZ2luZTIgKmUpCj4gPiAgIHsKPiA+ICAgICAgIHN0cnVjdCBkcm1faTkxNV9nZW1fZXhl
Y19vYmplY3QyIG9iaiA9IHsgfTsKPiA+ICAgICAgIHN0cnVjdCBkcm1faTkxNV9nZW1fZXhlY2J1
ZmZlcjIgZWIgPSB7IH07Cj4gPiAtICAgICBkYXRhX3QgZGF0YTsKPiA+IC0gICAgIGlndF9kaXNw
bGF5X3QgKmRpc3BsYXkgPSAmZGF0YS5kaXNwbGF5Owo+ID4gICAgICAgY29uc3QgdWludDMyX3Qg
REVSUk1SID0gMHg0NDA1MDsKPiA+ICsgICAgIGNvbnN0IHVpbnQzMl90IEZPUkNFV0FLRV9NVCA9
IDB4YTE4ODsKPiA+ICAgICAgIHVuc2lnbmVkIGludCB2YWxpZF90ZXN0cyA9IDA7Cj4gPiAtICAg
ICB1aW50MzJfdCBiYXRjaFs4XSwgKmI7Cj4gPiArICAgICB1aW50MzJfdCBiYXRjaFsxNl0sICpi
Owo+ID4gKyAgICAgdWludDE2X3QgZGV2aWQ7Cj4gPiAgICAgICBpZ3Rfb3V0cHV0X3QgKm91dHB1
dDsKPiA+IC0gICAgIHVpbnQzMl90IGJiX2hhbmRsZTsKPiA+IC0gICAgIHVpbnQzMl90IHJlZzsK
PiA+ICsgICAgIGRhdGFfdCBkYXRhOwo+ID4gICAgICAgZW51bSBwaXBlIHA7Cj4gPiAgICAgICBp
bnQgZmQ7Cj4gPiAgIAo+ID4gLSAgICAgaWd0X3JlcXVpcmUoaW50ZWxfZ2VuKGludGVsX2dldF9k
cm1fZGV2aWQoZ2VtX2ZkKSkgPj0gNik7Cj4gPiAtICAgICBpZ3RfcmVxdWlyZShpbnRlbF9yZWdp
c3Rlcl9hY2Nlc3NfaW5pdChpbnRlbF9nZXRfcGNpX2RldmljZSgpLAo+ID4gLSAgICAgICAgICAg
ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgZmFsc2UsIGdlbV9mZCkgPT0gMCk7Cj4g
PiArICAgICBkZXZpZCA9IGludGVsX2dldF9kcm1fZGV2aWQoZ2VtX2ZkKTsKPiA+ICsgICAgIGln
dF9yZXF1aXJlKGludGVsX2dlbihkZXZpZCkgPj0gNyk7Cj4gPiArICAgICBpZ3Rfc2tpcF9vbihJ
U19WQUxMRVlWSUVXKGRldmlkKSB8fCBJU19DSEVSUllWSUVXKGRldmlkKSk7Cj4gPiArCj4gPiAr
ICAgICBrbXN0ZXN0X3NldF92dF9ncmFwaGljc19tb2RlKCk7Cj4gPiArICAgICBpZ3RfZGlzcGxh
eV9pbml0KCZkYXRhLmRpc3BsYXksIGdlbV9mZCk7Cj4gPiAgIAo+ID4gICAgICAgLyoqCj4gPiAg
ICAgICAgKiBXZSB3aWxsIHVzZSB0aGUgZGlzcGxheSB0byByZW5kZXIgZXZlbnQgZm9yd2FyaW5k
IHNvIG5lZWQgdG8KPiA+IEBAIC01MjIsNTEgKzUyNCw1MiBAQCBldmVudF93YWl0KGludCBnZW1f
ZmQsIGNvbnN0IHN0cnVjdCBpbnRlbF9leGVjdXRpb25fZW5naW5lMiAqZSkKPiA+ICAgICAgICAq
IGxpc3RlbiB0byB0aGUgcmVjb3JkZWQgdGltZSBzcGVudCBpbiBlbmdpbmUgd2FpdCBzdGF0ZSBh
cyByZXBvcnRlZAo+ID4gICAgICAgICogYnkgdGhlIFBNVS4KPiA+ICAgICAgICAqLwo+ID4gLSAg
ICAgcmVnID0gaW50ZWxfcmVnaXN0ZXJfcmVhZChERVJSTVIpOwo+ID4gLQo+ID4gLSAgICAga21z
dGVzdF9zZXRfdnRfZ3JhcGhpY3NfbW9kZSgpOwo+ID4gLSAgICAgaWd0X2Rpc3BsYXlfaW5pdCgm
ZGF0YS5kaXNwbGF5LCBnZW1fZmQpOwo+ID4gLQo+ID4gLSAgICAgYmJfaGFuZGxlID0gZ2VtX2Ny
ZWF0ZShnZW1fZmQsIDQwOTYpOwo+ID4gKyAgICAgb2JqLmhhbmRsZSA9IGdlbV9jcmVhdGUoZ2Vt
X2ZkLCA0MDk2KTsKPiA+ICAgCj4gPiAgICAgICBiID0gYmF0Y2g7Cj4gPiAgICAgICAqYisrID0g
TUlfTE9BRF9SRUdJU1RFUl9JTU07Cj4gPiArICAgICAqYisrID0gRk9SQ0VXQUtFX01UOwo+ID4g
KyAgICAgKmIrKyA9IDIgPDwgMTYgfCAyOwo+ID4gKyAgICAgKmIrKyA9IE1JX0xPQURfUkVHSVNU
RVJfSU1NOwo+ID4gICAgICAgKmIrKyA9IERFUlJNUjsKPiA+IC0gICAgICpiKysgPSByZWcgJiB+
KCgxIDw8IDMpIHwgKDEgPDwgMTEpIHwgKDEgPDwgMjEpKTsKPiA+IC0gICAgICpiKysgPSBNSV9X
QUlUX0ZPUl9FVkVOVCB8IE1JX1dBSVRfRk9SX1BJUEVfQV9WQkxBTks7Cj4gPiArICAgICAqYisr
ID0gfjB1Owo+ID4gKyAgICAgKmIrKyA9IE1JX1dBSVRfRk9SX0VWRU5UOwo+ID4gICAgICAgKmIr
KyA9IE1JX0xPQURfUkVHSVNURVJfSU1NOwo+ID4gICAgICAgKmIrKyA9IERFUlJNUjsKPiA+IC0g
ICAgICpiKysgPSByZWc7Cj4gPiArICAgICAqYisrID0gfjB1Owo+ID4gKyAgICAgKmIrKyA9IE1J
X0xPQURfUkVHSVNURVJfSU1NOwo+ID4gKyAgICAgKmIrKyA9IEZPUkNFV0FLRV9NVDsKPiA+ICsg
ICAgICpiKysgPSAyIDw8IDE2Owo+ID4gICAgICAgKmIrKyA9IE1JX0JBVENIX0JVRkZFUl9FTkQ7
Cj4gPiAgIAo+ID4gLSAgICAgb2JqLmhhbmRsZSA9IGJiX2hhbmRsZTsKPiA+IC0KPiA+ICAgICAg
IGViLmJ1ZmZlcl9jb3VudCA9IDE7Cj4gPiAgICAgICBlYi5idWZmZXJzX3B0ciA9IHRvX3VzZXJf
cG9pbnRlcigmb2JqKTsKPiA+ICAgICAgIGViLmZsYWdzID0gZTJyaW5nKGdlbV9mZCwgZSkgfCBJ
OTE1X0VYRUNfU0VDVVJFOwo+ID4gICAKPiA+IC0gICAgIGZvcl9lYWNoX3BpcGVfd2l0aF92YWxp
ZF9vdXRwdXQoZGlzcGxheSwgcCwgb3V0cHV0KSB7Cj4gPiArICAgICBmb3JfZWFjaF9waXBlX3dp
dGhfdmFsaWRfb3V0cHV0KCZkYXRhLmRpc3BsYXksIHAsIG91dHB1dCkgewo+ID4gICAgICAgICAg
ICAgICBzdHJ1Y3QgaWd0X2hlbHBlcl9wcm9jZXNzIHdhaXRlciA9IHsgfTsKPiA+ICAgICAgICAg
ICAgICAgY29uc3QgdW5zaWduZWQgaW50IGZyYW1lcyA9IDM7Cj4gPiAtICAgICAgICAgICAgIHVu
c2lnbmVkIGludCBmcmFtZTsKPiA+ICAgICAgICAgICAgICAgdWludDY0X3QgdmFsWzJdOwo+ID4g
ICAKPiA+IC0gICAgICAgICAgICAgYmF0Y2hbM10gPSBNSV9XQUlUX0ZPUl9FVkVOVDsKPiA+ICsg
ICAgICAgICAgICAgYmF0Y2hbNl0gPSBNSV9XQUlUX0ZPUl9FVkVOVDsKPiA+ICAgICAgICAgICAg
ICAgc3dpdGNoIChwKSB7Cj4gPiAgICAgICAgICAgICAgIGNhc2UgUElQRV9BOgo+ID4gLSAgICAg
ICAgICAgICAgICAgICAgIGJhdGNoWzNdIHw9IE1JX1dBSVRfRk9SX1BJUEVfQV9WQkxBTks7Cj4g
PiArICAgICAgICAgICAgICAgICAgICAgYmF0Y2hbNl0gfD0gTUlfV0FJVF9GT1JfUElQRV9BX1ZC
TEFOSzsKPiA+ICsgICAgICAgICAgICAgICAgICAgICBiYXRjaFs1XSA9IH4oMSA8PCAzKTsKPiA+
ICAgICAgICAgICAgICAgICAgICAgICBicmVhazsKPiA+ICAgICAgICAgICAgICAgY2FzZSBQSVBF
X0I6Cj4gPiAtICAgICAgICAgICAgICAgICAgICAgYmF0Y2hbM10gfD0gTUlfV0FJVF9GT1JfUElQ
RV9CX1ZCTEFOSzsKPiA+ICsgICAgICAgICAgICAgICAgICAgICBiYXRjaFs2XSB8PSBNSV9XQUlU
X0ZPUl9QSVBFX0JfVkJMQU5LOwo+ID4gKyAgICAgICAgICAgICAgICAgICAgIGJhdGNoWzVdID0g
figxIDw8IDExKTsKPiA+ICAgICAgICAgICAgICAgICAgICAgICBicmVhazsKPiA+ICAgICAgICAg
ICAgICAgY2FzZSBQSVBFX0M6Cj4gPiAtICAgICAgICAgICAgICAgICAgICAgYmF0Y2hbM10gfD0g
TUlfV0FJVF9GT1JfUElQRV9DX1ZCTEFOSzsKPiA+ICsgICAgICAgICAgICAgICAgICAgICBiYXRj
aFs2XSB8PSBNSV9XQUlUX0ZPUl9QSVBFX0NfVkJMQU5LOwo+ID4gKyAgICAgICAgICAgICAgICAg
ICAgIGJhdGNoWzVdID0gfigxIDw8IDIxKTsKPiA+ICAgICAgICAgICAgICAgICAgICAgICBicmVh
azsKPiA+ICAgICAgICAgICAgICAgZGVmYXVsdDoKPiA+ICAgICAgICAgICAgICAgICAgICAgICBj
b250aW51ZTsKPiA+ICAgICAgICAgICAgICAgfQo+ID4gICAKPiA+IC0gICAgICAgICAgICAgZ2Vt
X3dyaXRlKGdlbV9mZCwgYmJfaGFuZGxlLCAwLCBiYXRjaCwgc2l6ZW9mKGJhdGNoKSk7Cj4gPiAr
ICAgICAgICAgICAgIGdlbV93cml0ZShnZW1fZmQsIG9iai5oYW5kbGUsIDAsIGJhdGNoLCBzaXpl
b2YoYmF0Y2gpKTsKPiA+ICAgCj4gPiAgICAgICAgICAgICAgIGRhdGEucGlwZSA9IHA7Cj4gPiAg
ICAgICAgICAgICAgIHByZXBhcmVfY3J0YygmZGF0YSwgZ2VtX2ZkLCBvdXRwdXQpOwo+ID4gQEAg
LTU4OSw5ICs1OTIsOSBAQCBldmVudF93YWl0KGludCBnZW1fZmQsIGNvbnN0IHN0cnVjdCBpbnRl
bF9leGVjdXRpb25fZW5naW5lMiAqZSkKPiA+ICAgICAgICAgICAgICAgICAgICAgICB9Cj4gPiAg
ICAgICAgICAgICAgIH0KPiA+ICAgCj4gPiAtICAgICAgICAgICAgIGZvciAoZnJhbWUgPSAwOyBm
cmFtZSA8IGZyYW1lczsgZnJhbWUrKykgewo+ID4gKyAgICAgICAgICAgICBmb3IgKHVuc2lnbmVk
IGludCBmcmFtZSA9IDA7IGZyYW1lIDwgZnJhbWVzOyBmcmFtZSsrKSB7Cj4gPiAgICAgICAgICAg
ICAgICAgICAgICAgZ2VtX2V4ZWNidWYoZ2VtX2ZkLCAmZWIpOwo+ID4gLSAgICAgICAgICAgICAg
ICAgICAgIGdlbV9zeW5jKGdlbV9mZCwgYmJfaGFuZGxlKTsKPiA+ICsgICAgICAgICAgICAgICAg
ICAgICBnZW1fc3luYyhnZW1fZmQsIG9iai5oYW5kbGUpOwo+ID4gICAgICAgICAgICAgICB9Cj4g
PiAgIAo+ID4gICAgICAgICAgICAgICBpZ3Rfc3RvcF9oZWxwZXIoJndhaXRlcik7Cj4gPiBAQCAt
NjA2LDkgKzYwOSw3IEBAIGV2ZW50X3dhaXQoaW50IGdlbV9mZCwgY29uc3Qgc3RydWN0IGludGVs
X2V4ZWN1dGlvbl9lbmdpbmUyICplKQo+ID4gICAgICAgICAgICAgICBpZ3RfYXNzZXJ0KHZhbFsx
XSAtIHZhbFswXSA+IDApOwo+ID4gICAgICAgfQo+ID4gICAKPiA+IC0gICAgIGdlbV9jbG9zZShn
ZW1fZmQsIGJiX2hhbmRsZSk7Cj4gPiAtCj4gPiAtICAgICBpbnRlbF9yZWdpc3Rlcl9hY2Nlc3Nf
ZmluaSgpOwo+ID4gKyAgICAgZ2VtX2Nsb3NlKGdlbV9mZCwgb2JqLmhhbmRsZSk7Cj4gPiAgIAo+
ID4gICAgICAgaWd0X3JlcXVpcmVfZih2YWxpZF90ZXN0cywKPiA+ICAgICAgICAgICAgICAgICAg
ICAgIm5vIHZhbGlkIGNydGMvY29ubmVjdG9yIGNvbWJpbmF0aW9ucyBmb3VuZFxuIik7Cj4gPiAK
PiAKPiBJdCBsb29rcyBmaW5lIGFwYXJ0IGZyb20gdGhlIGFzc3VtcHRpb24gdGhhdCBERVJSTVIg
YWx3YXlzIGhhdmUgdG8gCj4gcmVtYWluIGF0IGRlZmF1bHQgfjAuIFdvcnN0IEkgY2FuIGltYWdp
bmUgaXMgdGhhdCBpbiB0aGUgZnV0dXJlIHdlIGhhdmUgCj4gdG8gbWFrZSB0aGlzIHRlc3QgZm9y
Y2UgZGlzY29ubmVjdCBhbGwgZGlzcGxheXMsIHNob3VsZCBzb21lIG9mIHRoZSAKPiByZXNlcnZl
ZCBiaXRzIGJlIHVzZWQgZm9yIHNvbWV0aGluZyB3aGljaCB3ZSB3aWxsIGJlIHR1cm5pbmcgb24g
YnkgZGVmYXVsdC4KPiAKPiBCdXQgaW4gdGhhdCB3b3JsZCBzYW1wbGluZyBERVJSTVIgdmFsdWUg
YXQgdGVzdCBzdGFydCBpcyBhbHNvIG9ubHkgCj4gbWFyZ2luYWxseSBiZXR0ZXIuCgpBZGRlZCBh
IGNvbW1lbnQgdGhhdCBJIGFtIGxhenksIGFuZCBwdXNoZWQuIFRoYW5rcywKLUNocmlzCl9fX19f
X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fCkludGVsLWdmeCBtYWls
aW5nIGxpc3QKSW50ZWwtZ2Z4QGxpc3RzLmZyZWVkZXNrdG9wLm9yZwpodHRwczovL2xpc3RzLmZy
ZWVkZXNrdG9wLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2ludGVsLWdmeAo=