Re: [PATCH] v2: rtl8187: micro cleanup

[Hin-Tak Leung <htl10@users.sourceforge.net>]

--- On Wed, 17/2/10, Sedat Dilek <sedat.dilek@googlemail.com> wrote:

> You could be more precise on the
> commit-subject (not blaming you) next time.
> Worth reading on this topic: "On Commit Messages" [1].

Ditto. Here is the definitive recommended reading for submitting patches.
BTW, you also missed a Signed-off line.

http://linuxwireless.org/en/developers/Documentation/SubmittingPatches/sourcedoc

I think normally the v1/v2/v3 part goes into the front, e.g.
[PATCH v1] ...

Things like 'ok, sorry I tested...' should probably be in a reply to your own post, or preferably, not - you either put it in the commit message itself, or leave it out.
That's because John accepts about 40 patches per day, and git provides the facility to automatically extract patches per e-mail (for all e-mails filed into a folder, for example) - anything that requires manual editing to remove is considered undesirable. Same with the ambiguous subject line, and v3, etc. About 600(?) patches goes into each kernel releases - if ever patch comes in as 'minor clean up', 'fix one bug', 'fix intermittent crash', 'tried n times now' for the patch summary, nobody would know what goes into the kernel. :-).