From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1754038AbdK1TBD (ORCPT <rfc822;w@1wt.eu>);
        Tue, 28 Nov 2017 14:01:03 -0500
Received: from mail-wm0-f50.google.com ([74.125.82.50]:34239 "EHLO
        mail-wm0-f50.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1753560AbdK1TBA (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Tue, 28 Nov 2017 14:01:00 -0500
X-Google-Smtp-Source: AGs4zMbuFK+F0Loc02a0Ubf3KpLk6144+6PrEZozyXxcJpK/t7JFWIqLWVAt+XXFqviHwIJ5T7TIVw==
Message-ID: <1511895657.1754.40.camel@gmail.com>
Subject: Re: [PATCH 05/11] trace-cmd: Rename trace_profile() to
 trace_profile_int()
From: Vladislav Valtchev <vladislav.valtchev@gmail.com>
To: Steven Rostedt <rostedt@goodmis.org>
Cc: linux-kernel@vger.kernel.org, y.karadz@gmail.com
Date: Tue, 28 Nov 2017 21:00:57 +0200
In-Reply-To: <20171128120537.04cf379a@gandalf.local.home>
References: <20171123163335.19078-1-vladislav.valtchev@gmail.com>
         <20171123163335.19078-6-vladislav.valtchev@gmail.com>
         <20171128120537.04cf379a@gandalf.local.home>
Organization: VMware
Content-Type: text/plain; charset="UTF-8"
X-Mailer: Evolution 3.26.1-1 
Mime-Version: 1.0
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Tue, 2017-11-28 at 12:05 -0500, Steven Rostedt wrote:
> 
> Couple of things.
> 
> 1) A change like this should always be directly before the patch that
> requires it. This is patch 5, and it's not until patch 8 that this
> change is required. Please keep them next to each other. This should
> have been patch 7.
> 
> 2) trace_profile_int() is confusing. I keep thinking it's doing
> something with integers. Call it do_trace_profile().
> 

Sure, no problem.
Thanks for the review!