All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Michael S. Tsirkin" <mst@redhat.com>
To: qemu-devel@nongnu.org
Cc: Peter Maydell <peter.maydell@linaro.org>,
	Chao Gao <chao.gao@intel.com>, Lan Tianyu <tianyu.lan@intel.com>,
	Anthony PERARD <anthony.perard@citrix.com>,
	Peter Xu <peterx@redhat.com>
Subject: [Qemu-devel] [PULL 1/7] i386/msi: Correct mask of destination ID in MSI address
Date: Fri, 1 Dec 2017 19:08:39 +0200	[thread overview]
Message-ID: <1512148088-28733-2-git-send-email-mst@redhat.com> (raw)
In-Reply-To: <1512148088-28733-1-git-send-email-mst@redhat.com>

From: Chao Gao <chao.gao@intel.com>

According to SDM 10.11.1, only [19:12] bits of MSI address are
Destination ID, change the mask to avoid ambiguity for VT-d spec
has used the bit 4 to indicate a remappable interrupt request.

Signed-off-by: Chao Gao <chao.gao@intel.com>
Signed-off-by: Lan Tianyu <tianyu.lan@intel.com>
Reviewed-by: Anthony PERARD <anthony.perard@citrix.com>
Reviewed-by: Peter Xu <peterx@redhat.com>
Reviewed-by: Michael S. Tsirkin <mst@redhat.com>
Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
---
 include/hw/i386/apic-msidef.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/include/hw/i386/apic-msidef.h b/include/hw/i386/apic-msidef.h
index 8b4d4cc..420b411 100644
--- a/include/hw/i386/apic-msidef.h
+++ b/include/hw/i386/apic-msidef.h
@@ -26,6 +26,6 @@
 
 #define MSI_ADDR_DEST_ID_SHIFT          12
 #define MSI_ADDR_DEST_IDX_SHIFT         4
-#define  MSI_ADDR_DEST_ID_MASK          0x00ffff0
+#define  MSI_ADDR_DEST_ID_MASK          0x000ff000
 
 #endif /* HW_APIC_MSIDEF_H */
-- 
MST

  reply	other threads:[~2017-12-01 17:08 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-12-01 17:08 [Qemu-devel] [PULL 0/7] pc, pci, virtio: fixes for rc3 Michael S. Tsirkin
2017-12-01 17:08 ` Michael S. Tsirkin [this message]
2017-12-01 17:08 ` [Qemu-devel] [PULL 2/7] virtio: Add queue interface to restore avail index from vring used index Michael S. Tsirkin
2017-12-01 17:08 ` [Qemu-devel] [PULL 3/7] vhost: restore avail index from vring used index on disconnection Michael S. Tsirkin
2017-12-01 17:08 ` [Qemu-devel] [PULL 4/7] dump-guest-memory.py: fix No symbol "vmcoreinfo_find" Michael S. Tsirkin
2017-12-01 17:08 ` [Qemu-devel] [PULL 5/7] vhost: fix error check in vhost_verify_ring_mappings() Michael S. Tsirkin
2017-12-01 17:08 ` [Qemu-devel] [PULL 6/7] virtio: check VirtQueue Vring object is set Michael S. Tsirkin
2017-12-01 17:09 ` [Qemu-devel] [PULL 7/7] pc: fix crash on attempted cpu unplug Michael S. Tsirkin
2017-12-01 18:05 ` [Qemu-devel] [PULL 0/7] pc, pci, virtio: fixes for rc3 Peter Maydell
2017-12-03  4:56   ` Michael S. Tsirkin
2017-12-04 10:16     ` Peter Maydell
2017-12-04 17:18       ` Peter Maydell
2017-12-05  0:56       ` Michael S. Tsirkin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1512148088-28733-2-git-send-email-mst@redhat.com \
    --to=mst@redhat.com \
    --cc=anthony.perard@citrix.com \
    --cc=chao.gao@intel.com \
    --cc=peter.maydell@linaro.org \
    --cc=peterx@redhat.com \
    --cc=qemu-devel@nongnu.org \
    --cc=tianyu.lan@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.