From mboxrd@z Thu Jan  1 00:00:00 1970
From: Chris Wilson <chris@chris-wilson.co.uk>
Subject: Re: [PATCH v3 6/8] drm/i915/guc: Combine
 enable_guc_loading|submission modparams
Date: Wed, 06 Dec 2017 12:19:42 +0000
Message-ID: <151256278233.3497.17955155058827074317@mail.alporthouse.com>
References: <20171205163844.41264-1-michal.wajdeczko@intel.com>
 <20171205163844.41264-6-michal.wajdeczko@intel.com>
 <151251404165.3497.13392447974292922799@mail.alporthouse.com>
 <op.zatqrdr4xaggs7@mwajdecz-mobl1.ger.corp.intel.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: base64
Return-path: <intel-gfx-bounces@lists.freedesktop.org>
Received: from fireflyinternet.com (mail.fireflyinternet.com [109.228.58.192])
 by gabe.freedesktop.org (Postfix) with ESMTPS id 5A4606E069
 for <intel-gfx@lists.freedesktop.org>; Wed,  6 Dec 2017 12:20:01 +0000 (UTC)
In-Reply-To: <op.zatqrdr4xaggs7@mwajdecz-mobl1.ger.corp.intel.com>
List-Unsubscribe: <https://lists.freedesktop.org/mailman/options/intel-gfx>,
 <mailto:intel-gfx-request@lists.freedesktop.org?subject=unsubscribe>
List-Archive: <https://lists.freedesktop.org/archives/intel-gfx>
List-Post: <mailto:intel-gfx@lists.freedesktop.org>
List-Help: <mailto:intel-gfx-request@lists.freedesktop.org?subject=help>
List-Subscribe: <https://lists.freedesktop.org/mailman/listinfo/intel-gfx>,
 <mailto:intel-gfx-request@lists.freedesktop.org?subject=subscribe>
Errors-To: intel-gfx-bounces@lists.freedesktop.org
Sender: "Intel-gfx" <intel-gfx-bounces@lists.freedesktop.org>
To: Michal Wajdeczko <michal.wajdeczko@intel.com>, intel-gfx@lists.freedesktop.org
Cc: Sujaritha Sundaresan <sujaritha.sundaresan@intel.com>
List-Id: intel-gfx@lists.freedesktop.org

UXVvdGluZyBNaWNoYWwgV2FqZGVjemtvICgyMDE3LTEyLTA2IDEyOjEwOjE1KQo+IE9uIFR1ZSwg
MDUgRGVjIDIwMTcgMjM6NDc6MjEgKzAxMDAsIENocmlzIFdpbHNvbiAgCj4gPGNocmlzQGNocmlz
LXdpbHNvbi5jby51az4gd3JvdGU6Cj4gCj4gPiBRdW90aW5nIE1pY2hhbCBXYWpkZWN6a28gKDIw
MTctMTItMDUgMTY6Mzg6NDIpCj4gPj4gLXZvaWQgaW50ZWxfdWNfc2FuaXRpemVfb3B0aW9ucyhz
dHJ1Y3QgZHJtX2k5MTVfcHJpdmF0ZSAqZGV2X3ByaXYpCj4gPj4gK3N0YXRpYyBpbnQgX19nZXRf
cGxhdGZvcm1fZW5hYmxlX2d1YyhzdHJ1Y3QgZHJtX2k5MTVfcHJpdmF0ZSAqZGV2X3ByaXYpCj4g
Pj4gIHsKPiA+PiAtICAgICAgIGlmICghSEFTX0dVQyhkZXZfcHJpdikpIHsKPiA+PiAtICAgICAg
ICAgICAgICAgaWYgKGk5MTVfbW9kcGFyYW1zLmVuYWJsZV9ndWNfbG9hZGluZyA+IDAgfHwKPiA+
PiAtICAgICAgICAgICAgICAgICAgIGk5MTVfbW9kcGFyYW1zLmVuYWJsZV9ndWNfc3VibWlzc2lv
biA+IDApCj4gPj4gLSAgICAgICAgICAgICAgICAgICAgICAgRFJNX0lORk8oIklnbm9yaW5nIEd1
QyBvcHRpb25zLCBubyBoYXJkd2FyZVxuIik7Cj4gPj4gKyAgICAgICBzdHJ1Y3QgaW50ZWxfdWNf
ZncgKmd1Y19mdyA9ICZkZXZfcHJpdi0+Z3VjLmZ3Owo+ID4+ICsgICAgICAgc3RydWN0IGludGVs
X3VjX2Z3ICpodWNfZncgPSAmZGV2X3ByaXYtPmh1Yy5mdzsKPiA+PiArICAgICAgIGludCBlbmFi
bGVfZ3VjID0gMDsKPiA+Pgo+ID4+IC0gICAgICAgICAgICAgICBpOTE1X21vZHBhcmFtcy5lbmFi
bGVfZ3VjX2xvYWRpbmcgPSAwOwo+ID4+IC0gICAgICAgICAgICAgICBpOTE1X21vZHBhcmFtcy5l
bmFibGVfZ3VjX3N1Ym1pc3Npb24gPSAwOwo+ID4+IC0gICAgICAgICAgICAgICByZXR1cm47Cj4g
Pj4gLSAgICAgICB9Cj4gPj4gKyAgICAgICAvKiBEZWZhdWx0IGlzIHRvIGVuYWJsZSBHdUMvSHVD
IGlmIHdlIGtub3cgdGhlaXIgZmlybXdhcmVzICovCj4gPj4gKyAgICAgICBpZiAoaW50ZWxfdWNf
ZndfaXNfc2VsZWN0ZWQoZ3VjX2Z3KSkKPiA+PiArICAgICAgICAgICAgICAgZW5hYmxlX2d1YyB8
PSBFTkFCTEVfR1VDX1NVQk1JU1NJT047Cj4gPj4gKyAgICAgICBpZiAoaW50ZWxfdWNfZndfaXNf
c2VsZWN0ZWQoaHVjX2Z3KSkKPiA+PiArICAgICAgICAgICAgICAgZW5hYmxlX2d1YyB8PSBFTkFC
TEVfR1VDX0xPQURfSFVDOwo+ID4+Cj4gPj4gLSAgICAgICAvKiBBIG5lZ2F0aXZlIHZhbHVlIG1l
YW5zICJ1c2UgcGxhdGZvcm0gZGVmYXVsdCIgKi8KPiA+PiAtICAgICAgIGlmIChpOTE1X21vZHBh
cmFtcy5lbmFibGVfZ3VjX2xvYWRpbmcgPCAwKQo+ID4+IC0gICAgICAgICAgICAgICBpOTE1X21v
ZHBhcmFtcy5lbmFibGVfZ3VjX2xvYWRpbmcgPSAgCj4gPj4gSEFTX0dVQ19VQ09ERShkZXZfcHJp
dik7Cj4gPj4gKyAgICAgICAvKiBBbnkgcGxhdGZvcm0gc3BlY2lmaWMgZmluZS10dW5pbmcgY2Fu
IGJlIGRvbmUgaGVyZSAqLwo+ID4+Cj4gPj4gLSAgICAgICAvKiBWZXJpZnkgZmlybXdhcmUgdmVy
c2lvbiAqLwo+ID4+IC0gICAgICAgaWYgKGk5MTVfbW9kcGFyYW1zLmVuYWJsZV9ndWNfbG9hZGlu
Zykgewo+ID4+IC0gICAgICAgICAgICAgICBpZiAoIWludGVsX3VjX2Z3X2lzX3NlbGVjdGVkKCZk
ZXZfcHJpdi0+Z3VjLmZ3KSkKPiA+PiAtICAgICAgICAgICAgICAgICAgICAgICBpOTE1X21vZHBh
cmFtcy5lbmFibGVfZ3VjX2xvYWRpbmcgPSAwOwo+ID4+IC0gICAgICAgfQo+ID4+ICsgICAgICAg
cmV0dXJuIGVuYWJsZV9ndWM7Cj4gPj4gK30KPiA+Pgo+ID4+IC0gICAgICAgLyogQ2FuJ3QgZW5h
YmxlIGd1YyBzdWJtaXNzaW9uIHdpdGhvdXQgZ3VjIGxvYWRlZCAqLwo+ID4+IC0gICAgICAgaWYg
KCFpOTE1X21vZHBhcmFtcy5lbmFibGVfZ3VjX2xvYWRpbmcpCj4gPj4gLSAgICAgICAgICAgICAg
IGk5MTVfbW9kcGFyYW1zLmVuYWJsZV9ndWNfc3VibWlzc2lvbiA9IDA7Cj4gPj4gKy8qKgo+ID4+
ICsgKiBpbnRlbF91Y19zYW5pdGl6ZV9vcHRpb25zIC0gc2FuaXRpemUgdUMgcmVsYXRlZCBtb2Rw
YXJhbSBvcHRpb25zCj4gPj4gKyAqIEBkZXZfcHJpdjogZGV2aWNlIHByaXZhdGUKPiA+PiArICoK
PiA+PiArICogSW4gY2FzZSBvZiAiZW5hYmxlX2d1YyIgb3B0aW9uIHRoaXMgZnVuY3Rpb24gd2ls
bCBhdHRlbXB0IHRvIG1vZGlmeQo+ID4+ICsgKiBpdCBvbmx5IGlmIGl0IHdhcyBpbml0aWFsbHkg
c2V0IHRvICJhdXRvKC0xKSIuIERlZmF1bHQgdmFsdWUgZm9yICAKPiA+PiB0aGlzCj4gPj4gKyAq
IG1vZHBhcmFtIHZhcmllcyBiZXR3ZWVuIHBsYXRmb3JtcyBhbmQgaXQgaXMgaGFyZGNvZGVkIGlu
IGRyaXZlciAgCj4gPj4gY29kZS4KPiA+PiArICogQW55IG90aGVyIG1vZHBhcmFtIHZhbHVlIGlz
IG9ubHkgbW9uaXRvcmVkIGFnYWluc3QgYXZhaWxhYmlsaXR5IG9mICAKPiA+PiB0aGUKPiA+PiAr
ICogcmVsYXRlZCBoYXJkd2FyZSBvciBmaXJtd2FyZSBkZWZpbml0aW9ucy4KPiA+PiArICovCj4g
Pj4gK3ZvaWQgaW50ZWxfdWNfc2FuaXRpemVfb3B0aW9ucyhzdHJ1Y3QgZHJtX2k5MTVfcHJpdmF0
ZSAqZGV2X3ByaXYpCj4gPj4gK3sKPiA+PiArICAgICAgIHN0cnVjdCBpbnRlbF91Y19mdyAqZ3Vj
X2Z3ID0gJmRldl9wcml2LT5ndWMuZnc7Cj4gPj4gKyAgICAgICBzdHJ1Y3QgaW50ZWxfdWNfZncg
Kmh1Y19mdyA9ICZkZXZfcHJpdi0+aHVjLmZ3Owo+ID4+Cj4gPj4gICAgICAgICAvKiBBIG5lZ2F0
aXZlIHZhbHVlIG1lYW5zICJ1c2UgcGxhdGZvcm0gZGVmYXVsdCIgKi8KPiA+PiAtICAgICAgIGlm
IChpOTE1X21vZHBhcmFtcy5lbmFibGVfZ3VjX3N1Ym1pc3Npb24gPCAwKQo+ID4+IC0gICAgICAg
ICAgICAgICBpOTE1X21vZHBhcmFtcy5lbmFibGVfZ3VjX3N1Ym1pc3Npb24gPSAgCj4gPj4gSEFT
X0dVQ19TQ0hFRChkZXZfcHJpdik7Cj4gPj4gKyAgICAgICBpZiAoaTkxNV9tb2RwYXJhbXMuZW5h
YmxlX2d1YyA8IDApCj4gPj4gKyAgICAgICAgICAgICAgIGk5MTVfbW9kcGFyYW1zLmVuYWJsZV9n
dWMgPSAgCj4gPj4gX19nZXRfcGxhdGZvcm1fZW5hYmxlX2d1YyhkZXZfcHJpdik7Cj4gPj4gKwo+
ID4+ICsgICAgICAgRFJNX0RFQlVHX0RSSVZFUigiZW5hYmxlX2d1Yz0lZCAoc3VibWlzc2lvbjol
cyBodWM6JXMpXG4iLAo+ID4+ICsgICAgICAgICAgICAgICAgICAgICAgICBpOTE1X21vZHBhcmFt
cy5lbmFibGVfZ3VjLAo+ID4+ICsgICAgICAgICAgICAgICAgICAgICAgICB5ZXNubyhpbnRlbF91
Y19pc191c2luZ19ndWNfc3VibWlzc2lvbigpKSwKPiA+PiArICAgICAgICAgICAgICAgICAgICAg
ICAgeWVzbm8oaW50ZWxfdWNfaXNfdXNpbmdfaHVjKCkpKTsKPiA+PiArCj4gPj4gKyAgICAgICAv
KiBWZXJpZnkgR3VDIGZpcm13YXJlIGF2YWlsYWJpbGl0eSAqLwo+ID4+ICsgICAgICAgaWYgKGlu
dGVsX3VjX2lzX3VzaW5nX2d1YygpICYmICAKPiA+PiAhaW50ZWxfdWNfZndfaXNfc2VsZWN0ZWQo
Z3VjX2Z3KSkgewo+ID4+ICsgICAgICAgICAgICAgICBEUk1fV0FSTigiSW5jb21wYXRpYmxlIG9w
dGlvbiBkZXRlY3RlZDogZW5hYmxlX2d1Yz0lZCwgIAo+ID4+ICVzIVxuIiwKPiA+PiArICAgICAg
ICAgICAgICAgICAgICAgICAgaTkxNV9tb2RwYXJhbXMuZW5hYmxlX2d1YywKPiA+PiArICAgICAg
ICAgICAgICAgICAgICAgICAgIUhBU19HVUMoZGV2X3ByaXYpID8gIm5vIEd1QyBoYXJkd2FyZSIg
Ogo+ID4+ICsgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAibm8g
R3VDIGZpcm13YXJlIik7Cj4gPj4gKyAgICAgICB9Cj4gPj4gKwo+ID4+ICsgICAgICAgLyogVmVy
aWZ5IEh1QyBmaXJtd2FyZSBhdmFpbGFiaWxpdHkgKi8KPiA+PiArICAgICAgIGlmIChpbnRlbF91
Y19pc191c2luZ19odWMoKSAmJiAgCj4gPj4gIWludGVsX3VjX2Z3X2lzX3NlbGVjdGVkKGh1Y19m
dykpIHsKPiA+PiArICAgICAgICAgICAgICAgRFJNX1dBUk4oIkluY29tcGF0aWJsZSBvcHRpb24g
ZGV0ZWN0ZWQ6IGVuYWJsZV9ndWM9JWQsICAKPiA+PiAlcyFcbiIsCj4gPj4gKyAgICAgICAgICAg
ICAgICAgICAgICAgIGk5MTVfbW9kcGFyYW1zLmVuYWJsZV9ndWMsCj4gPj4gKyAgICAgICAgICAg
ICAgICAgICAgICAgICFIQVNfSFVDKGRldl9wcml2KSA/ICJubyBIdUMgaGFyZHdhcmUiIDoKPiA+
PiArICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIm5vIEh1QyBm
aXJtd2FyZSIpOwo+ID4+ICsgICAgICAgfQo+ID4KPiA+IFdpdGggdGhlIGludGVudCB0aGF0IGFm
dGVyIHRoZSB3YXJuaW5nLCB0aGUgdWMgbG9hZCB3aWxsIGZhaWwgYW5kIHRoZQo+ID4gbW9kdWxl
IGxvYWQgd2lsbCB0aGVuIGFib3J0PyBKdXN0IHRvIGJlIGNsZWFyLgo+ID4KPiAKPiBZZXMuIEFz
IEknbSBub3Qgc3VyZSB0aGF0IHdlIHNob3VsZCBpZ25vcmUgZXhwbGljaXQgdXNlciBvcHRpb25z
IGFuZAo+IHByZXRlbmQgdGhhdCBub3RoaW5nIHJlYWxseSBoYXBwZW4gYW5kIGNvbnRpbnVlIHdp
dGggc29tZSBmYWxsYmFjay4KPiAKPiBCdXQgSSBtdXN0IGFkbWl0IHRoYXQgd2l0aCB0aGlzIHBh
dGNoIHdlIGNhbiB1cHNldCB1c2VycyB3aGVuIG1vZHVsZSBpcwo+IGxvYWRlZCB3aXRoIGVuYWJs
ZV9ndWM9LTEoYXV0bykgYW5kIGRyaXZlciBoYXMgY29ycmVzcG9uZGluZyBHdUMvSHVDIGZ3Cj4g
ZGVmaW5pdGlvbnMgYnV0IGZpcm13YXJlIGJsb2JzIGFyZSBub3QgcHJlc2VudCBvbiB0aGUgdGFy
Z2V0IG1hY2hpbmUuCj4gCj4gVGhlbiB3ZSBjYW4gd3JvbmdseSByZWFkIHRoZXNlIG9wdGlvbnMg
YXMgZXhwbGljaXQgYW5kIGFib3J0IG1vZHVsZSBsb2FkCj4gZHVlIHRvIGZ3IHVwbG9hZCBmYWls
dXJlLgo+IAo+IEJ1dCBpbXBhY3Qgb2YgdGhpcyBpc3N1ZSBjYW4gYmUgbWluaW1pemVkIGlmIHdl
IHRyeSB0byBmZXRjaCBHdUMvSHVDCj4gZmlybXdhcmVzIG11Y2ggZWFybGllciAoaW5pdF9lYXJs
eSkuIFRoZW4gd2UgY2FuIHF1aWNrbHkgdXBkYXRlIG91cgo+ICJwcmVmZXJyZWQiIGF1dG8gb3B0
aW9ucyBpbnRvICJhdmFpbGFibGUiLiBIb3dldmVyLCBpZiB3ZSBmYWlsIG9uIGFueQo+IGxhdGVy
IHN0YWdlLCBhZnRlciB3ZSBkZWNpZGVkIHRvIGVuYWJsZSBHdUMvSHVjLCB0aGVyZSBzdGlsbCB3
aWxsIGJlCj4gbm8gZmFsbGJhY2sgYW5kIHdlIHdpbGwgYWJvcnQgZHJpdmVyIGxvYWQuCgpUaGF0
IHdvcnJpZXMgbWUuIEJ1dCBub3QgZW5vdWdoIHRvIG5vdCBnaXZlIGEgci1iClJldmlld2VkLWJ5
OiBDaHJpcyBXaWxzb24gPGNocmlzQGNocmlzLXdpbHNvbi5jby51az4KCkkgaGF2ZSBuaWdodG1h
cmVzIG9mIHVzZXJzIGJyaWNraW5nIHRoZWlyIGNvbXB1dGVycyBqdXN0IGJlY2F1c2UgYW4KdXBk
YXRlIGdvZXMgd3JvbmcuIE9yIG1vcmUgbGlrZWx5IGEga2VybmVsIGlzIHVwZGF0ZWQgd2l0aG91
dCB0aGUKYWNjb21wYW55aW5nIGxpbnV4LWZpcm13YXJlLiBJIHRoaW5rIHdlIHNob3VsZCBkZWZp
bml0ZWx5IGJlIHRlc3RpbmcKbW9kdWxlLWxvYWQgd2l0aCBpbmNvcnJlY3QgZmlybXdhcmUgYW5k
IGVuc3VyZSB3ZSBkb24ndCBsZWF2ZSBhIHN5c3RlbQp3aXRoIGEgYmxhbmstc2NyZWVuLW9mLWRv
b20uCi1DaHJpcwpfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f
XwpJbnRlbC1nZnggbWFpbGluZyBsaXN0CkludGVsLWdmeEBsaXN0cy5mcmVlZGVza3RvcC5vcmcK
aHR0cHM6Ly9saXN0cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0aW5mby9pbnRlbC1nZngK