From: Chris Wilson <chris@chris-wilson.co.uk>
To: Michal Wajdeczko <michal.wajdeczko@intel.com>,
intel-gfx@lists.freedesktop.org
Subject: Re: [PATCH v3 5/8] drm/i915/uc: Don't use -EIO to report missing firmware
Date: Wed, 06 Dec 2017 12:29:13 +0000 [thread overview]
Message-ID: <151256335378.3497.17163144541200401204@mail.alporthouse.com> (raw)
In-Reply-To: <20171205163844.41264-5-michal.wajdeczko@intel.com>
Quoting Michal Wajdeczko (2017-12-05 16:38:41)
> -EIO has special meaning and is used when we want to allow
> engine initialization to fail and mark GPU as wedged.
>
> However here at this function we should return error code
> that corresponds to upload status only, as any decision how
> to handle missing firmware should be done higher level function
> (silent fallback to non-GuC mode, fail into wedged mode, or
> abort driver load with fatal error).
>
> v2: commit message update (Michal)
>
> Signed-off-by: Michal Wajdeczko <michal.wajdeczko@intel.com>
> Cc: Chris Wilson <chris@chris-wilson.co.uk>
> Cc: Joonas Lahtinen <joonas.lahtinen@linux.intel.com>
> Cc: Sagar Arun Kamble <sagar.a.kamble@intel.com>
With my fears expressed elsewhere,
Reviewed-by: Chris Wilson <chris@chris-wilson.co.uk>
-Chris
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
next prev parent reply other threads:[~2017-12-06 12:29 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-12-05 16:38 [PATCH v3 1/8] drm/i915/huc: Move firmware selection to init_early Michal Wajdeczko
2017-12-05 16:38 ` [PATCH v3 2/8] drm/i915/guc: " Michal Wajdeczko
2017-12-05 16:38 ` [PATCH v3 3/8] drm/i915/guc: Introduce USES_GUC_xxx helper macros Michal Wajdeczko
2017-12-05 22:43 ` Chris Wilson
2017-12-06 11:24 ` Michal Wajdeczko
2017-12-06 11:32 ` Chris Wilson
2017-12-06 13:41 ` Chris Wilson
2017-12-05 16:38 ` [PATCH v3 4/8] drm/i915/uc: Don't fetch GuC firmware if no plan to use GuC Michal Wajdeczko
2017-12-05 22:40 ` Chris Wilson
2017-12-05 16:38 ` [PATCH v3 5/8] drm/i915/uc: Don't use -EIO to report missing firmware Michal Wajdeczko
2017-12-06 12:29 ` Chris Wilson [this message]
2017-12-05 16:38 ` [PATCH v3 6/8] drm/i915/guc: Combine enable_guc_loading|submission modparams Michal Wajdeczko
2017-12-05 22:47 ` Chris Wilson
2017-12-06 12:10 ` Michal Wajdeczko
2017-12-06 12:19 ` Chris Wilson
2017-12-05 16:38 ` [PATCH v3 7/8] drm/i915/huc: Load HuC only if requested Michal Wajdeczko
2017-12-06 9:12 ` Sagar Arun Kamble
2017-12-05 16:38 ` [PATCH v3 8/8] HAX enable GuC/HuC load Michal Wajdeczko
2017-12-05 22:14 ` Rodrigo Vivi
2017-12-05 17:17 ` ✗ Fi.CI.BAT: warning for series starting with [v3,1/8] drm/i915/huc: Move firmware selection to init_early Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=151256335378.3497.17163144541200401204@mail.alporthouse.com \
--to=chris@chris-wilson.co.uk \
--cc=intel-gfx@lists.freedesktop.org \
--cc=michal.wajdeczko@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.